September 2011 - Wine-devel

Re: [1/2] shell32/tests: Fix path comparison
by Marvin 06 Sep '11

06 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14016 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:193: Test failed: WaitForSingleObject(hProcess) returned 258

1 0

Re: [2/2] shdoclc & user32 & wineconsole & wordpad: Specify a message context for cut and paste
by Alexandre Julliard 06 Sep '11

06 Sep '11

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > MENUITEM "Select &All", IDM_SELECTALL > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE > MENUITEM SEPARATOR > MENUITEM "Create Shor&tcut", IDM_CREATESHORTCUT > MENUITEM "Add to &Favorites...", IDM_ADDFAVORITES > @@ -73,10 +73,10 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as Back&ground", IDM_SETWALLPAPER > MENUITEM "Set as &Desktop Item...", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > - MENUITEM "Cu&t", IDM_CUT > + MENUITEM "#msgctxt#Shell#Cu&t", IDM_CUT > MENUITEM "&Copy", IDM_COPY > MENUITEM "Copy Shor&tcut", IDM_COPYSHORTCUT > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE That's not a very useful context. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy 06 Sep '11

06 Sep '11

On Tue, Sep 6, 2011 at 09:35, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > It's just a resend. The patch is unmodified, just rebased on latest git. > > try4: > - add missing NULL ending character to help_option string > > try3: > - fix /? option. This fixes cmd tests regression > > try2: > - keep attrib infos for help command > - update po files > > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. I've got test failures with your patch ("make test" in programs/cmd/tests) First error: batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591 (got 'r.test not found before delete, bad', wanted 'r.test found before delete, good') Also, beware that testbot won't test your patch on windowses since it doesn't change any file in tests/ directory (you might want to submit it manually with, say, a small change in test_builtins.cmd and/or test_builtins.exp) See http://wiki.winehq.org/CmdConformanceTests (recently written) if you need help with the keywords, etc. Frédéric

2 2

Fwd: [ANNOUNCE] Git User's Survey 2011
by Andrew Eikum 06 Sep '11

06 Sep '11

It's that time of year again. I thought I'd forward this on to wine-devel since we're all Git users here. ----- Forwarded message from Jakub Narebski <jnareb(a)gmail.com> ----- Date: Mon, 5 Sep 2011 02:43:20 +0200 From: Jakub Narebski <jnareb(a)gmail.com> To: git(a)vger.kernel.org Subject: [ANNOUNCE] Git User's Survey 2011 User-Agent: KMail/1.9.3 Hello all, We would like to ask you a few questions about your use of the Git version control system. This survey is mainly to understand who is using Git, how and why. The results will be published to the Git wiki on the GitSurvey2011 page (https://git.wiki.kernel.org/index.php/GitSurvey2011) and discussed on the git mailing list. The survey would be open from 5 September till 3 October 2011. Please devote a few minutes of your time to fill this simple questionnaire, it will help a lot the git community to understand your needs, what you like of Git, and of course what you don't like of it. The survey can be found here: http://tinyurl.com/GitSurvey2011 https://www.survs.com/survey/VCAGZA8CT5 There is also alternate version which does not require cookies, but it doesn't allow one to go back to response and edit it. https://www.survs.com/survey/MRRGT8OEFV P.S. At request I can open a separate channel in survey, with a separate survey URL, so that responses from particular site or organization could be separated out. Please send me a email with name of channel, and I will return with a separate survey URL to use. -- Git Development Community -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----- End forwarded message -----

1 0

script to run all good tests / all flaky tests / etc.
by Dan Kegel 06 Sep '11

06 Sep '11

The buildbot does three things to get fast, reliable test runs: - it runs a 'safe' set of tests in the background, without DISPLAY set, in a different wineprefix; this saves three minutes - it has a blacklist of known flaky or broken tests, listing how it's broken and linking to the bug report - it kills wineserver after the run (since some tests leave processes around) I hoisted these out of the buildbot config and into a separate script, http://code.google.com/p/winezeug/source/browse/trunk/buildbot/dotests.sh As a bonus, you can ask it to run all the flaky tests instead of all the good ones, which might be useful if you're trolling for test bugs to fix. Here's the current blacklist from that script: # Blacklist format # test condition [bug] # Tests may appear multiple times in the list. # Supported conditions: # FLAKY - fails sometimes # CRASHY - crashes sometimes # SYS - always fails on some systems, not on others # HEAP - fails or crashes if warn+heap # NOTTY - test fails if output redirected # BAD64 - always fails on 64 bits cat > /tmp/blacklist.txt <<_EOF_ dlls/kernel32/tests/heap.ok HEAP dlls/dsound/tests/ds3d8.ok SYS 8668 dlls/dsound/tests/ds3d.ok SYS 8668 dlls/dsound/tests/dsound8.ok SYS 8668 dlls/dsound/tests/dsound.ok SYS 8668 dlls/user32/tests/input.ok SYS 12053 dlls/user32/tests/msg.ok SYS 12053 dlls/user32/tests/win.ok SYS 12053 dlls/oleaut32/tests/tmarshal.ok BAD64 26768 dlls/ieframe/tests/ie.ok BAD64 26768 dlls/ws2_32/tests/sock.ok CRASHY 28012 dlls/wininet/tests/urlcache.ok FLAKY 28038 dlls/winmm/tests/wave.ok SYS 28048 dlls/winmm/tests/mci.ok SYS 28071 dlls/urlmon/tests/url.ok FLAKY 28108 dlls/winmm/tests/capture.ok SYS 28109 dlls/shell32/tests/shlfolder.ok SYS 28216 dlls/kernel32/tests/process.ok NOTTY 28220 dlls/d3dx9_36/tests/shader.ok HEAP 28255 dlls/kernel32/tests/pipe.ok HEAP 28257 programs/cmd/tests/batch.ok HEAP 28258 dlls/dsound/tests/ds3d8.ok HEAP 28260 dlls/dsound/tests/ds3d.ok HEAP 28260 dlls/mshtml/tests/style.ok HEAP 28262 dlls/winhttp/tests/winhttp.ok SYS 28267 programs/wscript/tests/run.ok BAD64 28285 dlls/msctf/tests/inputprocessor.ok FLAKY 28288 _EOF_

2 2

Re: uxtheme: Return error on invalid parameters
by Alexandre Julliard 06 Sep '11

06 Sep '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > uxtheme: Return error on invalid parameters Get/SetPropW already check the handle, don't add redundant checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros. (try 2)
by Alexandre Julliard 06 Sep '11

06 Sep '11

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -59,57 +59,87 @@ typedef BOOL (CALLBACK *LPFNADDPROPSHEETPAGES)(LPVOID, LPFNADDPROPSHEETPAGE, LPA > /* > * Property sheet support (structures) > */ > +#ifndef _WIN32 > +typedef const VOID* PROPSHEETPAGE_RESOURCE; > +#elif defined(UNICODE) > +typedef LPCDLGTEMPLATEW PROPSHEETPAGE_RESOURCE; > +#else > +typedef LPCDLGTEMPLATEA PROPSHEETPAGE_RESOURCE; > +#endif That one should be disallowed too. And testing _WIN32 isn't useful in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [The Official Wine Wiki] Update of "ConformanceTests"
by Joerg-Cyril.Hoehle＠t-systems.com 06 Sep '11

06 Sep '11

François Gouget asked: >> + * Depending on OSX settings, the firewall will ask whether to >> allow incoming network access for tests involving server sockets. >Does it cause test failures? Sorry, I've not tracked it down. Either I click "agree" fast enough (they occur towards the end of the ~20 minutes winetest.exe run) and the tests proceed, or presumably the test exe is killed after a timeout. I tend to "babysit" test execution for that reason (and because I only went online for the purpose of test execution, bug #20219). >Does one have to disable the firewall? I configured the Mac too long ago to remember. Presumably it's a matter of restrictive configuration, otherwise other users would have raised the topic already. Regards, Jörg Höhle

1 0

Re: [2/2] ntdll: Allow reading from a VPROT_WRITECOPY protected memory
by Dmitry Timoshkov 06 Sep '11

06 Sep '11

André Hentschel wrote: > As per tests in kernel32:loader it seems linux&co allows reads on PROT_WRITE areas, but solaris doesn't and crashes. > This fixes this issue. > - if (vprot & VPROT_WRITECOPY) prot |= PROT_WRITE; > + if (vprot & VPROT_WRITECOPY) prot |= PROT_READ | PROT_WRITE; Do you mean that the recently added test for resource section access mapping crashes on Solaris? If yes, then the fix should be done in different place. -- Dmitry.

2 3

Re: comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros.
by Alexandre Julliard 06 Sep '11

06 Sep '11

Francois Gouget <fgouget(a)free.fr> writes: > @@ -213,6 +247,27 @@ DECL_WINELIB_TYPE_AW(PROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPCPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPFNPSPCALLBACK) > +#ifdef UNICODE > +typedef PROPSHEETPAGEW_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEW_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEW_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEW_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEW_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEW_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEW_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERW_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERW_V2_SIZE > +#else > +typedef PROPSHEETPAGEA_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEA_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEA_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEA_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEA_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEA_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEA_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERA_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERA_V2_SIZE > +#endif Please use the appropriate Winelib macros to define A/W mappings. -- Alexandre Julliard julliard(a)winehq.org

2 2