January 2012 - Wine-devel - list.winehq.org

Re: comdlg32: Correctly handle filters with multiple file extensions in Save As dialogs (try 3)
by Marvin 20 Jan '12

20 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16587 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

resolving dead-locks using InterlockedPushEntrySList on MacOS #29657
by Joerg-Cyril.Hoehle＠t-systems.com 20 Jan '12

20 Jan '12

Hi, Let's assume for the discussion that Winecoreaudio/mmdevdrv.c: ca_in_buffer_cb(...) { OSSpinLockLock(&This->lock); list_add_tail(&This->avail_buffers, &buf->entry); This->inbuf_frames += buffer->mAudioDataByteSize / This->fmt->nBlockAlign; OSSpinLockUnlock(&This->lock); } really is causing deadlocks and leads to bogus code like releasing locks mid-function to call other functions that may take the lock too: OSSpinLockUnlock(&This->lock); sc = AudioQueueFlush(This->aqueue); sc = AudioQueuePause(This->aqueue); OSSpinLockLock(&This->lock); -- alas allowing any other thread to enter mmdevdrv in between. (I'll have to perform more checks this week-end). For reference, see bug #29657. I thought about using lock-free data structures: a) MacOS lock-free FIFO b) MS' InterlockedPushEntrySList c) other schemes a) MacOS' lock-free FIFO: MacOS OSAtomicFifoEnqueue is only available with Lion, which rules it out. http://developer.apple.com/library/mac/#documentation/DriversKernelHardware… b) MS' InterlockedPushEntrySList: That is implemented in dlls/ntdll/rtl.c However, I presumably can't call that from within the MacOS callback, because the cross-library call might get logged by +relay, and that's a no-no within the native callback (RunLoop) execution context. Work-around: copy&paste that function into winecoreaudio I don't like that much but do you have a better idea? c) other schemes: Assuming list elements are returned in the order we sent them out, we don't need to enqueue them and instead could set a bit or use InterlockedIncrement (like the MCI does with winmm headers). Is there any other suggestion that comes to mind? IMHO, ca_in_buffer_cb doesn't need a transaction around enqueue+inbuf. Enqueue and inbuf+= could be performed separately, inbuf+= could even be deferred to GetCurrentPadding, leaving one single operation left to do within the MacOS callback. Regards, Jörg Höhle

1 0

Re: [PATCH] ieframe: Added HTTP navigation and GoBack tests
by Marvin 20 Jan '12

20 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16580 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3227: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2484: Test failed: expected GetOverridesKeyPath webbrowser.c:2488: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2489: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2098: Test failed: put_Resizable failed: 80004001 webbrowser.c:2099: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2103: Test failed: put_Resizable failed: 80004001 webbrowser.c:2104: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2484: Test failed: expected GetOverridesKeyPath webbrowser.c:2488: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2489: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:407: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2098: Test failed: put_Resizable failed: 80004001 webbrowser.c:2099: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2103: Test failed: put_Resizable failed: 80004001 webbrowser.c:2104: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2484: Test failed: expected GetOverridesKeyPath webbrowser.c:2488: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2489: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2774: Test failed: expected TranslateUrl webbrowser.c:2775: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2777: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2783: Test failed: ReadyState = 1, expected 4 webbrowser.c:2593: Test failed: ReadyState = 1, expected 4 webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:812: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:819: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:901: Test failed: ReadyState = 1, expected 4 webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3170: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2640: Test failed: expected TranslateUrl webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3177: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2640: Test failed: expected TranslateUrl webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2774: Test failed: expected TranslateUrl webbrowser.c:2775: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2783: Test failed: ReadyState = 1, expected 4 webbrowser.c:2593: Test failed: ReadyState = 1, expected 4 webbrowser.c:812: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:819: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:901: Test failed: ReadyState = 1, expected 4 webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2593: Test failed: ReadyState = 1, expected 4 webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:812: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:901: Test failed: ReadyState = 1, expected 4 webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2888: Test failed: expected RequestUIActivate webbrowser.c:2980: Test failed: Got 0x80004002 webbrowser.c:3075: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040CDE2

2 1

re: PVS-Studio run against ReactOS: (at least) one bug in wine git
by Dan Kegel 20 Jan '12

20 Jan '12

Hey, cool! I added that to http://wiki.winehq.org/StaticAnalysis I figured I'd try running PVS-Studio on the Wine sources in Wine, but it runs in the Visual Studio context, and I can't even load the wine project successfully under warn+heap; see http://bugs.winehq.org/show_bug.cgi?id=29509 (It'd be awesome if we could build wine with visual studio 2005, not only to use it with PVS-Studio, but just for the sake of self-hosting.)

2 2

Re: (try 4)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate
by Dmitry Timoshkov 20 Jan '12

20 Jan '12

Aric Stewart <aric(a)codeweavers.com> wrote: > The problem is that there is no XK keycode for just Shift, Control or > Menu so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result > the string XKeysymToString returns is a string with a _L or _R at the > end, even if the "don't care" bit is set. > > try4: Formatting changes suggested by Dmitry Timoshkov How abot the casts? And spacing is still not consitent. -- Dmitry.

2 4

Getting Wine's PO files on Launchpad
by Francois Gouget 20 Jan '12

20 Jan '12

Launchpad has a PO file translation website. This makes it easier for non-developpers to contribute and review translations. https://translations.launchpad.net/ So what would it take to get Wine's PO files on Launchpad? * Launchpad tracks who translated what string and if we choose the 'Closed' permissions model only approved translators can update the translations. So that means we should be able to get patches with full attribution. https://help.launchpad.net/Translations/YourProject/PermissionPolicies * Launchpad would need to pull updated PO files from Wine regularly. Ideally that would be automatic and happen daily (both to account for translations happening outside Launchpad and to take changes in the resource files into account quickly). https://help.launchpad.net/Translations/YourProject/ImportingTranslations * Conversely Launchpad should submit patches back to Wine. Ideally that would be automated as much as possible but I'm fuzzy on the details here (especially on how to preserve attribution). As for the periodicity, maybe the best would be weekly or just before Alexandre makes a release. https://help.launchpad.net/Translations/YourProject/Exports https://help.launchpad.net/Translations/YourProject/PartialPOExport -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

8 10

Major mmdevapi and winmm audio bugs
by Joerg-Cyril.Hoehle＠t-systems.com 20 Jan '12

20 Jan '12

Hi, Again, the list is quite different from what I posted last month, partly because of a shift in focus. The good news is: judging from bugzilla, audio seems to work much better since 1.3.36/37. #29294 no sound with ALSA loopback #28781 loopback to Jack It is not acceptable for winealsa to solely know "default" and "hw:x,y". The user can define and use any other name in the asound.conf files. The old winealsa obeyed registry settings to override the card name(s). IMHO, winealsa MUST provide such an override. It is not acceptable to replace "default" in dlls/winealsa.drv/mmdevdrv.c and recompile. Furthermore, it was trivial with old winecfg to disable sound in a compatible manner (= answers to API functions like from a native box without sound). What to do now? WINEDEBUG=mmdevapi= is not compatible. W.r.t. configuration, what is the now recommended way for users to self-diagnose MIDI issues? In the ancient winecfg audio tab, Wine would list their MIDI devices in device order, as I explained in http://wiki.winehq.org/MIDI Now users don't know what Wine chooses. #8054 asked in 2007 already for an option to select the default MIDI device via winecfg (achievable via MIDIMap registry entry) #29299 need to play leading/trailing silence for ALSA block-oriented devices That takes various forms and can cause any affected app to hang. #28273 handle "worst case little prefill/underrun" scenario well #28039 MacOS GetPosition #29657 MacOS memory management and dead-lock #29585 OSS needs to be updated to be on par with ALSA refinements #29305 one winmm device seems to stomp over the data of another one #28388 Avoid SuspendThread, should be easy for me to fix, given time There are issues not associated with a bug entry: - Add run-time consistency checks in renderer and abort audio stream (GetBuffer) upon trouble instead of hanging. - perhaps use AUDCLNT_E_DEVICE_INVALIDATED when we see PA restarted and have our DSound and winmm deal with that return code (Would that help #29369?) - Mixer/Card recognition of some ALSA devices - Check OSS4 with and without vmix #28056 #28790 - Investigate OSS4 underrun behaviour - Check WHDR_BEGIN/ENDLOOP code and write tests (I know at least one bug involving waveOutBreakLoop) - DSound still bears traces of its former dependency on winmm blocks, not adequate with mmdevapi - semantics of DSound GetPosition Winealsa's initial scanning of devices and the enumeration tests do not produce reliable results because some high-level ALSA devices like to cling to the underlying one for a couple of seconds. Hence, accessing "default" (routed to pulse) may block "hw:0" for ~3 seconds. Of course there are more bugs than this. Regards, Jörg Höhle

2 1

Re: (try 3)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate
by Dmitry Timoshkov 20 Jan '12

20 Jan '12

Aric Stewart <aric(a)codeweavers.com> wrote: > + char* idx = strrchr(name,'_'); > + if (idx) > + { > + if (strcasecmp(idx,"_r")==0 || strcasecmp(idx,"_l")==0) > + { > + INT rc = 0; > + TRACE("found scan=%04x keyc=%u keysym=%04x modified_string=%s\n", > + scanCode, keyc, (int)keys, debugstr_an(name,idx-name)); > + if (lpBuffer && nSize) > + { > + rc = MultiByteToWideChar(CP_UNIXCP, 0, name, idx-name, lpBuffer, nSize); Using consistent spacing and avoiding not necessary casts would improve the readability a bit. -- Dmitry.

1 0

Re: mmcndmgr: Implement IMMCVersionInfo
by Alistair Leslie-Hughes 20 Jan '12

20 Jan '12

Ignore this. On 20/01/2012 9:32 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mmcndmgr: Implement IMMCVersionInfo > > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: kernel32: add stubs for GetConsoleCommandHistoryLengthA/W
by Dmitry Timoshkov 20 Jan '12

20 Jan '12

Austin English <austinenglish(a)gmail.com> wrote: > +DWORD WINAPI GetConsoleCommandHistoryLengthA(LPSTR unknown) > +{ > + FIXME(": (%s) stub!\n", unknown); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return 0; > +} > + > +/* Undocumented, called by native doskey.exe */ > +/* FIXME: Should use CONSOLE_GetHistory() above for full implementation */ > +DWORD WINAPI GetConsoleCommandHistoryLengthW(LPWSTR unknown) > +{ > + FIXME(": (%s) stub!\n", wine_dbgstr_w(unknown)); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return 0; > +} It's a common rule that contents of non-const (string) parameters (which are probably the output ones) should not be printed in traces, and their type in the .spec files can't be (w)str. Same belongs to your other patches. -- Dmitry.

1 0