January 2012 - Wine-devel - list.winehq.org

Re: [2/2] scrrun: Register Scripting interfaces
by Nikolay Sivov 26 Jan '12

26 Jan '12

On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Register Scripting interfaces Some of this are already used in wshom.ocx, I'm not sure which one should take precedence and implement that. Probably it changed in recent Windows versions?

3 6

fwd: winealsa: snd_card_get_name uses strdup (Valgrind).
by Joerg-Cyril.Hoehle＠t-systems.com 26 Jan '12

26 Jan '12

Hi, Andrew Eikum updated ALSA's documentation http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=226a34ac09e5d9c0… Now that free() is documented, the pending patch #82900 should be applied. Regards, Jörg Höhle

1 0

Re: shell32: Use simple helper for case insensitive strstr()
by Alexandre Julliard 26 Jan '12

26 Jan '12

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix for http://bugs.winehq.org/show_bug.cgi?id=28087 You shouldn't need anything of the kind. If StrStrIW doesn't work right it should be fixed (plus of course there's no reason to even use strstr() here at all). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Remove extraneous full stops from the Japanese translation.
by Akihiro Sagawa 25 Jan '12

25 Jan '12

Hi Francois, On Tue, 24 Jan 2012 00:28:02 +0100 (CET), Francois Gouget wrote: > This is essentially the kernel32 error messages. > > po/ja.po | 1587 +++++++++++++++++++++++++++++++------------------------------- > 1 files changed, 792 insertions(+), 795 deletions(-) IMHO, the error message should be well-formed sentences. I confused a lot while translating because some messages are not sentence style. For such a reason, I translated the message into Japanese sentence. So full-stops are reasonable. Additionally, in Windows, a sentence with periods or full-stops is used for the error message. So a Japanese Wine user might feel something wrong with the message if I translate without full-stops. Best regards, Akihiro Sagawa

3 4

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game
by Henri Verbeet 25 Jan '12

25 Jan '12

On 22 January 2012 19:44, Detlef Riekenberg <wine.dev(a)web.de> wrote: > - if (usage & ~handled) > + static DWORD reported_once; > + > + if (usage & ~(handled | reported_once)) > + { > + reported_once |= (usage & ~handled); > FIXME("Unhandled usage flags %#x.\n", usage & ~handled); > + } I don't think so.

6 7

Re: ieframe: Fixed a typo in IDocObjectService::FireNavigateComplete2
by Marvin 25 Jan '12

25 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16644 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3245: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2116: Test failed: put_Resizable failed: 80004001 webbrowser.c:2117: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2121: Test failed: put_Resizable failed: 80004001 webbrowser.c:2122: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:407: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2116: Test failed: put_Resizable failed: 80004001 webbrowser.c:2117: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2121: Test failed: put_Resizable failed: 80004001 webbrowser.c:2122: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2792: Test failed: expected TranslateUrl webbrowser.c:2793: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2795: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2801: Test failed: ReadyState = 1, expected 4 webbrowser.c:2611: Test failed: ReadyState = 1, expected 4 webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:832: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:839: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:788: Test failed: ReadyState = 1, expected 4 webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3188: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2658: Test failed: expected TranslateUrl webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3195: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2658: Test failed: expected TranslateUrl webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2792: Test failed: expected TranslateUrl webbrowser.c:2793: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2801: Test failed: ReadyState = 1, expected 4 webbrowser.c:2611: Test failed: ReadyState = 1, expected 4 webbrowser.c:832: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:839: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:788: Test failed: ReadyState = 1, expected 4 webbrowser.c:1547: Test failed: unexpected call GetDropTarget Timeout

1 0

Resource accelerators discrepancies
by Frédéric Delanoy 25 Jan '12

25 Jan '12

Hi Alexandre, After your addition of accelerators to po file for winefile (among others) [fe021a44 winefile: Add message contexts for accelerators that can be translated], there seems to be some discrepancies: #: winefile.rc:202 msgctxt "accelerator Fullscreen" msgid "^S" vs #: winefile.rc:70 msgid "F&ull Screen\tCtrl+Shift+S" and #: winefile.rc:201 winemine.rc:99 msgctxt "accelerator Exit" msgid "X" vs #: winefile.rc:38 winemine.rc:46 msgid "E&xit\tAlt+X" winefile.rc contains: - "X", ID_FILE_EXIT, VIRTKEY, ALT - "S", ID_VIEW_FULLSCREEN, VIRTKEY, SHIFT, CONTROL + "#msgctxt#accelerator Exit#X", ID_FILE_EXIT, ALT + "#msgctxt#accelerator Fullscreen#^S", ID_VIEW_FULLSCREEN, SHIFT So, - is there a way/shouldn't the "label\tshortcut" menu entries be automated somehow? E.g. so the accelerator is automatically extracted - is only the Control modifier shown in msgids? E.g. "X" while the shortcut is Alt-X. That's a bit inconsistent IMHO Frédéric

2 1

Re: setupapi: add a stub for SetupAddToDiskSpaceListA/W
by Dmitry Timoshkov 25 Jan '12

25 Jan '12

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI SetupAddToDiskSpaceListA(HDSKSPC DiskSpace, PCSTR TargetFilespec, > + LONGLONG FileSize, UINT Operation, > + PVOID Reserved1, UINT Reserved2) I think it's been mentioned numerous times already about usage hungarian or capitalzed variable names in Wine code. -- Dmitry.

1 0

In-process wine server (a.k.a., "Dirty Speed Hack")
by Daniel Santos 25 Jan '12

25 Jan '12

Here's my hack after some cleanup, refinements and further experimentation (mostly discovering what doesn't work). It's still in the early stages. So I had this idea about 3 years ago and when playing Star Wars Battlefront (1 and 2) and having such long load times that I couldn't alleviate much by addressing the bottlenecks (the app spams GetForegroundWindow and PeekMessageA while loading, hitting them each 22k times a second), I finally decided to give this hack a stab. So in summary, loading new maps was taking 75 seconds under wine, where they only take 10 to 15 seconds on windows (well, on my laptop, which is slower than my desktop). With this hack, they are down to 8 seconds under wine, roughly 10x faster. This hack builds a libwineserver.so that the primary application (i.e., the one you first launch) will spawn a thread and run the wine server in the same process, if you've set the environment variable DIRTYNASTYSPEEDHACK. Then, calls to the wineserver are made directly. Subsequent programs in the same WINEPREFIX will interact with your process using the traditional pipes. I don't have the build working the way it should, it currently only builds the libwineserver.so when it builds the server (i.e., not built when you configure with --with-wine-tools). I'm not strong in autotools, so if anybody cares to add this, I would appreciate it :) Obviously, the trade off for this speed increase is that the stability of your wine server (and thus, all apps running under that instance) are based upon the stability of your program. So with this enabled, your program can crash the wine instance. Also, while it addresses the slow loading issues in Star Wars Battlefront II, it behaves very oddly in regards to sound buffers being played correctly and HID input (if I move the mouse slowly downwards, it will actually move slowly up). These problems go away when I debug it (I presume because the debugger is slowing the program back down). I'm going to try this out on a few other apps that run slow under wine (like Finale 2010). Daniel

2 2

Re: comdlg32: Correctly handle filters with invalid extensions in Save As dialogs
by Marvin 24 Jan '12

24 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16639 Your paranoid android. === WVISTAADM (32 bit filedlg) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0