October 2012 - Wine-devel - list.winehq.org

Re: [2/4] ole32: Add tests for StgConvertVariantToProperty.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22018 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] winemaker: Generate def file from spec file with winebuild (try 2)
by Alexandre Julliard 10 Oct '12

10 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2569,6 +2570,7 @@ sub generate_project_files($) > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.def)\n"; > } elsif (@$target[$T_TYPE] == $TT_DLL) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "\t\$(WINEBUILD) --def -E \$(${canon}_MODULE:.dll=.spec) -o lib\$(${canon}_MODULE:.dll=.def)\n"; That's not much better. You should have a proper target for it, and a dependency from the modules that import that dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 2/5, try 3]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:44, Nozomi Kodama wrote: > + if ( green_out ) Same as last time: I'd use "if (x == y)" without spaces on all occurrences... there are a couple of them in the patch! Please make all consistent in the patch.

1 0

Re: d3dx9_36 [patch 3/5, try 3]: Implement handy computations for small orders in D3DXSHRotate
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:45, Nozomi Kodama wrote: > + CONST FLOAT coeff[]={ > > + out[7] -= (matrix->u.m[1][0] * matrix->u.m[0][2] + matrix->u.m[1][2] * matrix->u.m[0][0]) * in[4]; > + > + out[7] += (matrix->u.m[1][0] * matrix->u.m[2][2] + matrix->u.m[1][2] * matrix->u.m[2][0]) * in[5]; Empty line too much? > + for ( l = 0; l < 1; l++) > > + if (l == 0) > + out_temp = out; > + else > + out_temp = in; The test change is completely new in the try... What do you like to achieve with this? l is always 0, isn't it? Beside this, there are some white space issues.

1 0

Re: [PATCH 1/5] include: Added definitions used by GetFileInformationByHandleEx.
by Dmitry Timoshkov 10 Oct '12

10 Oct '12

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > +typedef struct _FILE_ID_DESCRIPTOR { > + DWORD dwSize; > + FILE_ID_TYPE Type; > + union { > + LARGE_INTEGER FileId; > + GUID ObjectId; > +#if (_WIN32_WINNT >= 0x0602) > + EXT_FILE_ID_128 ExtendedFileId; > +#endif > + } DUMMYUNIONNAME; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR; The '#if/#endif' part is useless in Wine (here in in other places as well). Also you should add new structures in every patch that needs them, one by one, not adding a bunch of not used stuff at once. P.S. In PSDK 7.1 (targeting Windows 7) some of the structures look different. Where does this come from? -- Dmitry.

1 0

Wine test bot
by Christian Costa 09 Oct '12

09 Oct '12

Hi, Is there a problem with Wine test bost? Jobs seem to be stuck and some VMs show problem of memory. Christian

1 1

Re: wbemprox: support for getting methods from WBEM objects
by Hans Leidekker 09 Oct '12

09 Oct '12

On Tue, 2012-10-09 at 20:30 +0200, Daniel Jelinski wrote: > diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c > index c414aa9..71c62c8 100644 > --- a/dlls/wbemprox/table.c > +++ b/dlls/wbemprox/table.c > @@ -63,6 +63,7 @@ UINT get_type_size( CIMTYPE type ) > return sizeof(INT64); > case CIM_DATETIME: > case CIM_STRING: > + case CIM_OBJECT: > return sizeof(WCHAR *); This should be fixed differently. I already have a patch in my tree.

1 0

Updated Wine Wiki Repo
by Kyle Auble 09 Oct '12

09 Oct '12

Just wanted to let everyone know I've created a git repo for the Wine Wiki from the CVS one at SourceForge. You can find it at: https://bitbucket.org/kauble/wine-wiki-migration Since it's a fresh repo, I thought editing the history should be ok (just moved the right info into Author & Committer fields and made the commit message formatting more consistent). I do still have the unedited branches from cvsimport and can put those up too if there's any demand for them. I've been talking with Dimi about what we would need to upgrade MoinMoin, and once he can find some time, he said he would setup a regular archive of the Wine Wiki's data. I also like the idea of using tags to mark which wiki version is in use, but I'm not sure how many times the wiki has been upgraded. If anyone knows what versions of MoinMoin we've used and when the upgrades took place, I can add the extra tags. I don't know if there's much interest in just moving this to the Wine git repo yet. If not, I can probably review patches, but would be happy to add someone else as an admin if they have a bitbucket account. - Kyle

4 6

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run. (try 2)
by Austin English 09 Oct '12

09 Oct '12

On Tue, Oct 9, 2012 at 4:27 AM, Roman Dadkov <romand(a)etersoft.ru> wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will not > be able to run the newly created object. > Unfortunately, the test for this case can't be added to Wine, because it > leads a crash. You could put the test inside if(0), so that it's still documented, see, for example, dlls/ole32/tests/stg_prop.c or dlls/user32/tests/input.c. Cheers, Austin

1 0

Re: d3dx9_36 [patch 5/5]: Implement D3DXSHEvalSphericalLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:50, Nozomi Kodama wrote: > + CONST FLOAT coeff[6] = { > + 2.0f * sqrtf(D3DX_PI), 2.0f * sqrtf(D3DX_PI / 3.0f), 0.4f * sqrtf(5.0f * D3DX_PI), > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; Pretty much the same comments as for D3DXSHEvalConeLight apply here too. Beside that, does it make sens to define the coeffs with a better name as static and reuse them? They seem to be the same for both usages. Cheers Rico

1 0