October 2012 - Wine-devel - list.winehq.org

Re: [1/4] gdiplus: Add a font transformation test.
by Vincent Povirk 08 Oct '12

08 Oct '12

Series looks good to me.

1 0

Re: [3/4] ole32: Move the propvariant serialization into a helper function.
by Alexandre Julliard 08 Oct '12

08 Oct '12

Vincent Povirk <madewokherd(a)gmail.com> writes: > From eb900b2807167f25ad8f4e97c558dec8b71b070c Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Thu, 4 Oct 2012 16:58:48 -0500 > Subject: [PATCH 3/4] ole32: Move the propvariant serialization into a helper > function. It doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so suminfo.c && touch suminfo.ok suminfo.c:441: Test succeeded inside todo block: value incorrect suminfo.c:450: Test failed: MsiSummaryInfoSetProperty failed 0 make: *** [suminfo.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Add retail NVIDIA GeForce GTX 660Ti/660/650
by Henri Verbeet 08 Oct '12

08 Oct '12

On 8 October 2012 03:52, Jimmy Hon <honyuenkwun(a)gmail.com> wrote: > + CARD_NVIDIA_GEFORCE_GTX650 = 0x0FC6, > + CARD_NVIDIA_GEFORCE_GTX660 = 0x11C0, > + CARD_NVIDIA_GEFORCE_GTX660TI = 0x1183, Please use lower case constants like everywhere else.

1 0

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Nikolay Sivov 08 Oct '12

08 Oct '12

On 10/6/2012 19:29, Roman Dadkov wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will > not be able to run the newly created object. > > > - hr = CoCreateInstance(&This->clsid, NULL, CLSCTX_LOCAL_SERVER, > + hr = CoCreateInstance(&This->clsid, NULL, > + CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER| > + CLSCTX_LOCAL_SERVER|CLSCTX_REMOTE_SERVER, > &IID_IOleObject, (void **)&This->pOleDelegate); This could be replaced with CLSCTX_ALL. Is it possible to add a test for that?

1 0

Re: iphlpapi/tests: Skip tests if functions are not supported
by Dmitry Timoshkov 07 Oct '12

07 Oct '12

André Hentschel <nerv(a)dawncrow.de> wrote: > For Mac, BSD, Solaris If it's Wine specific, then probably there shouild be a todo_wine somewhere to make it clear that under Windows there is no skips. -- Dmitry.

1 0

Please remove this email address
by Ken Sharp 06 Oct '12

06 Oct '12

Hi, I have been receiving daily digests from this mailbox for a while. I tried emailing the "list owner" according to the website but that had no effect. I have been filtering the digests away so I didn't see that people had replied (thanks to everyone who did, sorry I haven't replied). I have tried changing the preferences but it just tells me that this email address doesn't exist. I can't do anything with this. Could someone with relevant access please remove me so that I can add myself again, properly? Thanks, Ken

1 0

Help getting amd64 assembly patch into wine?
by Joerg-Cyril.Hoehle＠t-systems.com 06 Oct '12

06 Oct '12

Dan, I found your message very unclear. >The patch adds support for OpenMP programs like this: And then you start talking about vcomp_fork without telling us where it comes from and what it should do. So I'll guess from the names. - vcomp_for_static/sections_init sound like startup code initialisation of BSS and DATA segments. - fork sounds like running code with thread-local copies to BSS and DATA I guess vcomp eats up one register or parameter to keep a pointer to the thread-local storage. > p_vcomp_fork(0, 1, _test_vcomp_fork_worker1, &ncalls); Your code does not explain what the first parameter is. I believe that va_list etc. is not going to lead you anywhere. First, va_* is only one side. E.g. include/wine/test.h uses va_list and __builtin_ms_va_list You need the other side too, namely, given a va_* structure, call a function X with the parameters given in that structure. The GNU ffcall library http://www.gnu.org/software/libffcall/ distinguishes both. One half is called vacall, the other one avcall :-) Your tests show that you need 2 different va_lists: > p_vcomp_fork(0, 5, _test_vcomp_fork_worker5, 1, 2, 3, 4, 5); 1. On the receiver side, va_start would create a va_list for the parameter set (0, 5, function pointer, 1, 2, 3, 4, 5) 2. But now you need to call something with the apparent parameter set (1, 2, 3, 4, 5) (I say apparent because you don't explain the vcomp execution model. Is a hidden parameter added somewhere? What's that first parameter 0 to fork?) Obviously, if you don't know the internals of a va_list, you'll not be able to transform one structure into the other. So bad, now what is actually needed? Think assembly. Using your test example: + p_vcomp_fork(0, 5, _test_worker5, 1, 2, 3, 4, 5); _vcomp_fork finds data: 1. on the stack 2. in registers 3. in FP registers The C stack layout is (topmost first): 0, then 5, &_test_worker5, 1, 2, etc. What you obviously need to do is, supposing the first parameters are duplicated in registers: - Save registers and possibly FP registers into a structure - Remember the stack pointer and number of elements, -- hereby creating a va_args structure whose layout you know. - CreateThread?? etc. - Restore registers - Shift register parameters by 3 items: (assuming 5 such registers) register-for-param-1 (1) <- register-for-param-4 register-for-param-2 (2) <- register-for-param-5 - Copy from stack into registers register-for-param-3 (3) <- from stack register-for-param-4 (4) <- from stack register-for-param-5 (5) <- from stack - POP 0 and 5 - POP &_test_worker5 into scratch register - JMPTO _test_worker5 via scratch register This assumes there's nothing like CreateThread so you can run from the original stack. If there were, you'd need to copy the 5 elements from the stack to the new one (which is presumably why vcomp_fork receives their number as parameter). Does this help? Jörg Höhle

3 3

Windows audio architecture
by Saulius Krasuckas 06 Oct '12

06 Oct '12

One link catched my eye here: "The evolution of a data structure – the WAVEFORMAT" https://www.assembla.com/spaces/portaudio/wiki/Win32AudioBackgroundInfo Maybe it is of some use for Wine developers too:) Some URLs need adjustment, though. Eg. Creative Labs description of Vista audio architecture changed to: http://forums.creative.com/showthread.php?t=302341 S.

1 0

Re: [patch 1/1] dlls/windowscodecs/pngformat.c: implemented 'PngDecoder_Block_GetCount'
by Nikolay Sivov 05 Oct '12

05 Oct '12

On 10/5/2012 06:43, max+git(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max+git(a)mtew.isa-geek.net> > > --- > dlls/windowscodecs/pngformat.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c > index 686f9c6..e8e7cbe 100644 > --- a/dlls/windowscodecs/pngformat.c > +++ b/dlls/windowscodecs/pngformat.c > @@ -899,8 +899,10 @@ static HRESULT WINAPI PngDecoder_Block_GetContainerFormat(IWICMetadataBlockReade > static HRESULT WINAPI PngDecoder_Block_GetCount(IWICMetadataBlockReader *iface, > UINT *pcCount) > { > - FIXME("%p,%p: stub\n", iface, pcCount); > - return E_NOTIMPL; > + PngDecoder *This = impl_from_IWICMetadataBlockReader(iface); > + if (!pcCount) return E_INVALIDARG; > + *pcCount = This->ref; > + return S_OK; > } > > static HRESULT WINAPI PngDecoder_Block_GetReaderByIndex(IWICMetadataBlockReader *iface, Return reference count as block count?

3 6

Re: [PATCH 2/3] ntoskrnl.exe: Improve IoGetCurrentProcess stub.
by Dmitry Timoshkov 05 Oct '12

05 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > +EPROCESS process_info; > + > #ifdef __i386__ > #define DEFINE_FASTCALL1_ENTRYPOINT( name ) \ > __ASM_STDCALL_FUNC( name, 4, \ > @@ -1200,8 +1203,11 @@ NTSTATUS WINAPI FsRtlRegisterUncProvider(PHANDLE MupHandle, PUNICODE_STRING Redi > */ > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + FIXME("(): partial stub\n"); > + > + process_info.UniqueProcessId = (PVOID)PsGetCurrentProcessId(); > + > + return &process_info; > } Why do you think that returning the structure filled with garbage is better than returning NULL? -- Dmitry.

3 7