October 2012 - Wine-devel - list.winehq.org

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21999 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21998 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier 03 Oct '12

03 Oct '12

Hello André, AH> In the meantime you could change your preferences in the appdb (Send email notifications) Than I'm in peace - that's right. But this have a side-effect: I also will not be informed by AppDB if someone add a new test or a comment in my attended applications: the mails to remain an applications maintainer to do his work are also switched off. This isn't really what I want. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 3

Overriding the check for ownership of a prefix
by Scott Ritchie 03 Oct '12

03 Oct '12

So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the user launches the app (via desktop file) this in turn launches a script that does the following: 1) Makes a temporary folder 2) Sets up a unionfs-fuse copy-on-write mount between ~/.appname and the read-only packaged prefix in /opt, mounted in the temporary folder 3) Runs the app with WINEPREFIX= the temp folder 4) When the app is finished, unmounts the temp folder This all works quite fine: new (or modified) files within the prefix get stored in ~/.appname, to be restored the next time the user runs the app. Distinct users can run the app simultaneously, as they each have their own prefix. Excess file-copying is avoided, as only the user-modified files need to be stored in the home folders. There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Simply commenting out this part of the code makes Wine work fine, however I'd like to be able to have a proper solution. Would something like a command-line switch or environment variable be acceptable here? Thanks, Scott Ritchie * Note that there is a problem with this setup if the app modifies the registry and we then need to update the prefix-default registry, but that's a different feature request

2 3

Re: [PATCH] advapi32: avoid memory leaks (Coverity)
by Alexandre Julliard 03 Oct '12

03 Oct '12

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -530,8 +530,10 @@ static void test_enum_providers(void) > /* alloc provider to half the size required > * cbName holds the size required */ > providerLen = cbName / 2; > - if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) > + if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) { > + LocalFree(pszProvName); > return; > + } Actually, checking for allocation failures in tests is not useful, it's not going to happen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error
by Jacek Caban 03 Oct '12

03 Oct '12

Hi Marcus, On 10/01/12 23:00, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. > > Second reiteration with Jaceks comment applied Sorry for not catching this later, I was concentrated on your comment instead of the code, but the important thing is that true call_ret means success (and wininet doing request asynchronously is signalled as an error). It means that in this case we want to return RPC_S_OK. What is the exact problem? Jacek

2 2

Re: [PATCH 2/2] vbscript: Added Right() implementation
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21987 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

ImmIsUIMessageA/W
by Aric Stewart 03 Oct '12

03 Oct '12

Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. These changes cause the IME to stop working for IME unaware applications. Where the changed intentional and if so based on what documentation? thanks! -aric

3 9

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier 03 Oct '12

03 Oct '12

Hello Rosanne, sorry for misspelling your first name in my mail before. > I tried deleting the spammer's account, and the system asked me if > I really wanted to, but it didn't delete it even after I said yes. > I'm not sure that would have helped anyway, as he could easily just > create a new account. couldn't you simply reset the spammers password? So if his account is powned he will have to get a new one. > We really do need some sort of moderation for > AppDB comments similar to what's on the forum. In general this is a good idea. -- Regards Joerg Schiermeier Bielefeld/Germany

1 0

AppDB: Could someone please block this Spammer (UCE)
by newsletter [at] Schiermeier-Software 03 Oct '12

03 Oct '12

Hello everybody, could someone of the AppDB admin team please block this UCE-Mails which comes via AppDB-notifications? I'm speaking about this: 1.) Tue, 02 Oct 2012 04:58:05 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631#Comment-8…> 2.) Tue, 02 Oct 2012 12:01:08 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992#Comment-8…> 3.) Tue, 02 Oct 2012 15:11:12 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631> 4.) Tue, 02 Oct 2012 15:35:39 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992> Please Rosane, help us...! Thanks a lot! -- Gruss von Joerg Schiermeier

3 2