October 2012 - Wine-devel - list.winehq.org

Re: [PATCH] Remove potential reference count races
by Nikolay Sivov 28 Oct '12

28 Oct '12

On 10/28/2012 18:00, Max TenEyck Woodbury wrote: > On 10/28/2012 03:13 AM, Nikolay Sivov wrote: >> On 10/28/2012 04:59, max(a)mtew.isa-geek.net wrote: >>> From: Max TenEyck Woodbury <max(a)mtew.isa-geek.net> >>> >>> --- >>> dlls/shlwapi/thread.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/dlls/shlwapi/thread.c b/dlls/shlwapi/thread.c >>> index eb2c35d..43e0433 100644 >>> --- a/dlls/shlwapi/thread.c >>> +++ b/dlls/shlwapi/thread.c >>> @@ -157,7 +157,7 @@ static ULONG WINAPI threadref_AddRef(IUnknown *iface) >>> threadref * This = impl_from_IUnknown(iface); >>> TRACE("(%p)\n", This); >>> - return InterlockedIncrement(This->ref); >>> + return InterlockedIncrement(&This->ref); >>> } >>> static ULONG WINAPI threadref_Release(IUnknown *iface) >>> @@ -167,7 +167,7 @@ static ULONG WINAPI threadref_Release(IUnknown >>> *iface) >>> TRACE("(%p)\n", This); >>> - refcount = InterlockedDecrement(This->ref); >>> + refcount = InterlockedDecrement(&This->ref); >>> if (!refcount) >>> HeapFree(GetProcessHeap(), 0, This); >>> >> Did you try to build this? >> >> > Yes, it built. I don't submit stuff that causes the compiler to barf > unless I am completely totally zonked from lack of sleep and this was > not what happened here. I will admit that I have not looked at the > build and test logs closely, so there may be problems I missed. > These changes I wrong that's what I'm saying. P.S. please CC wine-devel list in your replies.

2 1

on UTF-8, other Unicode encodings and WinAPI
by Saulius Krasuckas 28 Oct '12

28 Oct '12

Proposal with probably several insights: http://www.utf8everywhere.org/ Lyrical, older version: http://www.joelonsoftware.com/articles/Unicode.html S.

1 0

VBSCRIPT.DLL errors with CorelDRAW 12 installer (Wine 1.1.15)
by Gerold Jens Wucherpfennig 28 Oct '12

28 Oct '12

Hi, can someone help me with CorelDRAW 12: http://appdb.winehq.org/objectManager.php?sClass=version&iId=2390&iTestingI… Wine 1.5.15 vanilla without external DLLs Output from setup.exe in output.txt (only uniq lines saved; error code 67 on exit) vbscript errors (lines copied from output.txt): fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\nDim nRemoveVBAEN:nRemoveVBAEN = 0\r\nDim nRemoveVBACZ:nRemoveVBACZ = 0\r\nDim nRemoveVBANL:nRemoveVBAPL = 0\r\n\r\nOn "... fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\nDim nRemoveVBAEN:nRemoveVBAEN = 0\r\nDim nRemoveVBACZ:nRemoveVBACZ = 0\r\nDim nRemoveVBANL:nRemoveVBAPL = 0\r\n\r\nOn "... fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\r\nIf (IsFeatureSelected(\"FontNav\") = True) Then\r\n If ((Session.Property(\"PLLANG\""... fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\r\nIf (IsFeatureSelected(\"FontNav\") = True) Then\r\n If ((Session.Property(\"PLLANG\""... fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\t\r\nIf (IsFeatureExists(\"LocalInstallsOnly\")=\"1\") Then\r\n\tIf ((Session.Property(\""... Best Regards, Gerold

2 1

Re: [PATCH] Remove potential reference count races
by Nikolay Sivov 28 Oct '12

28 Oct '12

On 10/28/2012 04:59, max(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max(a)mtew.isa-geek.net> > > --- > dlls/shlwapi/thread.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/shlwapi/thread.c b/dlls/shlwapi/thread.c > index eb2c35d..43e0433 100644 > --- a/dlls/shlwapi/thread.c > +++ b/dlls/shlwapi/thread.c > @@ -157,7 +157,7 @@ static ULONG WINAPI threadref_AddRef(IUnknown *iface) > threadref * This = impl_from_IUnknown(iface); > > TRACE("(%p)\n", This); > - return InterlockedIncrement(This->ref); > + return InterlockedIncrement(&This->ref); > } > > static ULONG WINAPI threadref_Release(IUnknown *iface) > @@ -167,7 +167,7 @@ static ULONG WINAPI threadref_Release(IUnknown *iface) > > TRACE("(%p)\n", This); > > - refcount = InterlockedDecrement(This->ref); > + refcount = InterlockedDecrement(&This->ref); > if (!refcount) > HeapFree(GetProcessHeap(), 0, This); > Did you try to build this?

1 0

Re: [PATCH] Remove potential reference count races
by Nikolay Sivov 28 Oct '12

28 Oct '12

On 10/28/2012 04:59, max(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max(a)mtew.isa-geek.net> > > --- > dlls/jscript/engine.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Take a look at http://source.winehq.org/git/wine.git/commit/79a30a4e0ae3a7ef640fa38e3a9f77…

1 0

Re: [PATCH] Potential reference count races
by Nikolay Sivov 28 Oct '12

28 Oct '12

On 10/28/2012 04:59, max(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max(a)mtew.isa-geek.net> > > I have been looking at the Microsoft COM and related documentations > and noticed that they emphatically recomend using the Interlocked... > functions when manipulating reference counts. I managed to set up a > search that showed where many of the reference count updates occur and > was somewhat surprised at how often this advice was not followed. It doesn't mean it always has to be followed. > > While I have not converted every reference count update to use the > Interlocked... functions, this set of patches fixes a fair number of > them. > > These are not associated with any particular bug report; they are simply > a general precausion against operations that are known to be associated > with race conditions. This precaution doesn't work in general. It's not enough to atomically update refcount to make an implementation thread safe. Also not everything is supposed to be thread safe in a first place. Changes like this: > - for (i=0;i<howmuch;i++) > + for (i=0;i<howmuch;++i) > TRACE("notify at %d to %p\n", > notify[i].dwOffset,notify[i].hEventNotify); are not helpful at all. > > The patches are independent of each other. They are NOT a series. >

1 0

Re: [PATCH] Remove potential reference count races.
by Nikolay Sivov 28 Oct '12

28 Oct '12

On 10/28/2012 04:59, max(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max(a)mtew.isa-geek.net> > > --- > dlls/gdi32/freetype.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 6af977c..3379c6e 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -3820,7 +3820,7 @@ static struct font_mapping *map_font_file( const char *name ) > { > if (mapping->dev == st.st_dev && mapping->ino == st.st_ino) > { > - mapping->refcount++; > + InterlockedIncrement(&mapping->refcount); > close( fd ); > return mapping; > } > @@ -3850,7 +3850,7 @@ error: > > static void unmap_font_file( struct font_mapping *mapping ) > { > - if (!--mapping->refcount) > + if (!InterlockedDecrement(&mapping->refcount)) > { > list_remove( &mapping->entry ); > munmap( mapping->data, mapping->size ); How does it help exactly and what is the problem with this code?

1 0

Re: [PATCH] wininet: TLS fallback mechanism (take2)
by Hiroshi Miura 27 Oct '12

27 Oct '12

Hi, My updated patch which is Message-ID: <5089BDA7.3040806(a)linux.com> is not properly treated in http://source.winehq.org/patches http://source.winehq.org/patches/data/91337 New one is removed, and the one that make compile error in older openssl is tagged as new. Hiroshi Miura wrote: > OpenSSL 1.0.x now support TLSv1.1 and TLSv1.2. > Sometimes TLSv1.1/1.2 negotiation fails bacause of combination > of server/client ssl library versions. > It fixes the error connecting Evernote server with evernote client. > http://bugs.winehq.org/show_bug.cgi?id=30598 > > It has also mechanism enable/disable TLSv1.1/1.2 by registry entry under > SYSTEM/CurrentControlSet/Control/SecurityProvider/SCHANNEL/Protocols/ > where is as same place as Windows7. > TLSv1.1/1.2 is enabled when the registry entry does not exist. > > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/wininet/netconnection.c | 169 ++++++++++++++++++++++++++++++++---------- > 1 file changed, 130 insertions(+), 39 deletions(-) > > diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c > index c944ff3..9b5f7e7 100644 > --- a/dlls/wininet/netconnection.c > +++ b/dlls/wininet/netconnection.c <snip> > +#ifdef SSL_OP_NO_TLSv1_2 > +static long get_tls_option(void) { > + long tls_option; <snip> Hiroshi

1 0

Re: [PATCH 3/3] winmm: Call IsFormatSupported for WAVE_FORMAT_QUERY only.
by Andrew Eikum 26 Oct '12

26 Oct '12

Ran tests on all four backends and everything seems okay. On Fri, Oct 26, 2012 at 10:31:33AM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > With the previous code in place, we can derive sane values for WAVE_FORMAT_QUERY. > > Given the amount of work and side-effects that the audio backends perform, better not > open them twice with IsFormatSupported then Initialize. Just use one or the other. > > Regards, > Jörg Höhle >

1 0

Re: ntdll: Do not execute callbacks past DeleteTimer(INVALID_HANDLE_VALUE)
by Marvin 26 Oct '12

26 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22495 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:946: Test failed: DeleteTimerQueueTimer

2 1