October 2012 - Wine-devel - list.winehq.org

Re: [PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 3)
by Dmitry Timoshkov 24 Oct '12

24 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt ) > { > + DWORD error = GetLastError(); > + > + if (!hwnd) > + { > + SetLastError( ERROR_INVALID_WINDOW_HANDLE ); > + return FALSE; > + } > + > + SetLastError( 0xdeadbeef ); > MapWindowPoints( hwnd, 0, lppnt, 1 ); > + > + if (GetLastError() != 0xdeadbeef) > + return FALSE; > + > + SetLastError(error); > return TRUE; > } As been said before these games with saving/restoring last error value are broken. -- Dmitry.

3 3

Re: [PATCH 1/2] user32: Remove redundant sizeof check.
by Ken Thomases 24 Oct '12

24 Oct '12

On Oct 24, 2012, at 3:24 AM, Michael Stefaniuc wrote: > @@ -1330,9 +1330,6 @@ static HICON CURSORICON_LoadFromFile( LPCWSTR filename, > } > > dir = (const CURSORICONFILEDIR*) bits; > - if ( filesize < sizeof(*dir) ) > - goto end; > - > if ( filesize < (sizeof(*dir) + sizeof(dir->idEntries[0])*(dir->idCount-1)) ) > goto end; > That doesn't seem redundant to me. It's not safe to access dir->idCount if the file isn't known to be big enough. Regards, Ken

2 1

Re: d3dx9_36/tests: Fix sizeof to be more portable (coverity)
by Henri Verbeet 23 Oct '12

23 Oct '12

On 24 October 2012 02:05, André Hentschel <nerv(a)dawncrow.de> wrote: > face_remap = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > - tc[i].num_faces*sizeof(face_remap)); > + tc[i].num_faces*sizeof(DWORD*)); > I'm don't know what Coverity actually says about this, but this looks just as wrong to me. It's probably supposed to be "sizeof(*face_remap)".

2 1

Re: [PATCH 3/3] ntdll: Add NULL test for NtQuerySystemInformation with SystemProcessInformation.
by Marvin 23 Oct '12

23 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22435 Your paranoid android. === W7PROX64 (32 bit info) === info.c:297: Test failed: Expected STATUS_ACCESS_VIOLATION got c0000017 === TEST64_W7SP1 (32 bit info) === info.c:297: Test failed: Expected STATUS_ACCESS_VIOLATION got c0000017

1 0

Re: [PATCH 3/3] mshtml: Added HTML comments in VBScript code tests
by Marvin 23 Oct '12

23 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22431 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] ntdll: Implement nanosecond precision file time storage (try 2).
by Alexandre Julliard 23 Oct '12

23 Oct '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -2048,17 +2048,26 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE handle, PIO_STATUS_BLOCK io, > > if (info->LastAccessTime.QuadPart || info->LastWriteTime.QuadPart) > { > +#ifdef HAVE_FUTIMENS > + struct timespec tv[2]; > +#else > struct timeval tv[2]; > +#endif > + int ret; > > if (!info->LastAccessTime.QuadPart || !info->LastWriteTime.QuadPart) > { > - > - tv[0].tv_sec = tv[0].tv_usec = 0; > - tv[1].tv_sec = tv[1].tv_usec = 0; > + memset(&tv, 0x0, sizeof(tv)); > if (!fstat( fd, &st )) > { > tv[0].tv_sec = st.st_atime; > tv[1].tv_sec = st.st_mtime; > +#if defined(HAVE_FUTIMENS) && defined(HAVE_STRUCT_STAT_ST_ATIM) > + tv[0].tv_nsec = st.st_atim.tv_nsec; > +#endif > +#if defined(HAVE_FUTIMENS) && defined(HAVE_STRUCT_STAT_ST_MTIM) > + tv[1].tv_nsec = st.st_mtim.tv_nsec; > +#endif You want UTIME_OMIT. Also please try to cut down on the number of #ifdefs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] d3dx9_36: Implement ID3DXFileDataImpl_GetType. (try 2)
by Rico Schüller 23 Oct '12

23 Oct '12

On 22.10.2012 23:57, Christian Costa wrote: > -static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID* guid) > +static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID *guid) > > - ID3DXFileDataImpl* object; > + ID3DXFileDataImpl *object; One minor thing: I'd put that fixes in patch 4/5. It doesn't make much sense to add a line and change the style in the next patch from the same series. I think it's better to correct this when it is added in the first place. Cheers Rico

1 0

Re: [PATCH 1/5] d3dx9_36: Implement D3DXFileCreate.
by Jacek Caban 23 Oct '12

23 Oct '12

On 10/22/12 10:13 PM, Rico Schüller wrote: > On 22.10.2012 21:27, Christian Costa wrote: >> +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface, REFIID riid, LPVOID *ret_iface) >> + ID3DXFileImpl *This = impl_from_ID3DXFile(iface); >> + ID3DXFileImpl* object; > Please be a bit more consistent across your patch... There are a lot more occurrences where you mix both usages. His usage seems natural when you think about using 'This' as analogy to 'this' in C++ implementation. That said, it's really a matter of taste, but such analogy feels natural when you work with COM. And by that logic, the patch is consistent. It uses 'object' as name of global function, which is not member of any class-like thing. Christian, there were some informal attempts to limit usage of stuff like LPVOID (and really any LP* types). It would be nice if you could avoid it in your patches. Jacek

4 3

Re: [PATCH 4/5] d3dx9_36: Implement ID3DXFileEnumObjectImpl_GetChildren & ID3DXFileEnumObjectImpl_GetChild and add stubbed interface for ID3DXFileData.
by Rico Schüller 22 Oct '12

22 Oct '12

On 22.10.2012 21:28, Christian Costa wrote: > +static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID* guid) Spacing. msdn says "const GUID *pType" see http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%…. Is it a bug in msdn? > + ID3DXFileDataImpl* object; *object? > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(ID3DXFileDataImpl)); I'd use sizeof(*object), but that's probably only a matter of taste.

3 3

Re: winex11: Never use a surface for embedded windows, even for the parents. (Regression)
by Christian Inci 22 Oct '12

22 Oct '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, this patch is causing CS:GO (Counter Strike: Global Offensive) to exit silently on startup. (Commit: 5fae649bdf14fb63b8d44984eda6edd1094a3314) - -Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQhbWdAAoJEC7OUg5VIFIFgw8QAI+9slyGg+G5T6mEEq1O5f3l 3AMOqCBVQ7F8mhBCqC8JhiMkjJRnJ8cRupXflPl5+iugXrhxHWxM49G/stJ9kqeQ m/uSwX+CSBUR/I2kBeYYljJtD28QEthjUP/X6VMTHsQKvInmyjZKXN5PXuLWwmq4 p1ZayBAixRNu0sLEDkH2vsRjRm0Ehla3YMFU6JkAH9mQcBl6x4V8Ii6E89onAC1i sV4x8ASHnnb8p4/I9m/mScmO1WAN/TnCQyh/QEXCgA/FFHvkSWNN7liDqRgRbNeM Ozx2Cj6UctzQpeHH7XeTzFQRHXY37cRcRvVVKU56yOC3N5hxK0ncXVWD2BflqBYZ C2cOwZpmzw3iG00csDjEWoLsZH0jw0foQNl5Nx/DWPyqqtY6hVT8++F80b1WroIM 47AcNeY9NakaDkBVnvmy0YeiVH0QIhZlT2L6h4LlogjIF6gl4m5kVBcGKCYAgF9C kqcGCg+CIlRqbDeEBto07GnDDDeuvG5NoCU3W2iB6xydBsEAfzj5xyOafbmueJuc JN7pBPgMfONmpg3RhkZgkiGFKlkA7URxTxHuQZsElBeKJiE2VkeZ4obXOf+YbPkc pTtQBIhkSXlStnxSJtKc6sY683YSoQinewGgHVV3qrbWhpPlz6ONQJjfifFhY3DO Vyakqk3iDicIg76kVuM6 =WTR3 -----END PGP SIGNATURE-----

1 0