October 2012 - Wine-devel - list.winehq.org

Re: [PATCH 4/4] mshtml: Added more events tests
by Marvin 22 Oct '12

22 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22386 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.
by Alexandre Julliard 22 Oct '12

22 Oct '12

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -599,7 +599,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetId(IDirectXFileData* iface, LPGUID > if (!pGuid) > return DXFILEERR_BADVALUE; > > - memcpy(pGuid, &This->pobj->class_id, 16); > + memcpy(pGuid, &This->pobj->class_id, sizeof(GUID)); Using normal assignments would be even better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] mshtml: Fixed attribute object caching logic
by Marvin 22 Oct '12

22 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22384 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: d3dx9_36: Add tests for D3DXSHRotateZ
by Rico Schüller 22 Oct '12

22 Oct '12

On 19.10.2012 13:15, Nozomi Kodama wrote: > This patch adds tests for the patch sent by Rico for D3DXSHRotateZ. > > Moreover, I changed const in CONST in the declaration of the function in > order to uniformize with the file. > + const FLOAT angle[] = ... I'd prefer "const" because it is used a little bit more often than CONST, but it is only a matter of taste. git grep "[ (,]const " | wc -l ~61k git grep "[ (,]CONST " | wc -l ~1.2k > + if ( i >= square || ( (order >= D3DXSH_MAXORDER) && ( i >= D3DXSH_MAXORDER * D3DXSH_MAXORDER ) ) ) > + if (l > 0) I'd write it "if (i >= square || ((... for consistency. > + ok(relative_error(expected, out_temp[i]) < admitted_error, "angle %f, order %u index %u, Expected %f, received %f\n", angle[j], order, i, expected, out_temp[i]); Expected -> expected? (2 times) > + expected = table[36 * (l + 3 * j ) + i]; The spacing looks a bit ugly. Cheers Rico

4 3

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE
by Chris Robinson 22 Oct '12

22 Oct '12

On 10/20/2012 05:40 PM, James Eder wrote: > + /* Intel says we need a zeroed 16-byte aligned buffer */ > + char buffer[512 + 16]; > + XMM_SAVE_AREA32 *state = (XMM_SAVE_AREA32 *)(((ULONG_PTR)buffer + 15) & ~15); > + memset(buffer, 0, sizeof(buffer)); > + > + __asm__ __volatile__( "fxsave %0" : "=m" (*state) : "m" (*state) ); Wouldn't this be simpler? DECLSPEC_ALIGN(16) XMM_SAVE_AREA32 state; memset(state, 0, sizeof(state)); __asm__ __volatile__("fxsave %0" : "=m" (*&state) : "m" (*&state)); May also want to make sure the two structs are packed.

4 7

re: [PATCH] services: Fix some weird sizeof usages.
by Dan Kegel 21 Oct '12

21 Oct '12

Christian Costa wrote: ... --- a/programs/services/rpc.c +++ b/programs/services/rpc.c ... @@ -952,7 +952,7 @@ BOOL service_send_command( struct service_entry *service, HANDLE pipe, } r = GetOverlappedResult( pipe, &overlapped, &count, FALSE ); } - if (!r || count != sizeof *result) + if (!r || count != sizeof(*result)) I was curious about this, so I looked around a bit. There are about 800 instances of sizeof without parens in Wine vs. 34628 with. I would have thought "Heck, this is just like return without parentheses, it emphasizes that it's not a function call, maybe it's a good idea." But it seems it's only legal to use it without parentheses for values; you need the parentheses when getting sizeof a type. cf. c89: http://web.archive.org/web/20040907153347/http://danpop.home.cern.ch/danpop… http://bytes.com/topic/c/answers/478596-using-sizeof-without-parentheses Does anybody feel strongly one way or the other?

2 1

Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.
by Rico Schüller 21 Oct '12

21 Oct '12

Why is there a "static guid" used in GetType? What happens if you query: hr = IDirectXFileData_GetType(lpDirectXFileData, &clsid_type); hr = IDirectXFileData_GetType(lpDirectXFileData2, &clsid_type2); Are thy both containing the value to clsid_type2 then? Do clsid_type and clsid_type2 match in that case to the same pointer both pointing to the same static guid? I don't see a test for this. Why doesn't *pguid = &This->pobj->type; do the job in that case? While trying to check the cases above, I got the following problem... Under which circumstances is the test_dump test run? It looks like the tests are never run because there is no objects.txt, see: hFile = CreateFileA("objects.txt", GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); if (hFile == INVALID_HANDLE_VALUE) return; CloseHandle(hFile); All machines (http://test.winehq.org/data/tests/d3dxof:d3dxof.html) seem to run 107 tests or skip all of them, which is the same on my machine (I got 107 tests), so none of them is running the whole test_dump ... How is this supposed to work? Cheers Rico On 21.10.2012 14:50, Christian Costa wrote: > @@ -647,7 +647,7 @@ static HRESULT WINAPI IDirectXFileDataImpl_GetType(IDirectXFileData* iface, cons > if (!pguid) > return DXFILEERR_BADVALUE; > > - memcpy(&guid, &This->pobj->type, 16); > + memcpy(&guid, &This->pobj->type, sizeof(GUID)); > *pguid = &guid; > > return DXFILE_OK;

2 1

Re: [PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 2)
by Rico Schüller 21 Oct '12

21 Oct '12

I think we also need a test to prove that "return MapWindowPoints( hwnd, 0, lppnt, 1 ) != 0;" is wrong. I'd probably split the changes to ScreenToClient/ClientToScreen and MapWindowPoints, because they are not necessarily bound together. What about something like: wnd2 = CreateWindow("static", "wnd2", WS_POPUP, 0, 0, 150, 150, NULL, NULL, NULL, NULL); ok(wnd2 != NULL, "CreateWindow failed\n"); SetLastError(0xdeadbeef); p.x = p.y = 0; ret = ScreenToClient(wnd2, &p); err = GetLastError(); ok(ret, "ScreenToClient() failed\n"); ok(p.x == 0 && p.y == 0, "Failed got(%d, %d), expected (%d, %d)\n", p.x, p.y, 0, 0); ok(err == 0xdeadbeef, "GetLastError failed, got %x, expected %x\n", err, 0xdeadbeef); Also msdn says: "Do not use ScreenToClient when in a mirroring situation, that is, when changing from left-to-right layout to right-to-left layout. Instead, use MapWindowPoints. For more information, see "Window Layout and Mirroring" in Window Features." We may also check that case. So they may not share the exact same steps. Cheers Rico On 20.10.2012 12:27, Christian Costa wrote: > Based ont a patch of Rico Schuller. > > Try 2: > - Test window handle in ClienToScreen and ScreenToClient instead of relying on GetLastError(). > - Don't rename params. > --- > dlls/user32/tests/win.c | 213 +++++++++++++++++++++++++++++++++++++++++++++++ > dlls/user32/winpos.c | 28 +++++- > 2 files changed, 237 insertions(+), 4 deletions(-)

2 3

Re: [PATCH 1/1] d3dx9/tests: Move device creation to main func.
by Henri Verbeet 21 Oct '12

21 Oct '12

2012/10/21 Rico Schüller <kgbricola(a)web.de>: > --- We've generally been moving in the opposite direction for the D3D tests, having each set of tests create its own device, window, etc. instead. This makes the tests much more self-contained, which in turn makes it much easier to debug if you have failures on some setup. I.e., you don't have to worry about some obscure render state that was set 15 tests ago, but affects every test in between, or some memory corruption due to a driver bug that only becomes visible when you're adding a new test. The ddraw/d3d8/d3d9 visual tests are particular bad in that regard. See also e.g. ddraw:ddraw7, etc., or to a lesser extent some of the more recent d3d8/d3d9:device tests.

2 1

Re: [PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback
by Eric Pouech 20 Oct '12

20 Oct '12

Le 20/10/2012 12:42, Patrick Rudolph a écrit : > This patch need lots of testing, since I can only test it on linux > using an Intel CPU. > Please tests on other OS and systems, too. please use the ntdll or kernel32 relevant API so that you don't have to copy the same code A+

3 4