February 2012 - Wine-devel - list.winehq.org

Re: [1/2] msxml3: Use static buffer when tracing libxml2 error messages
by Alexandre Julliard 16 Feb '12

16 Feb '12

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Use static buffer when tracing libxml2 error messages I don't think it's necessary to rename all the functions. Please keep patches small, especially during code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: How program are Loaded to wine
by Dan Kegel 16 Feb '12

16 Feb '12

Have you read the documentation, e.g. http://www.winehq.org/docs/winedev-guide/architecture ? Have you tried stepping through the source of CreateProcess by hand? http://source.winehq.org/source/dlls/kernel32/process.c#L2389 If you need more background, I hear "Windows Internals" is useful, http://www.amazon.com/windows-internals-5-rainbow-pony/dp/0735625301

1 0

Re: winmm: Allow new sounds to interrupt previous PlaySound invocations.
by Andrew Eikum 16 Feb '12

16 Feb '12

On Thu, Feb 16, 2012 at 10:10:09AM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > this fixes bug #28413. > Thanks Jörg, looks sane to me and I can confirm it fixes the problem. Andrew

1 0

Re: advapi32/tests: Marked some tests that fail on Wine as todo_wine.
by Johan Gill 16 Feb '12

16 Feb '12

Now I ran the tests on another Linux system with wine, and there the failing tests are skipped, so it seems I did not fully understand what's going on here and why the tests are run on my system.

1 0

Re: msxml3: Fix varargs handling in libxml2 error callback implementation
by Alexandre Julliard 16 Feb '12

16 Feb '12

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > The problem is that vsnprintf() was called multiple times with same > va_list. Ti fix that it was necessary to get rid of some tracing bits > like macro-defined callback calls and a single function for all kinds > of error types. Actually there's no need to call vsnprintf multiple times. The debug buffer has a limited size anyway, so we might as well use a limited stack buffer here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: Fix TB_SETEXTENDEDSTYLE to use mask passed in wParam
by Marvin 16 Feb '12

16 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16982 Your paranoid android. === WNT4WSSP6 (32 bit toolbar) === toolbar.c:1898: Test failed: 1: got style 0x00000008, expected 0x00000099 toolbar.c:1898: Test failed: 7: got style 0x00000008, expected 0x00000000 toolbar.c:1898: Test failed: 8: got style 0x00000010, expected 0x00000000 toolbar.c:1898: Test failed: 9: got style 0x00000008, expected 0x00000000

1 0

Re: po: Fix a couple of typography issues in the Finnish translation.
by Lauri Kenttä 16 Feb '12

16 Feb '12

"Avankuvan väli:" has this colon on purpose. It's the best way to make this translation meaningful in the context (Avainkuvan väli: [BOX] kuvaa). I've already discussed this with you in private. My opinion is that the original text should be in one piece or at least have a msgctxt to allow better translations. -- Lauri Kenttä

1 0

How program are Loaded to wine
by Shanuka Wijekoon 16 Feb '12

16 Feb '12

hello I am developing the project related to wine. so I have no idea how the programs are loaded and run by wine, what are the files initially loaded to the memory ,what are the files loaded to the memory on demand of the program.Is there any particular pattern of loading programs to memory file wise? I am new to wine so can I have good explanation about that? if there any related references and code segments it will helpful to me. Thank you

1 0

Re: advapi32: Correct tests under WOW64
by Alexandre Julliard 15 Feb '12

15 Feb '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -1455,9 +1455,11 @@ static void test_token_attr(void) > Size = 0; > ret = GetTokenInformation(Token, TokenGroups, Groups, Size2, &Size); > ok(Size > 1, "got %d\n", Size); > - ok(!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER, > - "%d with error %d\n", ret, GetLastError()); > - ok(*((BYTE*)Groups) == 0xcc, "buffer altered\n"); > + /* WoW64 return TRUE with the LastError set */ > + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "%d with error %d\n", ret, GetLastError()); > + if(!ret) > + ok(*((BYTE*)Groups) == 0xcc, "buffer altered\n"); Testing last error on success is in general not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdiplus: GdipTranslateLineTransform: make stub lie and return Ok
by Dan Kegel 15 Feb '12

15 Feb '12

On Sat, Feb 11, 2012 at 3:29 PM, Dan Kegel <dank(a)kegel.com> wrote: > This lets many .net apps run, see bug 23759. I see this patch is marked pending. Since tweaking the stub to lie and return success lets a bunch of .net apps run, it's tempting to say the benefits of the patch outweigh the risk... wine has done this kind of hack before, though maybe not during code freeze. Can someone who knows more about gdiplus comment? - Dan

2 2