February 2012 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] winmm: Avoid using SuspendThread, it can hang Wine.
by Alexandre Julliard 09 Feb '12

09 Feb '12

Joerg-Cyril.Hoehle(a)t-systems.com writes: > @@ -1006,7 +1008,9 @@ static BOOL MMSYSTEM_MidiStream_MessageHandler(WINE_MIDIStream* lpMidiStrm, LPWI > LPMIDIHDR lpMidiHdr; > LPMIDIHDR* lpmh; > LPBYTE lpData; > + BOOL paused = FALSE; > > +still_paused: > switch (msg->message) { > case WM_QUIT: > SetEvent(lpMidiStrm->hEvent); > @@ -1028,6 +1032,16 @@ static BOOL MMSYSTEM_MidiStream_MessageHandler(WINE_MIDIStream* lpMidiStrm, LPWI > } > lpMidiStrm->lpMidiHdr = 0; > SetEvent(lpMidiStrm->hEvent); > + return TRUE; > + case WINE_MSM_RESUME: > + /* FIXME: send out cc64 0 (turn off sustain pedal) on every channel */ > + lpMidiStrm->dwStartTicks = GetTickCount() - lpMidiStrm->dwPositionMS; > + SetEvent(lpMidiStrm->hEvent); > + return TRUE; > + case WINE_MSM_PAUSE: > + /* FIXME: send out cc64 0 (turn off sustain pedal) on every channel */ > + paused = TRUE; > + SetEvent(lpMidiStrm->hEvent); > break; > case WINE_MSM_HEADER: > /* sets initial tick count for first MIDIHDR */ > @@ -1114,6 +1128,10 @@ static BOOL MMSYSTEM_MidiStream_MessageHandler(WINE_MIDIStream* lpMidiStrm, LPWI > FIXME("Unknown message %d\n", msg->message); > break; > } > + if (paused) { > + GetMessageA(msg, 0, 0, 0); > + goto still_paused; > + } Please stop abusing goto, write a proper loop instead. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 2/2] urlmon: Added more mk: combining tests
by Marvin 09 Feb '12

09 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16890 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] mmdevapi/tests: Check GetService's output parameter.
by Marvin 09 Feb '12

09 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16888 Your paranoid android. === WVISTAADM (32 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 === W2K8SE (32 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 === W7PRO (32 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 === W7PROX64 (32 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 === TEST64_W7SP1 (32 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 === W7PROX64 (64 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 === TEST64_W7SP1 (64 bit render) === render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007 render.c:990: Test failed: ReleaseBuffer failed: 80070057 render.c:1013: Test failed: Position 0 vs. last 0 render.c:1076: Test failed: Reset failed: 8889000b render.c:1080: Test failed: Reset on a resetted stream returns 8889000b render.c:1089: Test failed: GetBuffer failed: 88890007 render.c:1094: Test failed: ReleaseBuffer failed: 80070057 render.c:1115: Test failed: Position 0 vs. last 0 render.c:1147: Test failed: Reset failed: 8889000b render.c:1154: Test failed: Reset on a resetted stream returns 8889000b render.c:1162: Test failed: GetBuffer failed: 88890007

1 0

Re: [PATCH 3/4] mmdevapi/tests: Perform renderer padding & position tests.
by Marvin 09 Feb '12

09 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16887 Your paranoid android. === WVISTAADM (32 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 === W2K8SE (32 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 === W7PRO (32 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 === W7PROX64 (32 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 === TEST64_W7SP1 (32 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 === W7PROX64 (64 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 === TEST64_W7SP1 (64 bit render) === render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007 render.c:980: Test failed: ReleaseBuffer failed: 80070057 render.c:1003: Test failed: Position 0 vs. last 0 render.c:1066: Test failed: Reset failed: 8889000b render.c:1070: Test failed: Reset on a resetted stream returns 8889000b render.c:1079: Test failed: GetBuffer failed: 88890007 render.c:1084: Test failed: ReleaseBuffer failed: 80070057 render.c:1105: Test failed: Position 0 vs. last 0 render.c:1137: Test failed: Reset failed: 8889000b render.c:1144: Test failed: Reset on a resetted stream returns 8889000b render.c:1152: Test failed: GetBuffer failed: 88890007

1 0

Re: winecfg: Center main window on the screen.
by Dmitry Timoshkov 09 Feb '12

09 Feb '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > For bug 21645. What is this pending for? -- Dmitry.

1 0

libgcrypt thread safety
by Adam Martinson 08 Feb '12

08 Feb '12

I've been looking into bug 27036 <http://bugs.winehq.org/show_bug.cgi?id=27036> , and it's due to the lack of thread safety by default in libgcrypt (in this case via libgnutls in secur32.dll). To be thread safe, libgcrypt requires a call to gcry_control(GCRYCTL_SET_THREAD_CBS) before any libgcrypt initialization is done. However, libgcrypt is used by a lot of different libs, one of which is being used by some other dll that's loading before secur32.dll. My question is, is it acceptable to do the gcry_control() call in ntdll's DllMain()? The alternative seems to be tracking down every lib used by wine that uses libgcrypt and doing it in each of those dlls. What's the best way to handle this?

3 2

Re: Profiing windows apps
by Ralph Little 08 Feb '12

08 Feb '12

Hi, > Also please attach a full +ddraw log to the bug report. If it is too big > compress it. bzip2 should do a pretty decent job, if all fails try lrzip. OK, done! > If the testing doesn't reveal anything, look out for IDirectDraw::GetCaps > calls in the logs or IDirect3Dx::EnumZBufferFormats. IDirectDraw::GetCaps > returns a DDCAPS structure which has dwZBufferBitDepths containing some flags > for z buffer bit depths. EnumZBufferFormats calls a callback multiple times > with available DDPIXELFORMAT structures. The application may not like some > flags we set there. The Sims calls EnumDevices and I presume calls EnumZBufferFormats within the callback for each device: trace:ddraw:d3d3_EnumDevices Enumerating WineD3D D3DDevice interface. trace:ddraw:d3d3_EnumZBufferFormats iface 0x13d04c, device_iid {a4665c60-2673-11cf-a31a-00aa00b93356}, callback 0x586a7d, context 0xabc198. trace:ddraw:d3d7_EnumZBufferFormats iface 0x13d048, device_iid {a4665c60-2673-11cf-a31a-00aa00b93356}, callback 0x586a7d, context 0xabc198. trace:ddraw:d3d7_EnumZBufferFormats Asked for SW device. trace:ddraw:PixelFormat_WineD3DtoDD Converting wined3d format 0x52 to DDRAW. trace:ddraw:PixelFormat_WineD3DtoDD Returning: ( DDPF_ZBUFFER , Z bits : 16) trace:ddraw:d3d7_EnumZBufferFormats Enumerating wined3d format 0x52. trace:ddraw:d3d7_EnumZBufferFormats Format enumeration cancelled by application. trace:ddraw:d3d3_EnumDevices Enumerating HAL Direct3D device. trace:ddraw:d3d3_EnumZBufferFormats iface 0x13d04c, device_iid {84e63de0-46aa-11cf-816f-0000c020156e}, callback 0x586a7d, context 0xabc198. trace:ddraw:d3d7_EnumZBufferFormats iface 0x13d048, device_iid {84e63de0-46aa-11cf-816f-0000c020156e}, callback 0x586a7d, context 0xabc198. trace:ddraw:d3d7_EnumZBufferFormats Asked for HAL device. trace:ddraw:PixelFormat_WineD3DtoDD Converting wined3d format 0x52 to DDRAW. trace:ddraw:PixelFormat_WineD3DtoDD Returning: ( DDPF_ZBUFFER , Z bits : 16) trace:ddraw:d3d7_EnumZBufferFormats Enumerating wined3d format 0x52. trace:ddraw:d3d7_EnumZBufferFormats Format enumeration cancelled by application. trace:ddraw:d3d3_EnumDevices End of enumeration. I don't know if this looks sensible, though. I see from the code that there are a lot of "gotchas" (both in d3d7_EnumZBufferFormats and d3d3_EnumDevices) for a number of games expecting things to happen in specific sequences and containing specific responses. I wonder if the Sims is going to turn out to be another. Cheers, Ralph

1 0

OpenGL child windows (SketchUp)
by Brian Bloniarz 08 Feb '12

08 Feb '12

Hi all, I could use a little help fixing a window lag and screen corruption issue in SketchUp: http://bugs.winehq.org/show_bug.cgi?id=25912 Long story short, I think the implementation of OpenGL child rendering needs a small update. As a reminder, this is how an OpenGL child window is setup: static BOOL set_win_format( HWND hwnd, XID fbconfig_id ) { gl_drawable = XCreateWindow(...); // offscreen window XCompositeRedirectWindow(..., gl_drawable, CompositeRedirectManual); } Here XComposite extension is render into an offscreen window. When it's time to display, the contents of that window are copied into the visible onscreen parent window (physDev is the onscreen window, gl_drawable is the offscreen window): BOOL X11DRV_SwapBuffers(PHYSDEV dev) { ... glXSwapBuffers(gdi_display, gl_drawable); ... /* The GL drawable may be lagged behind if we don't flush first, so * flush the display make sure we copy up-to-date data */ XFlush(gdi_display); XCopyArea(gdi_display, gl_drawable, physDev...); } The XFlush() is the problem; the buffer swap must happen before the copy, and accelerated renderers wouldn't guarantee to do that on an X queue flush. So how do you wait for a buffer swap? I wrote a test program, can you say "undefined behavior"? I tested on a few drivers: 1) ATI fglrx binary driver: glXSwapBuffers is instantaneous, existing code works fine. 2) NVidia binary driver: glXSwapBuffers is asynchronous, neither XFlush() nor XSync() is enough. Calling glXWaitGL or glFinish works. 3) Mesa DRI driver (Intel i915): glXSwapBuffers is asynchronous. None of XFlush/XSync/glXWaitX/glXWaitGL is enough. glFinish works. 4) r600g (Open Source accelerated ATI) driver: glXSwapBuffers is asynchronous. None of the flush calls wait for it (XFlush/XSync/glXWaitGL/glXWaitX/glFinish). The last one is the tricky part -- this driver is also based on the DRI, so I'm guessing it may appear on other open-source accelerated drivers (looking at http://www.x.org/releases/current/doc/dri2proto/dri2proto.txt suggests that this is new behavior as of 1.99.2) So how to come up with a common fix? I could think of 3 possibilities: 1) Use the GLX_OML_sync_control extension, it has an explicit call to wait for a buffer swap. Not supported by NV or fglrx, but we could fallback to glXWaitGL on those drivers. Probably simplest. 2) Use the X Damage extension, wait for an XDamageNotify event before copying. This should work everywhere, all drivers probably implement damage so that compositing window managers can use it. 3) Talk to the DRI people, maybe glXWaitGL should't return when there's a pending a buffer swap. The GLX spec seems to say it should wait, but it's a grey area and the Composite extension was designed much later. Not a quick fix. Any ideas or thoughts? If I hear nothing, I can code up a patch that does (1), but it'd be great to hear from some people who know this area well. Thanks, Brian Bloniarz

3 2

Re: gdi32: Consider whether the logical font face is vertical when selecting.
by Marvin 08 Feb '12

08 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16876 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: winecfg: Center main window on the screen.
by Vitaliy Margolen 08 Feb '12

08 Feb '12

Please don't! I want my window manager decide based on how I configured it where to position new windows. And not every program open in the middle of the screen just because it things it's the most important thing on my screen. Vitaliy.

4 3