February 2012 - Wine-devel - list.winehq.org

Skype support status
by Artem S. Tashkinov 05 Feb '12

05 Feb '12

Hello everyone, It's not a secret that Skype was bought by Microsoft a few months back and that there's a great chance that its native Linux version will get even fewer updates in the future because I doubt that Microsoft is even remotely endorse the existence of Linux and open source, thus Skype may easily become a "burden" they don't want to bear. Another quite important fact to consider is that the Linux version of Skype has fewer features than its Windows counterpart and that there are multiple issues regarding Skype, like the absence of a native 64bit version and a number of quite serious bugs (crashes, exclusive sound card access preventing other applications from working, 100% CPU usage after hibernation/sleep). Currently under Wine 1.4-rc2 I wasn't able to even run any version of Skype even in a simple chat mode. Very old versions of Skype cannot get online, more recent ones crash when trying to get online, or crash when you just start them, the last few releases (5.5-5.8) use MSHTML as their logon form and the way it behaves under Wine you cannot make use of it. I know that Codeweavers resources are very limited and that your priorities and the priority of other programmers hacking Wine are mostly concerned about getting proper support for core Windows applications like MS Office, Adobe products and other crucial programs, but I think it would be wise to make even basic Skype functionality work, because there are operating systems other than Windows, MacOS (iOS), and Linux (Android) and many people are left without one of the most popular messengers in the world. In short this message is a cry for getting Skype to work _at all_, because now it's totally unusable. With respect, Artem S. Tashkinov

1 0

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW (try 2)
by Dmitry Timoshkov 05 Feb '12

05 Feb '12

André Hentschel <nerv(a)dawncrow.de> wrote: > +@ stdcall LCMapStringEx(long long wstr long ptr long ptr ptr long) ... > +INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, LPWSTR dst, INT dstlen, > + LPNLSVERSIONINFO version, LPVOID reserved, LPARAM lparam) .spec file entry doesn't match the implementation. -- Dmitry.

1 0

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW
by Dmitry Timoshkov 05 Feb '12

05 Feb '12

André Hentschel <nerv(a)dawncrow.de> wrote: > +/* Locale name special values */ > +#define LOCALE_NAME_INVARIANT L"" > +#define LOCALE_NAME_MAX_LENGTH 85 > +#define LOCALE_NAME_SYSTEM_DEFAULT L"!sys-default-locale" > +#define LOCALE_NAME_USER_DEFAULT NULL Have a look how unicode constants are defined in other header files, the above version can't work in Wine. Also just duplicating LCMapString tests is not a very good idea, it would be better to find a way to share the test data. -- Dmitry.

2 2

Re: ntdll: Remove dead code
by Marcus Meissner 05 Feb '12

05 Feb '12

On Sun, Feb 05, 2012 at 03:59:44PM +0100, André Hentschel wrote: > --- > dlls/ntdll/signal_x86_64.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index 0fc53c7..e9cefb8 100644 > --- a/dlls/ntdll/signal_x86_64.c > +++ b/dlls/ntdll/signal_x86_64.c > @@ -2629,10 +2629,6 @@ static BOOL is_inside_epilog( BYTE *pc ) > > for (;;) > { > - BYTE rex = 0; > - > - if ((*pc & 0xf0) == 0x40) rex = *pc++ & 0x0f; /* rex prefix */ > - This is not OK I think. The pc++ side effect is removed ... and is not handled in the switch() below. Ciao, Marcus

1 0

Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed. (try 3)
by Dmitry Timoshkov 03 Feb '12

03 Feb '12

Adam Martinson <adam.r.martinson(a)gmail.com> wrote: > +static HDC (WINAPI *pGetWindowDC)(HWND hWnd); > +static int (WINAPI *pReleaseDC)(HWND hWnd,HDC hDC); There is no need to dynamically import these APIs, they are always available. > +static DWORD WINAPI test_ulw_thread(void *data) > +{ > + struct test_ulw_tdata *tdata = data; > + DWORD res; > + > + res = WaitForSingleObject( tdata->hSem, 1000 ); > + ok( !res, "wait for semaphore failed: %08x\n", res ); > + if (!res) > + { > + HDC hdc = pGetWindowDC( tdata->hwnd ); > + res = pUpdateLayeredWindow( tdata->hwnd, 0, NULL, tdata->psz, hdc, tdata->ppt, 0, NULL, ULW_OPAQUE ); > + ok( res, "UpdateLayeredWindow failed: %08x\n", GetLastError() ); > + pReleaseDC( tdata->hwnd, hdc ); > + } > + > + return res; > +} I don't see how this is supposed to test what you presumably are trying to fix. A bunch of message tests that calls UpdateLayeredWindow with various flags and parameters and compares window extents before and after the call would be more convincing IMO. -- Dmitry.

1 0

re: Wine automated testing update
by Dan Kegel 03 Feb '12

03 Feb '12

Jeremy wrote: > the VMWare folks are not willing to provide a permanent license for VMWare to us. > > So, we've shifted gears, and are exploring whether something like qemu + > kvm would be a sufficient alternate. What's the plan for automated MacOSX testing? I hear 10.7 supports running in a VM...

3 2

Re: [2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).
by Juan Lang 03 Feb '12

03 Feb '12

Hi Hans, hr = IXMLDOMNode_get_text( node, &s ); IXMLDOMNode_Release( node ); - if (!strcmpW( s, product_code )) r = ERROR_SUCCESS; - SysFreeString(s); + if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS; + SysFreeString( s ); Is it really safe to free s if IXMLDOMNode_get_text failed? --Juan

1 0

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data
by Dmitry Timoshkov 03 Feb '12

03 Feb '12

Aric Stewart <aric(a)codeweavers.com> wrote: > - REGFILTER2 *prf2; > + static REGFILTER2 *prf2; What's the point of this change? -- Dmitry.

3 2

Re: gdi32/tests: Add tests for default font selection.
by Marvin 02 Feb '12

02 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16799 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System === WXPPROSP3 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System === W2K3R2SESP2 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System

1 0

Profiing windows apps
by Ralph Little 02 Feb '12

02 Feb '12

Hi, I'm looking at bug #9672 again in the The Sims. The app crashes early on during initialisation in DirectDraw. The problem occurs after CreateSurface returns an error, since it would appear that the DDSURFACEDESC passed into the call is foobar. This would lead me to conclude that something on the lead up to that call is precipitating that rogue call. I have a legal Windows XP and I wish to trace the calls leading up to this point with real Windows/DirectX to compare with what is happening to Wine so that I can assess what is upsetting the application, since I can't see anything in the Wine trace prior to that that looks suspicious. Does anyone have any experience with tracing apps in real Windows in the context of Wine development? Should I use a profiler or is there a simpler method? Cheers, Ralph

3 5