April 2012 - Wine-devel - list.winehq.org

gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)
by Daniel Lehman 13 Apr '12

13 Apr '12

try 2 - integrate into existing tests; updated commit message I think the only points in the middle of the points array can cause the crash I was seeing. wide_pen_lines trims coincident points/empty segments from the beginning and end of the array, so the wine_line_segment calls before and after the for loop I modified will always return valid faces

1 0

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending. Resend.
by Vincent Povirk 13 Apr '12

13 Apr '12

I ran some of my drawing tests with GdipSetCompositingMode(graphics, CompositingModeSourceCopy), and it looks like native in that mode does roughly what your patch does, except that pixels that would be 100% transparent are not drawn. If a printer device behaves differently then that would be very strange. If it is the same, it probably makes sense to use (and maybe set at graphics creation time if it's appropriate for the HDC) the compositing mode flag. So I guess this is an acceptable approach, and could probably be committed as is and refined later, but it'd be nice if you could look into compositing modes and drawing with 100% transparent colors, since you have a test program set up for printing and I don't.

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17840 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRMFrameX_GetParent and update tests. (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17839 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17835 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRMFrameX_GetParent and update tests. (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17832 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Regression testing
by Daniel Jeliński 12 Apr '12

12 Apr '12

Hello all, I am trying to get Microsoft SQL Server Management Studio to work flawlessly under Wine. For the most part I create and triage related bug reports, but recently I also started tinkering with code, specifically with comctl library, which I am most familiar with. Back on subject. I thought I found a regression - on Wine 1.4 package downloaded from launchpad the "New query" button works fine, while on my compiled Wine it produces an error. So I did: git reset --hard wine-1.4 make and, surprisingly, I still had the problem with the compiled version. However after some combination of deleting leftover files, running make clean, make depend and make the button started working, so I started bisecting, hoping for the best. At some point I started getting bad versions, and every subsequent compile was bad - even after I ended bisecting and returned to wine-1.4, the button still did not work (and it still works under packaged Wine - I use the same install for all tests). This time make clean && make depend && make did not help. I am comparing what I did to [1], and the only difference I see is that I did not run configure before make. I'll try doing that later, but I think this shouldn't affect the outcome. Any other ideas? Also [1] suggests to set CC="ccache gcc -m32" on amd64 machines. I did that and when doing make I noticed that many lines start with: ccache gcc -m32 -m32 I guess that CC="ccache gcc" would be enough - but I didn't test that yet. Also I noticed that running parallel make (make -j) is never mentioned on [1]. Is there any reason I shouldn't use it? Daniel [1] http://wiki.winehq.org/RegressionTesting

6 6

Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild. (try 2) (resend)
by Alexandre Julliard 12 Apr '12

12 Apr '12

Christian Costa <titan.costa(a)gmail.com> writes: > + children = (IDirect3DRMFrame3**)HeapAlloc(GetProcessHeap(), 0, (This->nb_children + 1) * sizeof(IDirect3DRMFrame3*)); > + if (!children) > + return E_OUTOFMEMORY; > + > + CopyMemory(children, This->children, This->nb_children * sizeof(IDirect3DRMFrame3*)); > + HeapFree(GetProcessHeap(), 0, This->children); HeapReAlloc is your friend. Also you should grow the buffer quadratically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add a test for creating named mapping after closing without unmapping.
by Dmitry Timoshkov 12 Apr '12

12 Apr '12

Alexander Morozov <amorozov(a)etersoft.ru> wrote: > + ptr = MapViewOfFile(mapping, FILE_MAP_WRITE, 0, 0, 0); > + ok( ptr != NULL, "MapViewOfFile failed with error %d\n", GetLastError() ); > + CloseHandle(mapping); > + > + SetLastError(0xdeadbeef); > + mapping = CreateFileMappingA(INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, MAPPING_SIZE, name); > + ok( mapping != INVALID_HANDLE_VALUE, "CreateFileMappingA failed\n" ); It would be interesting to add OpenFileMapping before and after CloseHandle and test what it returns. -- Dmitry.

1 0

Re: [PATCH] d3drm: Implement IDirect3DRMFrameX_GetTransform.
by Marvin 12 Apr '12

12 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17814 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0