April 2012 - Wine-devel - list.winehq.org

Re: msvcrt: Add bsearch_s implementation by reusing code and tests from ntdll (try 3)
by Alexandre Julliard 09 Apr '12

09 Apr '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -124,6 +124,39 @@ void* CDECL _lsearch(const void* match, void* start, > } > > /********************************************************************* > + * bsearch_s (msvcrt.@) > + */ > +void* CDECL MSVCRT_bsearch_s(const void *key, const void *base, > + MSVCRT_size_t nmemb, MSVCRT_size_t size, > + int (__cdecl *compare)(void *, const void *, const void *), void *ctx) > +{ > + ssize_t min = 0; > + ssize_t max; > + > + if (!MSVCRT_CHECK_PMT(key != NULL) || !MSVCRT_CHECK_PMT(base != NULL) || > + !MSVCRT_CHECK_PMT(nmemb != 0) || !MSVCRT_CHECK_PMT(size != 0) || > + !MSVCRT_CHECK_PMT(compare != NULL) || !MSVCRT_CHECK_PMT(ctx != NULL)) > + { Some of these look suspicious, you need more tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Replace only the first match for non-regexp pattern in String.replace
by Marvin 09 Apr '12

09 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17730 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: ws2_32/tests: Add hostent struct tests for gethostbyname
by Marvin 08 Apr '12

08 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17727 Your paranoid android. === WXPPROSP3 (32 bit sock) === sock.c:509: Test failed: oob_server (1ac): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (1ac): unexpectedly at the OOB mark: 0

3 4

Re: [2/2] comctl32: Fix message sequence on right mouse click
by Marvin 07 Apr '12

07 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17723 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === treeview.c:1886: Test failed: right click (parent): the msg 0x004e was expected, but got msg 0x0133 instead treeview.c:1886: Test failed: right click (parent): the msg sequence is not complete: expected 0000 - actual 004e treeview.c:1887: Test failed: right click (tree): the msg 0x0215 was expected, but got msg 0x000f instead treeview.c:1887: Test failed: right click (tree): the msg sequence is not complete: expected 0000 - actual 0215 treeview.c:1894: Test failed: right drag (parent): the msg 0x004e was expected, but got msg 0x0133 instead treeview.c:1894: Test failed: right drag (parent): the msg sequence is not complete: expected 0000 - actual 004e treeview.c:1895: Test failed: right drag (tree): the msg 0x0215 was expected, but got msg 0x000f instead treeview.c:1895: Test failed: right drag (tree): the msg sequence is not complete: expected 0000 - actual 0215

1 0

Re: [1/2] comctl32/tests: Added tests for mouse events handling
by Marvin 07 Apr '12

07 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17721 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === treeview.c:1888: Test failed: right click (parent): the msg 0x004e was expected, but got msg 0x0133 instead treeview.c:1889: Test failed: right click (tree): the msg 0x0215 was expected, but got msg 0x000f instead treeview.c:1896: Test failed: right drag (parent): the msg 0x004e was expected, but got msg 0x0133 instead treeview.c:1896: Test failed: right drag (parent): the msg sequence is not complete: expected 0000 - actual 004e treeview.c:1897: Test failed: right drag (tree): the msg 0x0215 was expected, but got msg 0x000f instead treeview.c:1897: Test failed: right drag (tree): the msg sequence is not complete: expected 0000 - actual 0215

1 0

Re: [PATCH 2/3] wininet/tests: Added more tests for urlcache, including a new flag in CacheEntryType.
by Piotr Caban 07 Apr '12

07 Apr '12

Hi, On 04/05/12 08:50, Morten Rønne wrote: diff --git a/include/wininet.h b/include/wininet.h #define URLHISTORY_CACHE_ENTRY 0x00200000 +#define DELETED_CACHE_ENTRY 0x00400000 #define TRACK_OFFLINE_CACHE_ENTRY 0x00000010 DELETED_CACHE_ENTRY is not defined in native wininet.h header that I have. Did you find a header with it? If not, it should not be defined there. Cheers, Piotr

2 2

Re: winealsa: Fix an uninitialized variable compiler warning.
by Andrew Eikum 07 Apr '12

07 Apr '12

Thanks. GCC 4.7 must be smart enough to detect the same if-conditions, and doesn't issue a warning for me. Kind of impressive, actually. Andrew On Fri, Apr 06, 2012 at 02:49:38AM +0200, Józef Kucia wrote: > --- > dlls/winealsa.drv/mmdevdrv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index c99186b..1438f5b 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -343,7 +343,7 @@ static WCHAR *construct_device_id(EDataFlow flow, const WCHAR *chunk1, const cha > { > WCHAR *ret; > const WCHAR *prefix; > - DWORD len_wchars = 0, chunk1_len, copied = 0, prefix_len; > + DWORD len_wchars = 0, chunk1_len = 0, copied = 0, prefix_len; > > static const WCHAR dashW[] = {' ','-',' ',0}; > static const size_t dashW_len = (sizeof(dashW) / sizeof(*dashW)) - 1; > -- > 1.7.8.5 > > >

2 1

RFC: Getting CorelDraw 12 installation done - was: A donation for Corel Draw 12 - support.
by Gerold Jens Wucherpfennig 06 Apr '12

06 Apr '12

Hi can someone give me some hints about fixing wine for Corel 12 support? The installation seems to succeed at first glance, but comparing the installation folder to the folder of an installation on Windows XP reveals that only 2/3 of the installation was done. I updated the APPDB: http://appdb.winehq.org/objectManager.php?sClass=version&iId=2390 On 03/26/2012 09:52 AM, Frédéric Delanoy wrote: > On Sat, Mar 24, 2012 at 19:45, Gerold Jens Wucherpfennig > <gjwucherpfennig(a)gmx.net> wrote: >> http://appdb.winehq.org/objectManager.php?sClass=version&iId=2390 >> >> Installation worked, but Corel is not usable and only reports: >> >> "Registry Corrupt - The UI Language registration list is invalid" > > That page indicates the last tested version. > > Did you try Core Draw 12 with 1.4 or 1.5 and get the same errors? > > If you did, you might want to add test data in the AppDB entry, so > other people don't spend time duplicating your test. > If you didn't, maybe will retesting with 1.4 or 1.5 reveal it works > correctly for your needs? > > Frédéric I want to make a small donation to winehq, if we can get Corel 12 running on Wine... Here is the installation log: gerold(a)gerold-AOD270:/media/6B35-950F/Corel$ wine ./setup.exe wine: created the configuration directory '/home/gerold/.wine' fixme:storage:create_storagefile Storage share mode not implemented. err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot fixme:iphlpapi:NotifyAddrChange (Handle 0xede318, overlapped 0xede2e0): stub fixme:storage:create_storagefile Storage share mode not implemented. err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot fixme:iphlpapi:NotifyAddrChange (Handle 0xfee8ec, overlapped 0xfee8d0): stub wine: configuration in '/home/gerold/.wine' has been updated. fixme:storage:create_storagefile Storage share mode not implemented. fixme:storage:create_storagefile Storage share mode not implemented. fixme:vbscript:parse_script parser failed on parsing L"(\"SERIALNUMBER\") = \"DR12WTX-9999998-YSP\"\r\n\tSession.Property(\"TypeB\") = \"1\"\r\nEnd If\r\n\r\n'///////////////////////////////////////////////\r\nFunction IsFeatureExists(sFeature)\r\nOn Error Resume Next\r\n\r\n\tDim objDB: Set objDB = Session.Database\r\n\r\n\tDim sQuery: sQuery = \"SELECT"... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"(\"ShowLanguagePackDialog\") = \"1\"\r\nElse\r\n\tIf (IsFeatureExists(\"EN\") = \"1\") Then\r\n\t\tSession.Property(\"ENLANG\") = \"1\"\r\n\tEnd If\r\n\tIf (IsFeatureExists(\"DE\") = \"1\") Then\r\n\t\tSession.Property(\"DELANG\") = \"1\"\r\n\tEnd If\r\n\tIf (IsFeatureExists(\"FR\") = \"1\") Then\r\n"... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\nDim nRemoveVBAEN:nRemoveVBAEN = 0\r\nDim nRemoveVBACZ:nRemoveVBACZ = 0\r\nDim nRemoveVBANL:nRemoveVBAPL = 0\r\n\r\nOn "... fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\r\nIf (IsFeatureSelected(\"FontNav\") = True) Then\r\n If ((Session.Property(\"PLLANG\""... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\r\nIf (IsFeatureSelected(\"FontNav\") = True) Then\r\n If ((Session.Property(\"PLLANG\""... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\t\r\nIf (IsFeatureExists(\"LocalInstallsOnly\")=\"1\") Then\r\n\tIf ((Session.Property(\""... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self gerold(a)gerold-AOD270:/media/6B35-950F/Corel$ Thanks in advance! Gerold

1 0

Re: ddraw: Improve GetScanLine stub so it's usable for timing related tasks
by Christian Costa 06 Apr '12

06 Apr '12

Le 06/04/2012 12:35, Piotr Caban a écrit : > + /* Simulate a 60Hz display */ > + time = GetTickCount(); > + frame_progress = time& 15; /* time % (1000 / 60) */ > + if (!frame_progress) > + { > + *Scanline = 0; > + return DDERR_VERTICALBLANKINPROGRESS; > + } > + > + /* convert frame_progress to estimated scan line */ > + lines = mode.height / 15; > + *Scanline = (frame_progress - 1) * lines + time % lines; > return DD_OK; > } Is time % lines here is to generate a random values (sort of noise) ?

2 2

Re: [GSoC] Control panel proposal
by Magdalena Nowak 06 Apr '12

06 Apr '12

On 6 April 2012 11:06, André Hentschel <nerv(a)dawncrow.de> wrote: > Am 06.04.2012 01:35, schrieb Magdalena Nowak: >> Hey André, >> >> On 5 April 2012 22:46, André Hentschel <nerv(a)dawncrow.de> wrote: >>> >>>> The second solution would be to have a separate applet for >>>> per-application settings. The screens would be stored in a DLL, for >>>> example, as to avoid duplication. >>> >>> I dislike that, that seems just like a new view of winecfg. Further i doubt that you can store Wine specific things in a Wine specific DLL. >> >> I didn't like this idea either, but I have included it for the sake of >> completeness. > > That's good :) > >>> I think this project is doable, but might be hard to get the patches accepted i guess. >> >> What makes you say that? > > One or two people already tried IIRC and failed, but most likely they missed the part with the per-app configuration that you have seen. I think it's a great feature, but very hard to implement. That's why I've had a few ideas in mind. > Further you have to keep in mind that winecfg is a historical app, you'll need a nice and clean incremental way of patching it out. That's why I want to work incrementally, (c.f. the timeline on my proposal). > For further communication please CC wine-devel. Oops! BTW, the proposal can be found on http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/magdalen…

1 0