April 2012 - Wine-devel - list.winehq.org

Re: jscript: Emit undefined statement return for switch without default clausule
by Marvin 02 Apr '12

02 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17636 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wined3d: Added PCI device IDs for AMD Radeon 6750M & 6770M
by Henri Verbeet 02 Apr '12

02 Apr '12

On 31 March 2012 21:20, Gaurav Jain <gaurav(a)gauravjain.org> wrote: > CARD_AMD_RADEON_HD6600M = 0x6741, > + CARD_AMD_RADEON_HD6750M = 0x6741, If those are actually supposed to be the same, I don't think there's much of a point in this patch.

2 6

Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild.
by Jacek Caban 02 Apr '12

02 Apr '12

Hi Christian, On 04/02/12 08:54, Christian Costa wrote: > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > + LPDIRECT3DRMFRAME3 frame; > > - FIXME("(%p/%p)->(%p): stub\n", iface, This, child); > + TRACE("(%p/%p)->(%p)\n", iface, This, child); > > - return E_NOTIMPL; > + if (!child) > + return D3DRMERR_BADOBJECT; > + > + frame = &impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child)->IDirect3DRMFrame3_iface; This should be avoided. See unsafe_impl_from_* at http://wiki.winehq.org/COMGuideline for an example. Jacek

1 0

Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.
by Christian Costa 02 Apr '12

02 Apr '12

Le 02/04/2012 00:03, Michael Stefaniuc a écrit : > --- > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime (LPDIRECTMUSICPERFORMANCE8 iface, MUSIC_TIME mtTime, REFERENCE_TIME* prtTime) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime(IDirectMusicPerformance8 *iface, > + MUSIC_TIME mtTime, REFERENCE_TIME *prtTime) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, %d, %p): stub\n", This, mtTime, prtTime); > return S_OK; > } > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime (LPDIRECTMUSICPERFORMANCE8 iface, REFERENCE_TIME rtTime, MUSIC_TIME* pmtTime) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime(IDirectMusicPerformance8 *iface, > + REFERENCE_TIME rtTime, MUSIC_TIME *pmtTime) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, 0x%s, %p): stub\n", This, wine_dbgstr_longlong(rtTime), pmtTime); > return S_OK; > } > > -static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying (LPDIRECTMUSICPERFORMANCE8 iface, IDirectMusicSegment* pSegment, IDirectMusicSegmentState* pSegState) { > - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface; > +static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying(IDirectMusicPerformance8 *iface, > + IDirectMusicSegment *pSegment, IDirectMusicSegmentState *pSegState) > +{ > + IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface); > + > FIXME("(%p, %p, %p): stub\n", This, pSegment, pSegState); > return S_FALSE; > } > > Hi Michael, While you're at it, could you put a 4 spaces indentation to whole method. Christian

2 1

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface.
by Marvin 02 Apr '12

02 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17632 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:467: Test failed: Invalid refcount. Expected 3 got 2 d3drm.c:475: Test failed: Invalid refcount. Expected 4 got 3 d3drm.c:477: Test failed: Invalid refcount. Expected 3 got 2

1 0

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.
by Henri Verbeet 02 Apr '12

02 Apr '12

This looks wrong. Is there a legitimate way that this can happen?

2 3

Wine test bot and win16 exe
by Christian Costa 01 Apr '12

01 Apr '12

Hi, I wrote a win16 exe test file using open watcom but I cannot submit it to winebot. I fails saying "Unricognized file type". This is a little annoying. Is this a known limitation of wine test bot ? Thanks Christian

2 1

Re: d3dx9: Implement D3DXCreatePolygon
by Józef Kucia 01 Apr '12

01 Apr '12

On Sun, Apr 1, 2012 at 10:43 PM, David Adam <david.adam.cnrs(a)gmail.com> wrote: > + *mesh = polygon; > + > + if (adjacency) > + { > + hr = D3DXCreateBuffer(3 * sides * sizeof(DWORD), &adjacency_tmp); > + if (FAILED(hr)) return hr; You should release the polygon mesh. Also, you probably shouldn't touch *mesh when the function fails. -- Józef Kucia

1 0

Re: shell32: Added stubs for IMarshal interface (resend)
by Jacek Caban 01 Apr '12

01 Apr '12

Hi Gaurav, On 3/31/12 9:22 PM, Gaurav Jain wrote: > shell32: Added stubs for IMarshal interface (resend) > > Resending due to previous code freeze. > > ShellLink_QueryInterface() did not have a lookup for the IMarshal Interface. This resulted in an error message popping up in the Quest for Glory II (remake) installer. Providing IMarshal interface stubs avoids this error behaviour. > IMarshal is an interface that has serious impact on how the object is handled in RPC calls and the fact that you see better behavior in an app may be very well a side effect of Wine behaving badly, but in a different (more friendly for given application) way. The first question is does the object really implements custom IMarshal implementation on Windows? Cheers, Jacek

2 1

Re: [2/2] gdi32: Simplify font cache. (try 2)
by Alexandre Julliard 01 Apr '12

01 Apr '12

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -1516,23 +1464,8 @@ static void add_face_to_cache(Face *face) > RegSetValueExW(hkey_face, face_full_name_value, 0, REG_SZ, (BYTE*)face->FullName, > (strlenW(face->FullName) + 1) * sizeof(WCHAR)); > > - reg_save_dword(hkey_face, face_index_value, face->face_index); > - reg_save_dword(hkey_face, face_italic_value, (face->ntmFlags & NTM_ITALIC) != 0); > - reg_save_dword(hkey_face, face_bold_value, (face->ntmFlags & NTM_BOLD) != 0); > - reg_save_dword(hkey_face, face_version_value, face->font_version); > - reg_save_dword(hkey_face, face_external_value, face->external); > - > - RegSetValueExW(hkey_face, face_font_sig_value, 0, REG_BINARY, (BYTE*)&face->fs, sizeof(face->fs)); > + RegSetValueExW(hkey_face, face_value, 0, REG_BINARY, (BYTE*)face, sizeof *face); I don't think that's a good idea. There are many things in the structure that don't make sense to have in the registry. Also this won't work on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

2 2