April 2012 - Wine-devel - list.winehq.org

Re: gdi32: Constification.
by Alexandre Julliard 05 Apr '12

05 Apr '12

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -6407,7 +6409,7 @@ static BOOL get_text_metrics(GdiFont *font, LPTEXTMETRICW ptm) > return TRUE; > } > > -static BOOL face_has_symbol_charmap(FT_Face ft_face) > +static BOOL face_has_symbol_charmap(const FT_Face ft_face) > { > int i; > > @@ -6729,7 +6731,7 @@ end: > static DWORD freetype_GetGlyphOutline( PHYSDEV dev, UINT glyph, UINT format, > LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2 *lpmat ) > { > - struct freetype_physdev *physdev = get_freetype_dev( dev ); > + const struct freetype_physdev * const physdev = get_freetype_dev( dev ); > DWORD ret; > > if (!physdev->font) You are overdoing it. There's no reason to change per-value parameters or local variables like the physdev. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 3/3] wininet/tests: Added checks for bad return values and stop tests when it happens.
by Alexandre Julliard 05 Apr '12

05 Apr '12

Morten Rønne <morten.roenne(a)tdcadsl.dk> writes: > @@ -29,6 +29,8 @@ > > #include "wine/test.h" > > +#define bail_out { ok(0, "Bailing out\n"); return; } Please avoid that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: quartz: add control.idl as a typelib resource
by Jacek Caban 05 Apr '12

05 Apr '12

Hi Aric, On 04/04/12 20:38, Aric Stewart wrote: > --- a/dlls/quartz/Makefile.in > +++ b/dlls/quartz/Makefile.in > @@ -32,6 +32,7 @@ RC_SRCS = version.rc > IDL_H_SRCS = fil_data.idl > IDL_P_SRCS = quartz_strmif.idl > IDL_R_SRCS = quartz_strmif.idl > +IDL_TLB_SRCS = ../../include/control.idl This is not the right way. A simple IDL file in DLL directory that does nothing but #include will do the trick. See dlls/stdole2 for example. Jacek

1 0

About the "Implement Common Windows Scripting Classes"
by Lucas Zawacki 05 Apr '12

05 Apr '12

Hello, regarding the "Implement Common Windows Scripting Classes" gsoc idea. How many of these classes would be fine for the length of the program? I'm thinking that maybe 3 classes with thorough would be cool for a proposal. Some of them like "Dictionary" seem to be pretty straight forward and small, the others I'm not sure. Looking at dlls/scrrun/scrrun.idl I see there are a lot more of classes, but according to the idea page, Dictionary and FileSystemObject block multiple applications so they're higher priority. Are there other ones that are important?

1 0

Re: [PATCH 1/2] Revert "gdi32: Load fonts from default Mac external font paths."
by Ken Thomases 04 Apr '12

04 Apr '12

Forgot to note that this is a resend. On Apr 4, 2012, at 5:40 PM, Ken Thomases wrote: > > This reverts commit 85a71387dac1ca3ad47970800c8c01743681b528. > --- > dlls/gdi32/freetype.c | 17 +---------------- > 1 files changed, 1 insertions(+), 16 deletions(-) > > <0001-Revert-gdi32-Load-fonts-from-default-Mac-external-fo.patch>

1 0

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName.
by Henri Verbeet 04 Apr '12

04 Apr '12

You should use debugstr_a() for printing strings like that. Also, where does the 128 char limit come from?

2 1

Re: [PATCH 2/4] amstream: Add IAudioMediaStream stub implementation.
by Henri Verbeet 04 Apr '12

04 Apr '12

On 4 April 2012 21:57, Christian Costa <titan.costa(a)gmail.com> wrote: > +static HRESULT WINAPI IAudioMediaStreamImpl_QueryInterface(IAudioMediaStream *iface, > + REFIID riid, void **ppv) > +{ > + IAudioMediaStreamImpl *This = impl_from_IAudioMediaStream(iface); > + > + TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppv); > + > + if (IsEqualGUID(riid, &IID_IUnknown) || > + IsEqualGUID(riid, &IID_IMediaStream) || > + IsEqualGUID(riid, &IID_IAudioMediaStream)) > + { > + IUnknown_AddRef(iface); > + *ppv = This; That's wrong. > + return S_OK; > + } > + > + ERR("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > +} QueryInterface() should generally set "*ppv" to NULL on failure.

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (resend)
by Marvin 04 Apr '12

04 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17650 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:472: Test failed: Invalid refcount. Expected 3 got 2 d3drm.c:480: Test failed: Invalid refcount. Expected 4 got 3 d3drm.c:482: Test failed: Invalid refcount. Expected 3 got 2

2 2

Re: amstream: IAMMultiMediaStreamImpl_SetState: correct ifs
by Christian Costa 04 Apr '12

04 Apr '12

Le 04/04/2012 21:22, Joris Huizer a écrit : > Correcting a mistake in 27c4ad3bec1229020ab38ab5b45f0969204192ef > > Oupsssssss...... :(

1 0

Re: user32/tests: Add DlgDirList tests
by Alexandre Julliard 04 Apr '12

04 Apr '12

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 This should be added to the existing DlgDirList tests, making sure that these things are not already being tested. -- Alexandre Julliard julliard(a)winehq.org

1 0