May 2012 - Wine-devel - list.winehq.org

Re: [7/8] d3dx9/tests: Add tests for compressed pixel formats support in D3DXLoadSurface functions.
by Stefan Dösinger 10 May '12

10 May '12

Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef Kucia: > +#define check_pixel_3bpp(lockrect, x, y, color) \ > +ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] == > ... Inline functions are generally prefered over macros where possible. I think it is possible to pass a different line number to ok() to make the messages more useful when they are called from a helper function, but I don't know how off the top of my head. If you have to use a macro, please use capital letters.

2 1

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Nikolay Sivov 10 May '12

10 May '12

On 5/10/2012 00:52, Alex Henrie wrote: > This patch was a lot harder to figure out than I thought it was going to be. > > The MSDN documentation of most of these behaviors can be found at > http://msdn.microsoft.com/en-us/library/windows/desktop/dd319072(v=vs.85).a… Does any application depend on that? > > --- > dlls/kernel32/locale.c | 38 ++++++++++++++--- > dlls/kernel32/tests/locale.c | 94 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 126 insertions(+), 6 deletions(-) This is a wrong file to place tests into. > > diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c > index 3216ef9..9cbb124 100644 > --- a/dlls/kernel32/tests/locale.c > +++ b/dlls/kernel32/tests/locale.c > @@ -3137,6 +3137,99 @@ static void test_IdnToUnicode(void) > } > } > > +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR src, > + INT srclen, LPSTR dst, INT dstlen, > + LPCSTR defchar, BOOL* used, > + const char* test_description, > + DWORD expected_error) > +{ > + SetLastError(ERROR_SUCCESS); > + WideCharToMultiByte(page, flags, src, srclen, dst, dstlen, defchar, used); > + ok(GetLastError() == expected_error, > + "codepage %i, %s, expected error %i got error %i\n", page, > + test_description, expected_error, GetLastError()); > +} > + > +static void test_MultiByteToWideChar_error(UINT page, DWORD flags, LPCSTR src, > + INT srclen, LPWSTR dst, INT dstlen, > + const char* test_description, > + DWORD expected_error) > +{ > + SetLastError(ERROR_SUCCESS); > + MultiByteToWideChar(page, flags, src, srclen, dst, dstlen); > + ok(GetLastError() == expected_error, > + "codepage %i, %s, expected error %i got error %i\n", page, > + test_description, expected_error, GetLastError()); > +} > + Looks ugly enough, it's better to place some test data in table and loop through it, if you really want to test that.

2 3

Re: [PATCH 2/3] dmsynth: Add some clock tests.
by Marvin 10 May '12

10 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18298 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

kernel32: Add UTF-7 support
by Alex Henrie 09 May '12

09 May '12

Hi all, Could I get some feedback on http://source.winehq.org/patches/data/85898 ? It was marked "Rejected" a week ago without explanation. Most of the code was authored by Katayama Hirofumi, whose patches have been accepted into Wine before. He gave permission to use his code under the LGPL at http://bugs.winehq.org/show_bug.cgi?id=27388 What more needs to be done before this patch can be accepted? -Alex

3 4

Re: d3drm/tests: Port IDirect3DRMFrame tests to IDirect3DRMFrame3
by Alexandre Julliard 09 May '12

09 May '12

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/d3drm/tests/d3drm.c | 323 +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 320 insertions(+), 3 deletions(-) It doesn't seem necessary to duplicate the whole thing, try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName. (try 5) (resend)
by Alexandre Julliard 09 May '12

09 May '12

Christian Costa <titan.costa(a)gmail.com> writes: > Try 5: Use a growing buffer to store name. I don't think a growing buffer makes sense for this. > + if (name) > + { > + *size = min(*size, This->name_size); > + memcpy(name, This->name, *size); > + /* Make sure we have the terminating 0 in case of truncation */ > + name[*size] = 0; Buffer overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Ubuntu 12.04 (version#2, drop previous mail)
by Eric Pouech 09 May '12

09 May '12

> This is because you _cannot_ install the 32-bit -dev packages onto > 12.04. It's not just symlinks that are missing, many of the header > files are different between the arches. I'm not sure this is a generic rule, and if it were, then exclusion between i386 and x86_64 should be defined on most dev packages, and it's not the case also note, that in some cases, arch specific headers are moved to arch dependent directories (e.g. jpeg, glib...), which should also parallel install of multi-arch libs in any case, the job by ubuntu folks in 12.04 done is crappy, to say the least > Just do the chroot. You will save yourself so much grief and it will > actually work. if the ubuntu folks keep this state of mind, then they'll continue to sink the best solution is then to pick up another distro A+ -- -- Eric Pouech

3 4

Re: [2/5] gdi32: Set tmDigitizedAspectX/Y to 96 instead of 300 for consistency.
by Dmitry Timoshkov 08 May '12

08 May '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -6677,8 +6677,8 @@ static BOOL get_outline_text_metrics(GdiFont *font) > TM.tmWeight = pOS2->usWeightClass; > } > TM.tmOverhang = 0; > - TM.tmDigitizedAspectX = 300; > - TM.tmDigitizedAspectY = 300; > + TM.tmDigitizedAspectX = 96; /* FIXME */ > + TM.tmDigitizedAspectY = 96; /* FIXME */ A couple of comments to the patch: 1. the values should be set to the resolution of the target device, and 96 looks more natural since most of the time the device is a display. 2. the change is for consystency with get_bitmap_text_metrics() which sets these values to 96. 3. even if this pacth is rejected, other patches in the sequence should not be affected by it. -- Dmitry.

1 0

running 16bit code
by David Laight 08 May '12

08 May '12

Does wine support running of 16bit windows apps? If so does it rely on the underlying OS having support for 'virtual 8086 emulation'? I'm thinking of removing the VM86 support from NetBSD, and wine is about the only likley user. David -- David Laight: david(a)l8s.co.uk

5 5

Re: [PATCH 4/4] dmsynth: Add stubbed IKsControl interface to DirectMusicSynthSink object.
by Alexandre Julliard 08 May '12

08 May '12

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/dmsynth/dmsynth_private.h | 1 + > dlls/dmsynth/synthsink.c | 67 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 68 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M dmsynth.dll -T ../../.. -p dmsynth_test.exe.so dmsynth.c && touch dmsynth.ok dmsynth.c:56: Test succeeded inside todo block: IDirectMusicSynthSink_QueryInterface returned: 0 make: *** [dmsynth.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0