May 2012 - Wine-devel - list.winehq.org

Re: kernel32: add more tracing to GetDiskFreeSpaceW
by Dmitry Timoshkov 05 May '12

05 May '12

Austin English <austinenglish(a)gmail.com> wrote: > @@ -1687,6 +1689,8 @@ BOOL WINAPI GetDiskFreeSpaceW( LPCWSTR root, LPDWORD cluster_sectors, > if (sector_bytes) *sector_bytes = info.BytesPerSector; > if (free_clusters) *free_clusters = info.AvailableAllocationUnits.u.LowPart; > if (total_clusters) *total_clusters = info.TotalAllocationUnits.u.LowPart; > + TRACE("%u, %u, %u, %u, capped=%d\n", cluster_sectors ? *cluster_sectors : 0, sector_bytes ? *sector_bytes : 0, > + free_clusters ? *free_clusters : 0, total_clusters ? *total_clusters : 0, capped); Why not print in the values directly from info structure? That way all the data are in the trace regardless of what info appication requested. I'd guess that printing valus in hex would be more readable, and once the data is printed in hex it should be obvious when the values were capped, making 'capped' flag redundant. -- Dmitry.

1 0

Re: [2/5] msvcm80: Add stub dll.
by Charles Davis 04 May '12

04 May '12

On May 4, 2012, at 10:07 AM, Vincent Povirk wrote: > > <0002-msvcm80-Add-stub-dll.txt> msvcmrt? The Managed C++ Runtime DLL? I imagine you won't get far on that without a C++/CLI compiler that understands the Microsoft Visual C++ ABI--unless you're willing to write all the marshaling glue code by hand. There's only one such compiler right now, and it only runs on Windows. VC++ ABI support is on my Clang to-do list--heck, it's my GSoC project--but C++/CLI is something I won't get to for a while. Given all that, how do you intend to implement this? Chip

2 2

Re: [2/5] msvcm80: Add stub dll.
by Stefan Dösinger 04 May '12

04 May '12

3 2

Re: [5/5] msvcm80: Add __setusermatherr_m stub.
by Charles Davis 04 May '12

04 May '12

On May 4, 2012, at 10:10 AM, Vincent Povirk wrote: > diff --git a/dlls/msvcm80/msvcm80_main.c b/dlls/msvcm80/msvcm80_main.c > index cd38f5b..eb09898 100644 > --- a/dlls/msvcm80/msvcm80_main.c > +++ b/dlls/msvcm80/msvcm80_main.c > @@ -50,3 +50,10 @@ void __cdecl CrtImplementationDetails_RegisterModuleUninitializer(void* handler) > FIXME("%p: stub\n", handler); > } > > +/* handler is a "method" with signature int32 (*handler)(_exception*), but I'm > + * not sure what that means */ I am. Actually, it's: int (__clrcall *handler)(struct _exception *) i.e. a "pointer to a function intended to be called from managed code that takes a pointer to a struct _exception and returns an int." The definition of struct _exception is in <math.h> under Visual Studio. To write such a function, you'd need a C++/CLI compiler. Chip

1 0

Wine Gecko 1.6-beta1
by Jacek Caban 04 May '12

04 May '12

Hi all, I've uploaded a beta version of another Gecko update. Other than usual Gecko changes coming from Mozilla (for upcoming Firefox 13), it contains fixes for Wine bugs 30465 and 25243. To try it, as usually, the attached patch is required as well as the build that may be found on SourceForge [1], installed in usual way [2] (or your own build, it's easy those days! See wine-gecko-1.6 branch on [3]). All help with testing is appreciated! Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.6-beta1/ [2] http://wiki.winehq.org/Gecko [3] http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/wine-gecko;a=summary

1 0

Re: [PATCH 1/2] jscript: Skip failing tests on old jscript versions
by Marvin 04 May '12

04 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18229 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: po: English (neutral / Great Britain) spelling fixes.
by Nicolas Le Cam 03 May '12

03 May '12

Le 3 mai 2012 02:45, "Francois Gouget" <fgouget(a)free.fr> a écrit : > @@ -9429,9 +9429,9 @@ msgstr "" > "start [options] document_filename\n" > "\n" > "Options:\n" > -"/M[inimized] Start the program minimized.\n" > -"/MAX[imized] Start the program maximized.\n" > -"/R[estored] Start the program normally (neither minimized nor maximized).\n" > +"/M[inimized] Start the program minimised.\n" > +"/MAX[imized] Start the program maximised.\n" > +"/R[estored] Start the program normally (neither minimised nor maximised).\n" > "/W[ait] Wait for started program to finish, then exit with its exit " > "code.\n" > "/Unix Use a Unix filename and start the file like windows explorer.\n" Hi Francois, Shouldn't the end of words between brackets be translated too ? -- Nicolas Le Cam

3 3

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.
by Henri Verbeet 03 May '12

03 May '12

On 2 May 2012 23:32, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + if(wic_pixel_formats[i].d3dformat == format) Missing whitespace. > +HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, "LPCWSTR" -> "const WCHAR *" > + TRACE("(%s, %d, %p, %p, %p)\n", > + wine_dbgstr_w(dst_filename), file_format, src_surface, src_palette, src_rect); wine_dbgstr_rect(). > + memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); > + hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); > + d3d_pixel_format = wic_guid_to_d3dformat(&wic_pixel_format); What is all this for? Also, how do you intend to implement D3DXSaveSurfaceToFileInMemory()?

2 2

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.
by Henri Verbeet 03 May '12

03 May '12

On 2 May 2012 23:32, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, > + IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, const RECT *src_rect) If you're changing these anyway, LPCSTR is a broken way of saying "const char *". > + TRACE("(%s, %d, %p, %p, %p): relay\n", > + wine_dbgstr_a(dst_filename), file_format, src_surface, src_palette, src_rect); I generally prefer %#x for things like file_format, but don't care particularly strongly. For src_rect you should use %s and wine_dbgstr_rect(). I don't care much for the "relay" suffix, but I suppose half the existing code has it as well. > + len = MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, NULL, 0); > + filename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); The HEAP_ZERO_MEMORY flag is useless, you're immediately going to overwrite all the memory afterwards. Sadly the existing d3dx9 code isn't a very good example here either.

1 0

Request for help/advice in investigation of one interesting "huge FPS regression" bug
by Alexey Loukianov 03 May '12

03 May '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all. Henri, Stefan, I address this message to you at the first place as to a main developers of wined3d/opengl stuff. Nevertheless, hints and help are welcome from anyone, cause ATM I'm totally confused and don't know what else to try to investigate a case. What I've got here is an app (localized version of "Perfect World" MMORPG game client from "Mail.Ru Games Corp") that seems to suffer huge FPS regression which I believe to be a bug in nVIDIA drivers rather than a regression in Wine. Details are following. When I configure an app to run in a windowed mode I've got around 40 FPS on game login screen with nVIDIA drivers 275.09.07, but switching into using more recent versions causes FPS to drop to around ~10. Configuring the game to use fullscreen more fixes the issue - I've got ~30-40 FPS at game login screen no matter the driver version I use. I've been suspecting that this issue might be related to vsync control (and a recent change in nVIDIA linux drivers for vsync to be on by default) that causes the issue, so I had exported __GL_SYNC_TO_VBLANK="0" into the environment and used nvidia-settings to set vsync to be off by default. Using a small native opengl demo program I had specifically written to test for vsync state I can prove that vsync defaults to be off on my system. Also I had modified Wine's winex11.drv opengl.c in a way that a call to wglSwapIntervalEXT always sets swap_interval to be zero, no matter what was originally requested. Nevertheless, I still got this strange FPS drop when I run the game in a windowed more with a recent nVIDIA drivers. What could be a cause for it? What I want is to track down the problem to it's roots and check if it's really a bug in nVIDIA drivers. In the end I would like to implement a small opengl demo that would trigger the bug so nVIDIA wouldn't be able to reject my bug report on a matter that "it's a Wine bug, prove us that it's not". - -- Best regards, Alexey Loukianov mailto:mooroon2(a)mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPij76AAoJEPB9BOdTkBULjz4H/1B/Nw6qOQUlEmDb64SmabvQ LQmzIHcnH38Ftz3KyWQxlYZ5EtLDYAIOQeP4pAHfzxKhGUJ1mCumv4ByaSs4YDhI juWJ/u/88vKwZYXJ9nZLQVqJY+dkr9MbxP3q0eGNaAFLNRDIqodzJJWB5EPucMrX Yid/zMjl5uGd9QDCO3Db4gwJKYpvHCbAfzADddqBwPoak9jXdlq53H9a2mImTbCB JR1MXQq6gFakOgtxXPxzFSU2Ge0n8RBGGN7UeZEubsLiktnmvTbKAJmmgWgPG80Y mlud7LrM4wLRPtpwTwS+M1n8TuVtUZzzCTagRyj3XSRL8Pqf2d5S3H+MpxBT1JQ= =TkMD -----END PGP SIGNATURE-----

5 8