June 2012 - Wine-devel - list.winehq.org

Re: ntdll : add ThreadQuerySetWin32StartAddress in NtQueryInformationThread
by Alexandre Julliard 19 Jun '12

19 Jun '12

Roman Dadkov <romand(a)etersoft.ru> writes: > @@ -63,7 +63,7 @@ struct reply_header > /* this is used to construct the generic_request union */ > struct request_max_size > { > - int pad[16]; /* the max request size is 16 ints */ > + int pad[18]; /* the max request size is 18 ints */ > }; You can't change that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 4)
by Alexandre Julliard 19 Jun '12

19 Jun '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -66,8 +179,6 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > switch (fdwReason) > { > - case DLL_WINE_PREATTACH: > - return FALSE; /* prefer native version */ Changing this may or may not be a good idea at this point, but it definitely shouldn't be silently sneaked in as part of a different patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Akihiro Sagawa 19 Jun '12

19 Jun '12

On Tue, 19 Jun 2012 03:39:18 -0300, Bruno Jesus wrote: > Hi, judging by the subjects I'd say the patches were commited already, > you're trying to send them again or are they different patches? > > http://source.winehq.org/git/wine.git/commitdiff/afdc84cf0366c8e161004bf1e7… > http://source.winehq.org/git/wine.git/commitdiff/2bb416baa88c28f57bb0f65aa9… > http://source.winehq.org/git/wine.git/commitdiff/f503afd86ff9df9467eb1351cf… Hi Bruno, Please ignore these patches. They were sent over 48 hours ago. It seems there is a huge delay between Gmail and wine-patches. Actually, one of my original patches are missed `static' keyword as Dmitry spotted(*). Therefore, I added the keyword and sent series of patches again. But, during transfer (>48 hours), the original patch was updated by Alexandre, then committed. After a while, my modified version was delivered and tested although they have already been applied. * ... http://www.winehq.org/pipermail/wine-devel/2012-June/095956.html Akihiro Sagawa

2 2

Re: [website] Portuguese translation for release 1.4.1
by Lucas Zawacki 19 Jun '12

19 Jun '12

Disregard this patch. I added the wrong file to the commit and will resend. On Tue, Jun 19, 2012 at 12:01 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > This is just english. Did you mean for that to happen? > > No need to send the english, as if the xml does not exist, the site will > always fall back to the english version already. > > -N > > > On 06/19/2012 09:49 AM, Lucas Zawacki wrote: >> >> From: Lucas Zawacki<lfzawacki(a)gmail.com> >> >> --- >> news/pt/2012061501.xml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> create mode 100644 news/pt/2012061501.xml >> >> diff --git a/news/pt/2012061501.xml b/news/pt/2012061501.xml >> new file mode 100644 >> index 0000000..7c0ff9f >> --- /dev/null >> +++ b/news/pt/2012061501.xml >> @@ -0,0 +1,13 @@ >> +<news> >> +<date>June 15, 2012</date> >> +<title>Wine 1.4.1 Released</title> >> +<body> >> + The Wine maintenance release 1.4.1 is now available. >> + <a href="{$root}/announce/1.4.1">What's new</a> in this release: >> +<ul> >> +<li>Translation updates.</li> >> +<li>Various bug fixes.</li> >> +</ul> >> +The source is<a >> href="http://prdownloads.sourceforge.net/wine/wine-1.4.1.tar.bz2">available >> now</a>. >> +Binary packages are in the process of being built, and will appear soon >> at their respective<a href="{$root}/download">download locations</a>. >> +</body></news>

1 0

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.
by Vincent Povirk 19 Jun '12

19 Jun '12

> + hr = IStream_Clone(image->stream, &stream); > + if (FAILED(hr)) That's odd. When does that happen? > + if (stat == Ok) > + { > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > + free_image_data(image); > + if (image->type == ImageTypeBitmap) > + *(GpBitmap *)image = *(GpBitmap *)new_image; > + else if (image->type == ImageTypeMetafile) > + *(GpMetafile *)image = *(GpMetafile *)new_image; > + return Ok; > + } Why did you re-implement move_bitmap() ?

2 5

Re: d3dx9_36 [patch 1of 2]: Implementation of D3DXSHDot
by Matteo Bruni 19 Jun '12

19 Jun '12

2012/6/19 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: +static void test_D3DXSHDot(void) +{ + unsigned int i; + FLOAT a[90], b[90], got; + CONST FLOAT expected[] = + { 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, 175500.0f, }; + + for (i = 0; i < 90; i++) + { + a[i] = (FLOAT)i; + b[i] = (FLOAT)i + 0.5f; + } + +/* D3DXSHDot computes by using order * order elements */ + for (i = 0; i < 9; i++) + { + got = D3DXSHDot(i, a, b); + ok(relative_error(got, expected[i]) < admitted_error, "order %d: expected %f, received %f\n", i, expected[i], got); + } + + return; +} + Making the "a" and "b" arrays 90 elements big doesn't make much sense. If your D3DXSHDot implementation is correct, for the i = 8 case you only need 8 * 8 = 64 elements. Also notice that the "expected" array has 10 elements, while you use only 9. Also please recheck formatting and whitespaces of this patch and patch 2/2.

1 0

Re: [appdb] Upgrade to xinha svn head to fix issues with xinha editors not appearing in Firefox 15
by Ricardo Filipe 19 Jun '12

19 Jun '12

2012/6/18 André Hentschel <nerv(a)dawncrow.de>: > http://bugs.winehq.org/show_bug.cgi?id=30820 > --- > xinha/Xinha.css | 229 +- > xinha/XinhaCore.js |12107 ++++++++++++++------ > xinha/contrib/php-xinha.php | 29 +- > xinha/examples/Extended.html | 299 - > xinha/examples/Newbie.html | 12 +- > xinha/examples/XinhaConfig.js | 149 +- > xinha/examples/custom.css | 40 - > xinha/examples/dynamic.css | 56 - > xinha/examples/ext_example-body.html | 202 - > xinha/examples/ext_example-dest.php | 23 - > xinha/examples/ext_example-menu.php | 331 - > xinha/examples/ext_example.html | 16 - > xinha/examples/full_example.css | 48 - > xinha/examples/full_example.js | 97 - > xinha/examples/simple_example.html | 190 +- > xinha/examples/stylist.css | 31 - > xinha/examples/testbed.html | 45 +- > xinha/htmlarea.js | 44 +- > xinha/lang/b5.js | 58 +- > xinha/lang/ch.js | 112 +- > xinha/lang/cz.js | 100 +- > xinha/lang/da.js | 202 +- > xinha/lang/de.js | 338 +- > xinha/lang/ee.js | 100 +- > xinha/lang/el.js | 110 +- > xinha/lang/es.js | 207 +- > xinha/lang/eu.js | 2 +- > xinha/lang/fa.js | 6 +- > xinha/lang/fi.js | 76 +- > xinha/lang/fr.js | 338 +- > xinha/lang/gb.js | 58 +- > xinha/lang/he.js | 128 +- > xinha/lang/hu.js | 128 +- > xinha/lang/it.js | 110 +- > xinha/lang/ja.js | 6 +- > xinha/lang/lt.js | 106 +- > xinha/lang/lv.js | 84 +- > xinha/lang/nb.js | 156 +- > xinha/lang/nl.js | 128 +- > xinha/lang/pl.js | 2 +- > xinha/lang/pt_br.js | 180 +- > xinha/lang/ro.js | 126 +- > xinha/lang/ru.js | 370 +- > xinha/lang/sh.js | 2 +- > xinha/lang/si.js | 100 +- > xinha/lang/sr.js | 2 +- > xinha/lang/vn.js | 112 +- > xinha/modules/ColorPicker/ColorPicker.js | 1494 ++- > xinha/modules/CreateLink/link.js | 190 +- > xinha/modules/Dialogs/dialog.js | 159 +- > xinha/modules/Dialogs/inline-dialog.js | 204 - > xinha/modules/Dialogs/panel-dialog.js | 1 + > xinha/modules/Dialogs/popupwin.js | 291 +- > xinha/modules/FullScreen/full-screen.js | 373 +- > xinha/modules/Gecko/Gecko.js | 1225 ++- > xinha/modules/Gecko/paraHandlerBest.js | 1196 ++- > xinha/modules/Gecko/paraHandlerDirty.js | 116 - > xinha/modules/GetHtml/DOMwalk.js | 519 +- > xinha/modules/GetHtml/TransformInnerHTML.js | 368 +- > xinha/modules/InsertImage/insert_image.html | 345 +- > xinha/modules/InsertImage/insert_image.js | 214 +- > xinha/modules/InsertTable/insert_table.html | 314 +- > xinha/modules/InsertTable/insert_table.js | 153 +- > xinha/modules/InternetExplorer/InternetExplorer.js | 1150 ++- > xinha/plugins/CSS/css.js | 74 - > xinha/plugins/CharCounter/char-counter.js | 106 - > xinha/plugins/CharacterMap/CharacterMap.css | 6 +- > xinha/plugins/CharacterMap/character-map.js | 68 - > xinha/plugins/CharacterMap/lang/de.js | 22 +- > .../CharacterMap/popups/select_character.html | 184 - > xinha/plugins/ContextMenu/1.pl | 38 - > xinha/plugins/ContextMenu/context-menu.js | 383 - > xinha/plugins/ContextMenu/lang/de.js | 100 +- > xinha/plugins/ContextMenu/lang/el.js | 94 +- > xinha/plugins/ContextMenu/lang/fr.js | 98 +- > xinha/plugins/ContextMenu/lang/he.js | 94 +- > xinha/plugins/ContextMenu/lang/nl.js | 94 +- > xinha/plugins/DoubleClick/double-click.js | 66 - > xinha/plugins/DynamicCSS/dynamiccss.js | 199 - > xinha/plugins/DynamicCSS/lang/de.js | 24 +- > xinha/plugins/DynamicCSS/lang/fr.js | 12 +- > xinha/plugins/FindReplace/find-replace.js | 42 - > xinha/plugins/FindReplace/fr_engine.js | 291 +- > xinha/plugins/FindReplace/lang/pt_br.js | 60 +- > xinha/plugins/FindReplace/popups/find_replace.html | 324 +- > xinha/plugins/Forms/forms.js | 354 - > xinha/plugins/Forms/popups/fieldset.html | 15 +- > xinha/plugins/Forms/popups/form.html | 21 +- > xinha/plugins/Forms/popups/input.html | 78 +- > xinha/plugins/Forms/popups/label.html | 15 +- > xinha/plugins/Forms/popups/select.html | 217 +- > xinha/plugins/Forms/popups/textarea.html | 41 +- > xinha/plugins/FullPage/full-page.js | 200 - > xinha/plugins/FullPage/lang/de.js | 36 +- > xinha/plugins/FullPage/lang/fr.js | 32 +- > xinha/plugins/FullPage/lang/he.js | 28 +- > xinha/plugins/FullPage/lang/ro.js | 28 +- > xinha/plugins/FullPage/popups/docprop.html | 282 +- > xinha/plugins/FullScreen/full-screen.js | 203 - > xinha/plugins/FullScreen/lang/de.js | 6 - > xinha/plugins/FullScreen/lang/fr.js | 5 - > xinha/plugins/FullScreen/lang/no.js | 6 - > xinha/plugins/FullScreen/lang/pl.js | 6 - > xinha/plugins/HtmlTidy/README | 104 - > xinha/plugins/HtmlTidy/html-tidy-config.cfg | 29 - > xinha/plugins/HtmlTidy/html-tidy-logic.php | 79 - > xinha/plugins/HtmlTidy/html-tidy.js | 105 - > xinha/plugins/HtmlTidy/img/html-tidy.gif | Bin 599 -> 0 bytes > xinha/plugins/HtmlTidy/lang/de.js | 7 - > xinha/plugins/HtmlTidy/lang/fr.js | 8 - > xinha/plugins/HtmlTidy/lang/ja.js | 8 - > xinha/plugins/HtmlTidy/lang/nb.js | 7 - > xinha/plugins/HtmlTidy/lang/nl.js | 5 - > xinha/plugins/InsertAnchor/insert-anchor.css | 1 - > xinha/plugins/InsertAnchor/insert-anchor.js | 76 - > xinha/plugins/InsertPicture/InsertPicture.php | 301 - > xinha/plugins/InsertPicture/img/btn_open.gif | Bin 173 -> 0 bytes > xinha/plugins/InsertPicture/img/nopic.gif | Bin 1537 -> 0 bytes > xinha/plugins/InsertPicture/insert-picture.js | 25 - > xinha/plugins/InsertPicture/lang/de.js | 15 - > xinha/plugins/InsertPicture/lang/fr.js | 22 - > xinha/plugins/InsertPicture/lang/ja.js | 25 - > xinha/plugins/InsertPicture/lang/nb.js | 22 - > xinha/plugins/InsertPicture/lang/sv.js | 35 - > xinha/plugins/InsertPicture/viewpicture.html | 46 - > xinha/plugins/InsertWords/insert-words.js | 70 - > xinha/plugins/Linker/dTree/api.html | 502 +- > xinha/plugins/Linker/dTree/dtree.css | 8 +- > xinha/plugins/Linker/dTree/dtree.js | 1037 ++- > xinha/plugins/Linker/dTree/example01.html | 104 +- > xinha/plugins/Linker/dialog.html | 210 +- > xinha/plugins/Linker/linker.js | 385 - > xinha/plugins/Linker/scan.php | 220 +- > xinha/plugins/ListType/lang/de.js | 24 +- > xinha/plugins/ListType/list-type.js | 137 - > xinha/plugins/QuickTag/lang/pt_br.js | 26 +- > xinha/plugins/QuickTag/popups/quicktag.html | 706 +- > xinha/plugins/QuickTag/quick-tag.js | 53 - > xinha/plugins/QuickTag/tag-lib.js | 381 +- > xinha/plugins/SpellChecker/aspell_setup.php | 246 +- > xinha/plugins/SpellChecker/lang/cz.js | 52 +- > xinha/plugins/SpellChecker/lang/da.js | 52 +- > xinha/plugins/SpellChecker/lang/de.js | 52 +- > xinha/plugins/SpellChecker/lang/he.js | 54 +- > xinha/plugins/SpellChecker/lang/hu.js | 52 +- > xinha/plugins/SpellChecker/lang/nl.js | 54 +- > xinha/plugins/SpellChecker/lang/ro.js | 52 +- > xinha/plugins/SpellChecker/readme-tech.html | 228 +- > xinha/plugins/SpellChecker/spell-check-logic.cgi | 420 +- > xinha/plugins/SpellChecker/spell-check-logic.php | 340 +- > .../plugins/SpellChecker/spell-check-savedicts.php | 74 +- > xinha/plugins/SpellChecker/spell-check-ui.html | 250 +- > xinha/plugins/SpellChecker/spell-check-ui.js | 846 +- > xinha/plugins/SpellChecker/spell-checker.js | 73 - > xinha/plugins/Stylist/stylist.js | 372 - > xinha/plugins/SuperClean/dialog.html | 14 +- > xinha/plugins/SuperClean/lang/de.js | 3 +- > xinha/plugins/SuperClean/super-clean.js | 211 - > xinha/plugins/SuperClean/tidy.php | 358 +- > xinha/plugins/TableOperations/lang/cz.js | 158 +- > xinha/plugins/TableOperations/lang/da.js | 161 +- > xinha/plugins/TableOperations/lang/de.js | 162 +- > xinha/plugins/TableOperations/lang/el.js | 158 +- > xinha/plugins/TableOperations/lang/fi.js | 136 +- > xinha/plugins/TableOperations/lang/fr.js | 154 +- > xinha/plugins/TableOperations/lang/he.js | 158 +- > xinha/plugins/TableOperations/lang/it.js | 158 +- > xinha/plugins/TableOperations/lang/ja.js | 6 +- > xinha/plugins/TableOperations/lang/nb.js | 158 +- > xinha/plugins/TableOperations/lang/nl.js | 158 +- > xinha/plugins/TableOperations/lang/pl.js | 6 +- > xinha/plugins/TableOperations/lang/ro.js | 158 +- > xinha/plugins/TableOperations/lang/ru.js | 6 +- > xinha/plugins/TableOperations/lang/sv.js | 6 +- > .../TableOperations/popups/merge_cells.html | 11 +- > xinha/plugins/TableOperations/table-operations.js | 893 -- > xinha/plugins/UnFormat/popups/unformat.html | 85 - > xinha/plugins/UnFormat/un-format.js | 65 - > xinha/popups/about.html | 296 - > xinha/popups/blank.html | 3 +- > xinha/popups/editor_help.html | 122 +- > xinha/popups/popup.js | 239 +- > xinha/popups/select_color.html | 716 +- > xinha/release-notes.txt | 476 +- > xinha/skins/blue-look/skin.css | 14 +- > xinha/skins/blue-metallic/skin.css | 7 + > xinha/skins/green-look/skin.css | 10 +- > xinha/skins/inditreuse/skin.css | 10 +- > xinha/skins/titan/skin.css | 10 +- > xinha/skins/xp-blue/skin.css | 10 +- > xinha/skins/xp-green/skin.css | 10 +- > 191 files changed, 22579 insertions(+), 20386 deletions(-) > delete mode 100644 xinha/examples/Extended.html > delete mode 100644 xinha/examples/custom.css > delete mode 100644 xinha/examples/dynamic.css > delete mode 100644 xinha/examples/ext_example-body.html > delete mode 100644 xinha/examples/ext_example-dest.php > delete mode 100644 xinha/examples/ext_example-menu.php > delete mode 100644 xinha/examples/ext_example.html > delete mode 100644 xinha/examples/full_example.css > delete mode 100644 xinha/examples/full_example.js > delete mode 100644 xinha/examples/stylist.css > delete mode 100644 xinha/modules/Dialogs/inline-dialog.js > mode change 100644 => 100755 xinha/modules/FullScreen/lang/sv.js > delete mode 100644 xinha/modules/Gecko/paraHandlerDirty.js > delete mode 100644 xinha/plugins/CSS/css.js > delete mode 100644 xinha/plugins/CharCounter/char-counter.js > delete mode 100644 xinha/plugins/CharacterMap/character-map.js > mode change 100644 => 100755 xinha/plugins/CharacterMap/lang/sv.js > delete mode 100644 xinha/plugins/CharacterMap/popups/select_character.html > delete mode 100755 xinha/plugins/ContextMenu/1.pl > delete mode 100644 xinha/plugins/ContextMenu/context-menu.js > delete mode 100644 xinha/plugins/DoubleClick/double-click.js > delete mode 100644 xinha/plugins/DynamicCSS/dynamiccss.js > delete mode 100644 xinha/plugins/FindReplace/find-replace.js > mode change 100644 => 100755 xinha/plugins/FindReplace/lang/sv.js > delete mode 100644 xinha/plugins/Forms/forms.js > delete mode 100644 xinha/plugins/FullPage/full-page.js > delete mode 100644 xinha/plugins/FullScreen/full-screen.js > delete mode 100644 xinha/plugins/FullScreen/lang/de.js > delete mode 100644 xinha/plugins/FullScreen/lang/fr.js > delete mode 100644 xinha/plugins/FullScreen/lang/no.js > delete mode 100644 xinha/plugins/FullScreen/lang/pl.js > delete mode 100644 xinha/plugins/HtmlTidy/README > delete mode 100644 xinha/plugins/HtmlTidy/html-tidy-config.cfg > delete mode 100755 xinha/plugins/HtmlTidy/html-tidy-logic.php > delete mode 100644 xinha/plugins/HtmlTidy/html-tidy.js > delete mode 100644 xinha/plugins/HtmlTidy/img/html-tidy.gif > delete mode 100644 xinha/plugins/HtmlTidy/lang/de.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/fr.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/ja.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/nb.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/nl.js > delete mode 100755 xinha/plugins/InsertAnchor/insert-anchor.js > delete mode 100644 xinha/plugins/InsertPicture/InsertPicture.php > delete mode 100644 xinha/plugins/InsertPicture/img/btn_open.gif > delete mode 100644 xinha/plugins/InsertPicture/img/nopic.gif > delete mode 100644 xinha/plugins/InsertPicture/insert-picture.js > delete mode 100644 xinha/plugins/InsertPicture/lang/de.js > delete mode 100644 xinha/plugins/InsertPicture/lang/fr.js > delete mode 100644 xinha/plugins/InsertPicture/lang/ja.js > delete mode 100644 xinha/plugins/InsertPicture/lang/nb.js > delete mode 100644 xinha/plugins/InsertPicture/lang/sv.js > delete mode 100644 xinha/plugins/InsertPicture/viewpicture.html > delete mode 100755 xinha/plugins/InsertWords/insert-words.js > delete mode 100644 xinha/plugins/Linker/linker.js > mode change 100644 => 100755 xinha/plugins/ListType/lang/sv.js > delete mode 100644 xinha/plugins/ListType/list-type.js > delete mode 100644 xinha/plugins/QuickTag/quick-tag.js > delete mode 100644 xinha/plugins/SpellChecker/spell-checker.js > delete mode 100644 xinha/plugins/Stylist/stylist.js > delete mode 100644 xinha/plugins/SuperClean/super-clean.js > mode change 100644 => 100755 xinha/plugins/TableOperations/lang/sv.js > mode change 100644 => 100755 xinha/plugins/TableOperations/popups/merge_cells.html > delete mode 100644 xinha/plugins/TableOperations/table-operations.js > delete mode 100644 xinha/plugins/UnFormat/popups/unformat.html > delete mode 100644 xinha/plugins/UnFormat/un-format.js > delete mode 100644 xinha/popups/about.html > > > -- > > Best Regards, André Hentschel > > > > The xinha editor does not show up in chrome either for a long time now... could it be related to this? I even opened a bug report on chromium but it still wasn't looked at. Maybe this solves it too...

1 0

'Expensive' expressions in loop limits (was: Implementation of D3DXSHScale)
by Dan Kegel 19 Jun '12

19 Jun '12

Nozomi wrote: + for (i = 0; i < order * order; i++) I might have written int n = order * order; for (i=0; i < n; i++) to avoid repeating the multiplication every time around the loop, even though multiplication is cheap nowadays, and -O1 will optimize it out anyway. Staying in the habit of avoiding 'expensive' operations in loop limits might still be a good idea, since the optimizer can't always save you. Or is that considered ugly these days? D3DXSHAdd() has the same code, which is where this came from, probably.

2 1

Re: d3dx9_36: Implementation of a test for D3DFMT_A8B8G8R8
by Józef Kucia 19 Jun '12

19 Jun '12

I've also added a tests for this pixel format in the patch, which was submitted yesterday: http://www.winehq.org/pipermail/wine-patches/2012-June/115268.html

1 0

Re: [PATCH 2/3] gdi32: Fix East-Asian font parameters. (resend)
by Marvin 19 Jun '12

19 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19270 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0