June 2012 - Wine-devel - list.winehq.org

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Marvin 19 Jun '12

19 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19269 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.
by Vincent Povirk 19 Jun '12

19 Jun '12

I'm still a little worried about seeking the stream behind libtiff's back, but otherwise it looks good.

2 1

Disabling joysticks with registry keys and joy.cpl
by Lucas Zawacki 19 Jun '12

19 Jun '12

Hello all, disabling an specific joystick device is an issue that is raised from time to time in this list. I'm planning on implementing it as a registry key like 'DirectInput/Disable controllername'. However I'd like the ability to disable specific joysticks on Linux, like the /dev/input/js* version, while keeping the /dev/input/event* one being enumerated. One option for doing this would be having a "Disable USB Controller" -> "driver" key with options being: "linux", "linuxinput", and "all". My only doubt is how would you guys want to have this option in joy.cpl? I think the correct thing to do would be to disable it with "all", but my use case includes a user disabling the repeated joysticks on Linux through the interface and if he's only able to disable all drivers at once that would be confusing and less useful. The bottom line is: can I add platform dependent code in joy.cpl for this purpose? If that's not an option, do you have some other way to do through joy.cpl or should it be registry only? Attached is an example patch of the approach for joystick_linuxinput.c Cheers, Lucas

2 2

Re: d3dx9_36: Reckonize A8B8G8R8 format
by Stefan Dösinger 18 Jun '12

18 Jun '12

Hi, Please add the format to the dds tests in dlls/d3dx9_36/tests/surface.c > { 32, 0x0000ffff, 0xffff0000, 0x00000000, 0x00000000, D3DFMT_G16R16 }, > + { 32, 0xff, 0xff00, 0xff0000, 0xff000000, D3DFMT_A8B8G8R8 }, The other 32 bit formats in this table have their bitmasks padded to 32 bit with leading zeroes. Stefan Am Freitag, 15. Juni 2012, 18:18:46 schrieb Nozomi Kodama: This patch solves the color problem appearing in bug 30786. Nozomi

1 1

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dmitry Timoshkov 18 Jun '12

18 Jun '12

Dan Kegel <dank(a)kegel.com> wrote: > @@ -190,6 +190,8 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) > HOTKEY_Refresh(infoPtr, hdc); > else { > PAINTSTRUCT ps; > + /* In some apps, the hotkey doesn't draw unless we invalidate it here */ > + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); It doesn't make sense to invalidate before painting in the paint handler. -- Dmitry.

2 1

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Chris Robinson 18 Jun '12

18 Jun '12

On Friday, June 15, 2012 3:39:33 PM Andrew Eikum wrote: > One thing to note is that PulseAudio has an absurdly high default > latency (two seconds), and due to its poor API there's no (easy) way > for us to control it. The latency is likely caused by PulseAudio setting a much larger tlength (and minreq) than what you asked for. This happens all the time for me when the server has been running. The trick I've found to dealing with this in OpenAL Soft is to essentially ignore what PulseAudio sets and do your free space calculations so that only the size of the buffer you requested is used. Something like: size_t writable_size(pulse_data *data) { uint buffer_size = our requested buffer size in bytes; uint update_size = our expected period size in bytes; /* This is signed since it could come out negative */ ssize_t len; pa_threaded_mainloop_lock(data->loop); len = pa_stream_writable_size(data->stream) - data->attr.tlength + buffer_size; pa_threaded_mainloop_unlock(data->loop); if(len < 0) return 0; len -= len%update_size; return len; } The update_size is only relevant if mmdevapi updates in period-sized chunks. If it doesn't, you can just remove it and the rounding. The tlength should be kept updated using pa_stream_set_buffer_attr_callback, in case the server tries to increase it more during runtime. When creating the stream, I set minreq to the period size, and tlength to the requested buffer size. I also set the flags PA_STREAM_INTERPOLATE_TIMING, PA_STREAM_AUTO_TIMING_UPDATE, and PA_STREAM_ADJUST_LATENCY. The most important part is to not rely on PA_STREAM_EARLY_REQUESTS or the write callback to tell you when some space is free for writing, since as noted above, PulseAudio can set unreasonably large values. This doesn't completely fix the latency problem, as I'll still get better performance using ALSA's dmix, but it helps immensely.

2 4

comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dan Kegel 18 Jun '12

18 Jun '12

In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't also ask the background to be redrawn again.)

2 1

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.
by Vincent Povirk 18 Jun '12

18 Jun '12

This looks better, but I still think you should use WICPersistOptionNoCacheStream. Some of your failure cases in create_metadata_reader will return a reference to an IWICMetadataReader, which seems wrong.

2 1

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.
by Vincent Povirk 18 Jun '12

18 Jun '12

> + hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL, persist_options); > + if (FAILED(hr)) > + ERR("IWICPersistStream_LoadEx error %#x\n", hr); We can't use that stream because we provide separate seek and read/write methods to libtiff, and libtiff may rely on the stream's position to not change between operations. This illustrates a design flaw in WIC. Normally, we would just clone the stream, but IWICStream doesn't implement the Clone method. I think we are probably supposed to create a new IWICStream based on the given stream, but the resulting stream won't be thread-safe with ours. I think for now it's OK to re-use this stream as long as you seek it back to where it was when you're done, but we may have to change that later. Also, LoadEx should (but does not yet) save the stream so it can create an IWICFastMetadataEncoder. If you re-use the bitmap decoder's stream, you should also use the WICPersistOptionNoCacheStream flag when you create the metadata reader to make sure it won't do that. Your GetReaderByIndex method should check whether This->metadata_reader has been set and return an error if not. Otherwise, the patch looks good to me.

2 4

Re: atl80: prefer native, if present
by Alexandre Julliard 18 Jun '12

18 Jun '12

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sun, 17 Jun 2012 17:37:15 +0200 > Subject: atl80: prefer native, if present > > --- > dlls/atl80/atl80.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) There's no reason to do that, most of the dll is already implemented. -- Alexandre Julliard julliard(a)winehq.org

2 2