July 2012 - Wine-devel - list.winehq.org

Re: [PATCH 4/6] jscript: Use prototype for buitin Number properties
by Marvin 24 Jul '12

24 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20280 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform (resend)
by Alexandre Julliard 24 Jul '12

24 Jul '12

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +DWORD NTAPI RtlRunOnceExecuteOnce(PRTL_RUN_ONCE initonce, PRTL_RUN_ONCE_INIT_FN callback, void *parameter, void **ctxt) > +{ > +#ifdef __linux__ > + if (!use_futexes()) return FALSE; > + > + for (;;) > + { > + DWORD_PTR val = (DWORD_PTR)interlocked_cmpxchg_ptr( &initonce->Ptr, (void*)1, NULL ); > + switch (val & 0x3) > + { > + case 0: > + { > + DWORD ret = callback(initonce, parameter, ctxt); > + if (ret) > + { > + DWORD_PTR context = ctxt ? (DWORD_PTR)*ctxt : 0; > + context = (context & ~0x3) | 0x2; > + interlocked_cmpxchg_ptr( &initonce->Ptr, (void*)context, (void*)1 ); > + } > + else > + interlocked_cmpxchg_ptr( &initonce->Ptr, NULL, (void*)1 ); > + futex_wake( (int *)&initonce->Ptr, 1 ); > + return ret; > + } > + case 1: > + /* blocked by another thread */ > + futex_wait( (int *)&initonce->Ptr, 1, NULL ); > + break; > + case 2: > + /* already initialized */ > + return TRUE; > + } > + } It's supposed to return an NTSTATUS, not a boolean. Also you have to always return the context, and you should try to do a generic implementation first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] jscript: Use prototype for buitin Date properties
by Marvin 24 Jul '12

24 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20279 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3] apphelp/tests: Add tests for ApphelpCheckShellObject
by Alexandre Julliard 24 Jul '12

24 Jul '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > + flags = 0xdeadbeeffeedfaceULL; Don't use long long constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] jscript: Use prototype for buitin Boolean properties
by Marvin 24 Jul '12

24 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20278 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Use prototype for buitin Array properties
by Marvin 24 Jul '12

24 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20277 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.
by Michael Stefaniuc 24 Jul '12

24 Jul '12

Hello Dmitry, On 07/24/2012 08:01 AM, Dmitry Timoshkov wrote: > The patches in this series do not depend on each other, numeration is just > for a convenience. Patches do basically the same job for different objects, > so I decided to not invent a new subject for every separate kind of object. > --- > dlls/windowscodecs/bmpdecode.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dlls/windowscodecs/bmpdecode.c b/dlls/windowscodecs/bmpdecode.c > index 6da6a3c..1a1ee0a 100644 > --- a/dlls/windowscodecs/bmpdecode.c > +++ b/dlls/windowscodecs/bmpdecode.c > @@ -94,6 +94,8 @@ static inline BmpDecoder *impl_from_IWICBitmapFrameDecode(IWICBitmapFrameDecode > static HRESULT WINAPI BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface, REFIID iid, > void **ppv) > { > + BmpDecoder *This = impl_from_IWICBitmapFrameDecode(iface); > + > TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > > if (!ppv) return E_INVALIDARG; > @@ -102,7 +104,7 @@ static HRESULT WINAPI BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > - *ppv = iface; > + *ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { this part of the change is gratuitous. As long as there is only one interface implementation in the object there is no need for impl_from_Foo(). bye michael

2 1

Re: [12/18] windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts.
by Michael Stefaniuc 24 Jul '12

24 Jul '12

Hello Dmitry, On 07/24/2012 08:12 AM, Dmitry Timoshkov wrote: > --- > dlls/windowscodecs/jpegformat.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c > index 53d7ec4..2c77d4f 100644 > --- a/dlls/windowscodecs/jpegformat.c > +++ b/dlls/windowscodecs/jpegformat.c > @@ -469,6 +470,8 @@ static const IWICBitmapDecoderVtbl JpegDecoder_Vtbl = { > static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *iface, REFIID iid, > void **ppv) > { > + JpegDecoder *This = impl_from_IWICBitmapFrameDecode(iface); > + > TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > > if (!ppv) return E_INVALIDARG; > @@ -477,7 +480,7 @@ static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *if > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > - *ppv = iface; > + *ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { same here: not needed. bye michael

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform
by Marvin 24 Jul '12

24 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20269 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PRO (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PROX64 (32 bit sync) === sync.c:1231: Test failed: got 0 === TEST64_W7SP1 (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PROX64 (64 bit sync) === sync.c:1231: Test failed: got 0 === TEST64_W7SP1 (64 bit sync) === sync.c:1231: Test failed: got 0

1 0

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize()
by Marvin 24 Jul '12

24 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20268 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PRO (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PROX64 (32 bit sync) === sync.c:1225: Test failed: got 0 === TEST64_W7SP1 (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PROX64 (64 bit sync) === sync.c:1225: Test failed: got 0 === TEST64_W7SP1 (64 bit sync) === sync.c:1225: Test failed: got 0

1 0