July 2012 - Wine-devel - list.winehq.org

Re: [PATCH 4/4] ieframe: Avoid useless QI(IID_IWebBrowser2) calls in tests by passing IWebBrowser2 interface where possible
by Marvin 19 Jul '12

19 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20160 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: include/winhttp.h: Make strings in WINHTTP_PROXY_INFO non-const
by Hans Leidekker 19 Jul '12

19 Jul '12

On Thu, 2012-07-19 at 07:27 +0000, Heiko Hund wrote: > The strings shouldn't be const according to the docs at [1] and > declaring them as LPWSTR removes some false warnings when > compiling code GlobalFree()ing them with mingw. Please also remove unnecessary casts from Wine.

1 0

Re: [PATCH 01/10] dsound/tests: Add IDirectSound refcount and COM aggregation tests.
by Marvin 18 Jul '12

18 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20152 Your paranoid android. === WNT4WSSP6 (32 bit dsound) === dsound.c:194: Test failed: DirectMusicPerformance create failed: 80070057, expected CLASS_E_NOAGGREGATION dsound.c:196: Test failed: dso = DEADBEEF

1 0

Re: ole32: Forward BSTR functions to oleaut32
by Alexandre Julliard 18 Jul '12

18 Jul '12

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -1244,6 +1244,9 @@ static void COMPOBJ_InitProcess( void ) > static void COMPOBJ_UninitProcess( void ) > { > UnregisterClassW(wszAptWinClass, hProxyDll); > + > + if(oleaut32_instance) > + FreeLibrary(oleaut32_instance); Since oleaut32 imports ole32 you'll never get here. Using a delayed import would probably be easier. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.
by Jacek Caban 18 Jul '12

18 Jul '12

Hi Gerald, On 03/07/12 23:35, Gerald Pfeifer wrote: > I noticed we return in this case, without initializing this variable. > Visual inspection indicates we do not seem to access the variable in > this error case, but a) better safe than sorry, and b) GCC 4.8 currently > warns about it. > > Not sure URLPOLICY_DISALLOW is the best return value, open for better > alternatives. I generally don't think this patch makes things any better (or worse). If we return an error, the caller should not expect this value to be sane. What's the GCC 4.8 warning? Jacek

2 4

Re: d3dx9_36: Implementation of D3DXSHRotateZ
by Matteo Bruni 18 Jul '12

18 Jul '12

2012/7/18 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > Minor nitpicks, but nevertheless: > -@ stub D3DXSHRotateZ(ptr long long ptr) > +@ stdcall D3DXSHRotateZ(ptr long long ptr) ... > +FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in) I guess using "float" in the spec file for the third parameter would be more appropriate (yes, it was already wrong but that's not an excuse ;) + if ( i >= order * order || ( (order > D3DXSH_MAXORDER) && ( i >= D3DXSH_MAXORDER * D3DXSH_MAXORDER ) ) ) + expected = ( i + 1.0f ) * ( i + 1.0f ); Bad indentation. In general the inner for loop in the tests feels awkward, try to rewrite it to avoid the duplicated stuff. + } + } + } You're adding a tab character here, please use only whitespaces for indentation. That said, thanks for your work on d3dx9!

1 0

Re: [PATCH 2/2] vbscript: Added LCase implementation
by Marvin 18 Jul '12

18 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20130 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] gdiplus: Add 8bpp to the list of supported formats.
by Vincent Povirk 18 Jul '12

18 Jul '12

> + &GUID_WICPixelFormat8bppGray, This will give you a halftone palette instead of a grayscale palette, unless you add special handling for that format.

2 2

Re: [PATCH 5/5] d3dcompiler: Implement basic expressions parsing.
by Stefan Dösinger 17 Jul '12

17 Jul '12

Am Montag, 16. Juli 2012, 20:39:23 schrieb Matteo Bruni: > + HLSL_IR_BINOP_MUL, > ... > + HLSL_IR_BINOP_DOT, HLSL has 3 somewhat related multiplication operations: "*", "mul" and "dot". Dot is fairly straightforward, but "*" and "mul" have subtle differences. I recommend to write tests to find out the exact details, but as far as I remember "float4 * float4" gives you a float4 with a component-wise multiplication, whereas mul(float, float) returns a scalar like the dot product. "float4x4 * float4" is an error, but mul(float4x4, float4) performs a matrix-vector multiplication and returns a float4. > +static struct hlsl_type *expr_common_type(struct hlsl_type *t1, struct > hlsl_type *t2, > + struct source_location *loc) This type inference system might be a bit too limited, you have to take the operation into account. e.g. a dot(float3, float4) returns a scalar and crs(float4, float4) returns a float3.

2 1

Re: riched20: Avoid uninitialized field in STGMEDIUM structure (LLVM/Clang).
by Alexandre Julliard 17 Jul '12

17 Jul '12

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -1098,6 +1098,8 @@ static BOOL ME_RTFInsertOleObject(RTF_Info *info, HENHMETAFILE hemf, HBITMAP hbm > BOOL ret = FALSE; > DWORD conn; > > + memset(&stgm, 0, sizeof(stgm)); > + Please fix the bugs (if any) instead of silencing the warnings by memsetting everything to 0. -- Alexandre Julliard julliard(a)winehq.org

1 0