July 2012 - Wine-devel - list.winehq.org

Re: [PATCH 9/9] mshtml: Added test of calling IDispatchEx properties
by Marvin 13 Jul '12

13 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19995 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: Comdlg32: Select initial text in edit control (try 2)
by Dmitry Timoshkov 13 Jul '12

13 Jul '12

Suresh Murty <murtys.wine(a)gmail.com> wrote: > Sends a EM_SETSEL message after the initial text has been set. This is wrong place for both a test and a fix. The text should be selected on focus by a dialog control itself. -- Dmitry.

1 0

Re: Comdlg32: Select initial text in edit control (try 2)
by Marvin 13 Jul '12

13 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19988 Your paranoid android. === W7PROX64 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 75B94C19

1 0

Re: joy.cpl: Correct joystick testing thread behavior
by Alexandre Julliard 12 Jul '12

12 Jul '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > @@ -419,14 +421,19 @@ static INT_PTR CALLBACK test_dlgproc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM > SendDlgItemMessageW(hwnd, IDC_TESTSELECTCOMBO, CB_SETCURSEL, 0, 0); > test_handle_joychange(hwnd, data); > > - thread = CreateThread(NULL, 0, input_thread, (void*) data, 0, &tid); > + ResumeThread(thread); > } > } > break; > > + case PSN_KILLACTIVE: > + SuspendThread(thread); > + break; You never want to use SuspendThread, it can't possibly work reliably. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] scrrun: Added IDispatch support for IFileSystem3
by Alistair Leslie-Hughes 12 Jul '12

12 Jul '12

On 12/07/2012 5:02 PM, Nikolay Sivov wrote: > For http://bugs.winehq.org/show_bug.cgi?id=9638 and similar cases > I have already submitted a patch for this http://source.winehq.org/patches/data/87925 Best Regards Alistair Leslie-Hughes

2 2

Re: [PATCH 4/5] winex11: Release memory on xrandr cleanup.
by Alexandre Julliard 12 Jul '12

12 Jul '12

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c > index 83137a4..a8dccd4 100644 > --- a/dlls/winex11.drv/xrandr.c > +++ b/dlls/winex11.drv/xrandr.c > @@ -289,6 +289,12 @@ done: > wine_tsx11_unlock(); > } > > +void X11DRV_XRandR_Cleanup(void) > +{ > + HeapFree( GetProcessHeap(), 0, real_xrandr_rates_count ); > + HeapFree( GetProcessHeap(), 0, real_xrandr_rates ); > +} It's not worth adding complexity to free memory, in practice the graphics driver is never going to be unloaded except at process exit. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msi: fix incorrect decoding of msi stream-names
by Hans Leidekker 12 Jul '12

12 Jul '12

On Wed, 2012-07-11 at 15:03 +0000, Oleg Jakobsen wrote: > @@ -203,6 +203,7 @@ BOOL decode_streamname(LPCWSTR in, LPWSTR out) > *out++ = mime2utf(ch&0x3f); > count++; > ch = mime2utf((ch>>6)&0x3f); > + continue; > } > } > *out++ = ch; Why is it incorrect? It seems to me that the upper bits should be written as the next character but now you are discarding them.

2 1

Re: [2/2] windowscodecs: Add a test for palette associated with black&white TIFF image.
by Marvin 12 Jul '12

12 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19971 Your paranoid android. === WXPPROSP3 (32 bit tiffformat) === tiffformat.c:115: Test failed: CreateDecoderFromStream error 0x88982f8e tiffformat: unhandled exception c0000005 at 00413EB2 === WVISTAADM (32 bit tiffformat) === tiffformat.c:115: Test failed: CreateDecoderFromStream error 0x88982f8e tiffformat: unhandled exception c0000005 at 00413EB2

1 0

Re: msi: fix incorrect decoding of msi stream-names
by Nikolay Sivov 12 Jul '12

12 Jul '12

On 7/11/2012 18:03, Oleg Jakobsen wrote: > Looked at how you decode msi-stream names, and spotted a minor error > whith the decoding. > > regards > Oleg > > Why do you think it's an error? Looks like in this case it decodes one input WCHAR to two output WCHARs in a single pass.

1 0

Re: [3/5] windowscodecs: Create a predefined black&white palette if 1 bpp TIFF image doesn't have one.
by Vincent Povirk 11 Jul '12

11 Jul '12

Are you sure about this? My understanding is that the result of CopyPalette is unspecified when your pixel format is not an indexed color format (in this case, a grayscale format). So, while it's not really a problem to do that (unless a program relies on the exact behavior of this decoder, which seems unlikely), for correctness you shouldn't ever be relying on this change.

2 5