September 2012 - Wine-devel

Re: imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard 25 Sep '12

25 Sep '12

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So what happens to the window if the first IMC is destroyed? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.
by Juan Lang 25 Sep '12

25 Sep '12

Hi Qian, > There is a winpcap based network authentication client which check for the DhcpEnabled value, this patch make the app happy and then the app works with André's pcap wrapper [1]. > > Please let me know if this is acceptable, or we have to correctly implement DhcpEnabled status? I think this is fine, but you'd want to remove/fix some outdated comments I wrote at the same time: * NOTES * Since GetAdaptersInfo never returns adapters that have DHCP enabled, * this function does nothing. * * FIXME * Stub, returns ERROR_NOT_SUPPORTED. */ DWORD WINAPI IpReleaseAddress(PIP_ADAPTER_INDEX_MAP AdapterInfo) { TRACE("AdapterInfo %p\n", AdapterInfo); /* not a stub, never going to support this (and I never mark an adapter as DHCP enabled, see GetAdaptersInfo, so this should never get called) */ The same comments are in IpRenewAddress. Historical reason: when I wrote iphlpapi's first implementation, I had recently been working on a Windows app that released and renewed IP addresses on DHCP-enabled interfaces, because Windows at the time was pretty poor at doing so in response to changes to wireless connection state. I figured I wouldn't be the only one to have had to work around this issue, so I didn't want to have to implement IpReleaseAddress and IpRenewAddress in Wine. That was almost 10 years ago now, so these reasons no longer apply. I'm pretty sure the app I wrote isn't in use any longer, and even if it is, it isn't in use on Wine (I also wrote a Linux version.) Thanks, --Juan

3 2

Re: vbscript: Added Space() implementation
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21787 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] mshtml: Added DISPATCH_PROPERTYGET|DISPATCH_METHOD flags support for elements exposed as window properties
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21785 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: shlwapi: PathCreateFromUrlA() should not crash when given NULL buffers.
by Alexandre Julliard 25 Sep '12

25 Sep '12

Francois Gouget <fgouget(a)codeweavers.com> writes: > Add NULL and insufficient buffer tests for PathCreateFromUrl(). > --- > dlls/shlwapi/path.c | 3 +++ > dlls/shlwapi/tests/path.c | 49 +++++++++++++++++++++++++++++---------------- > 2 files changed, 35 insertions(+), 17 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so path.c && touch path.ok path.c:322: Test succeeded inside todo block: got len = 22 expected 22 from url file:///localhost/c:/foo/bar path.c:322: Test succeeded inside todo block: got len = 19 expected 19 from url file://host//c:/foo/bar make: *** [path.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21782 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

2 1

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)
by Per Johansson 25 Sep '12

25 Sep '12

Hi, I should probably add a note that when I wrote this I had some doubts it it belongs in start.exe, and I still somewhat do. The alternative would be to write a new program. The advantage to that is: 1. start.exe is left more similar to it's windows counterpart. 2. This other program could handle multiple files sent in the same AppleEvent, which is possible. 3. The same program could also act as a proxy for a dock icon, handling clicks and activating windows (this is a later project). I'd imagine it'd be called winehostproxy or somesuch and handle several types of interaction with the host (is that what we call it btw?). If you think that's more appropriate I can work on that instead of adding this to start. Regards, -- Per Johansson 2012/9/23 Per Johansson <pelle(a)morth.org> >

2 2

Re: [5/5] dxgi/tests: Test some reference counts.
by Alexandre Julliard 25 Sep '12

25 Sep '12

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/device.c | 69 > ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 18 deletions(-) In general testing reference count values is not useful, unless you have an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Spam applications for testbot accounts
by Scott Ritchie 25 Sep '12

25 Sep '12

Never underestimate the overeagerness of bots, I suppose... We're getting a lot of spam applications for testbot accounts now, maybe 2-3 per day. Some are easy to discard because they put stuff like penis pills into the info field, but others look like just names. Suggestions are welcome. In the meantime it would be nice if anyone requesting a legit account put some sort of non-spammy text in there like "Hey I'm a human I read wine-devel"

2 1

Overriding the check for ownership of a prefix
by Joerg-Cyril.Hoehle＠t-systems.com 24 Sep '12

24 Sep '12

Scott, I don't think you need to override this check, esp. given that there's a good reason for it being there: >Note that there is a problem with this setup if the app modifies the >registry and we then need to update the prefix-default registry I've excellent experience with symbolic links. In fact, none of the apps (games) I use are installed directly within any .wine prefix. Drive_c/Program Files/Games is a symbolic link to a large partition. >Imagine a distro package containing a Windows game in the form of a >read-only copy of an installed prefix (into, say, /opt). So I recommend the following setup: - Have the game's main directory be something like /opt/games/XYZ in UNIX, but tell it to install to C:\games/XYZ - During installation, write down all registry keys that the app creates and every file that it stores outside of its local directory. Beware: the name of the directory C:\Program.. depends upon every user's locale at .wine creation time! Use C:\Games\ instead to avoid that pitfall. For every user: - After .wine is created normally, add a symlink from Drive_c/Games to /opt/games - Add registry keys or dlls needed by the app. wineprefixcreate ln -s /opt/games/XYZ $HOME/.wine/drive_c/games cp -p whatever.dll $HOME/.wine/drive_c/windows/system32/ wine regedit xyz.reg Trivial, isn't it? Typically, you don't need to recreate the content of user-local APPDATA directories. The app will create them upon each run, since they ought to run with different users on one machine. Caveat: Although my .wine and games directories are distinct, I've no experience with write-protecting the games partition. Obviously, this only has a chance to work with modern apps, written after MS started recommending separating the app's dir from its per-local configuration files to be since stored in ~/LOCALAPPDATA or the like. Thus w9x/w2k-era games are ruled out. Still, I don't know where those apps attempt to store e.g. crash logs. I've seen apps write high-scores or savegames to their central directory when w2k was set in winecfg, and use HKCU/LOCALAPPDATA (what's the exact name?) when running in xp mode. I've made excellent experience with plenty of apps sharing a single .wine-games prefix with such a setup. I.e. you don't need one prefix per app. Like on a real box, the apps ought to be able to coexist. Drawback: when I was initially attracted to Wine 5 years ago, every .wine was a tiny 3-4MB. Nowadays it's more than 10 times that size, and I'm not happy with that. Using a single onion-union-fs to share drive_c/xyz may be interesting -- for as long as one single version of Wine is in use. Regards, Jörg Höhle

2 1