September 2012 - Wine-devel

d3dx9: Implement D3DXSHEvalDirectionalLight
by Nozomi Kodama 24 Sep '12

24 Sep '12

Hello, do it remain problems with this patch? Nozomi

1 0

Re: [PATCH] dmusic: Add master clock tests.
by Andrew Eikum 24 Sep '12

24 Sep '12

On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote: > @@ -66,6 +68,11 @@ static void test_dmusic(void) > return; > } > > + hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock); > + ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr); > + ok(clock != NULL, "No clock returned\n"); > + trace(" guidPort = %s\n", debugstr_guid(&guid_clock)); > + Minor nit-pick: you never release the clock.

1 0

Re: [PATCH 2/2] mshtml: Added function overriding tests
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21757 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added support for limit argument in String.split
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21756 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: Assorted spelling fixes.
by Julian Rüger 24 Sep '12

24 Sep '12

Hi Francois, > - /* if we set the bufferpointer to NULL here UrlUnescape fails and string gets not converted */ > + /* if we set the buffer pointer to NULL here UrlUnescape fails and the string is not converted */ for consistency with the other buffer pointer comments and better readability, I suggest you add a comma here: + /* if we set the buffer pointer to NULL here, UrlUnescape fails and the string is not converted */ Best regards, Julian

1 0

Re: [PATCH 4/4] mshtml: Added IHTMLElement::contains implementation
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21753 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] mshtml: Added function overriding tests
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21751 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

RFC: Locale-independent case-insensitive string comparison
by Francois Gouget 24 Sep '12

24 Sep '12

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 28f82a3..f465ad7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -640,7 +640,7 @@ static void HTTP_FixURL(http_request_t *request) } } - if(CSTR_EQUAL != CompareStringW( LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE, + if(CSTR_EQUAL != CompareStringW( LOCALE_INVARIANT, NORM_IGNORECASE, request->path, strlenW(request->path), szHttp, strlenW(szHttp) ) && request->path[0] != '/') /* not an absolute path ?? --> fix it !! */ { In this code snippet it feels wrong to have this string comparison depend on the system locale, which in Wine's case would come from the user's Unix locale. Isn't this a case where LOCALE_INVARIANT would be better? However I have not found a case where this makes a difference anyway, either with 'http:' or with 'file:'. That is, 'file:' always matches 'FILE:', even in Turkish, as long as I don't use NORM_LINGUISTIC_CASING. Conversely, 'fîle:' is different from 'FILE:' no matter what. Once I have a CompareString() test-case I can make some for UrlIs(), PathCreateFormURL(), possibly ShellExecute(), etc. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.
by Józef Kucia 24 Sep '12

24 Sep '12

Hi, On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > + hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, > D3DLOCK_READONLY); > + ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, > expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) > + for (i = 0; i < 16; i++) > + ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i], > "Byte at index %u is 0x%02x, expected 0x%02x\n", i, > ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]); > + IDirect3DTexture9_Release(texture); > You should call IDirect3DTexture9_UnlockRect before IDirect3DTexture9_Release.

2 1

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Henri Verbeet 24 Sep '12

24 Sep '12

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > > +struct refresh_rates { Formatting. > +struct refresh_rates refresh_list[] = This should be static const. > + ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr); "returned". > + for (i = 0; i < sizeof(refresh_list)/sizeof(struct refresh_rates); i++) I generally prefer "sizeof(*refresh_list)", or perhaps "sizeof(refresh_list[0])" over "sizeof(struct refresh_rates)" in this kind of situation. > + "Numerator %d is %d.\n", i, result_desc.BufferDesc.RefreshRate.Numerator); These are unsigned variables.

1 0