October 2013 - Wine-devel - list.winehq.org

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy 26 Oct '13

26 Oct '13

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

Re: ddraw/tests: Fix compilation on systems that don't support nameless unions.
by Marvin 26 Oct '13

26 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3061 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00420E52 === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 0041212F

1 0

Re: shell32/tests: Fix compilation with -D__WINESRC__
by Marvin 26 Oct '13

26 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3060 Your paranoid android. === w2008s64 (32 bit shlexec) === shlexec.c:1539: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt453.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test file.shlexec' shlexec.c:2607: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' shlexec.c:2620: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' shlexec.c:2632: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' === w864 (32 bit shlexec) === shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2060: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1539: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt2FC.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test file.shlexec' shlexec.c:2607: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' shlexec.c:2620: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' shlexec.c:2632: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' === w864 (64 bit shlexec) === shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2060: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F93936ABDC

1 0

Re: msvcrt: add support for _chsize_s (try #3)
by Marvin 25 Oct '13

25 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3053 Your paranoid android. === wvista (32 bit file) === Failure running script in VM: timed out waiting for the child process === w2008s64 (32 bit file) === Failure running script in VM: timed out waiting for the child process === w7pro64 (32 bit file) === file.c:1574: Test failed: Wrong file size Timeout === w864 (32 bit file) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [PATCH 1/2] advapi32: HKCR merge: foundation
by Alexandre Julliard 25 Oct '13

25 Oct '13

George Stephanos <gaf.stephanos(a)gmail.com> writes: > @@ -224,13 +248,138 @@ static NTSTATUS open_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES *a > > } > > +static LSTATUS create_hkcr_struct( HKEY *hkey, opened_hkcr_t **hkcr ) > +{ > + UINT_PTR handle = nb_hkcr_handles, i; > + LSTATUS ret = ERROR_SUCCESS; > + > + EnterCriticalSection( &hkcr_handles_cs ); > + > + for (i = 0; i < nb_hkcr_handles; i++) > + { > + if (!hkcr_handles[i]) > + { > + handle = i; > + break; > + } > + } You need some sort of free list instead of a linear search. Also you can probably avoid one level of pointers and store objects directly. Returning a pointer to the object outside of the critical section is not a good idea. > +static HKEY resolve_hkcr( HKEY hkey ) > +{ > + HKEY ret; > + UINT_PTR idx = (UINT_PTR)hkey >> 2; > + opened_hkcr_t *hkcr; > + if (idx <= nb_hkcr_handles) > + { > + EnterCriticalSection( &hkcr_handles_cs ); The count needs to be protected by the critical section too. Also please write a better subject line for the commit. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps.
by Henri Verbeet 25 Oct '13

25 Oct '13

On 25 October 2013 00:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/ddraw/tests/ddraw2.c | 26 ++++++++++++++++++++++++-- > dlls/ddraw/tests/ddraw7.c | 27 ++++++++++++++++++++++++--- > 2 files changed, 48 insertions(+), 5 deletions(-) > > diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c > index f4702f1..801135d 100644 > --- a/dlls/ddraw/tests/ddraw2.c > +++ b/dlls/ddraw/tests/ddraw2.c > @@ -3663,6 +3663,7 @@ static void test_rt_caps(void) > DWORD caps_out; > HRESULT create_device_hr; > HRESULT set_rt_hr; > + HRESULT alternative_set_rt_hr; > } > test_data[] = > { This kind of construction doesn't generally make me very happy, but on the other hand I'm not sure I can come up with something that's much better either. I do think we should mark the alternative results as broken. Some of the Evergreen results in later patches in this series are a bit surprising to me. I wrote the test on Windows 7 / AMD Cayman, which should be very close to Evergreen hardware.

2 2

Re: [PATCH 2/5] ddraw/tests: Allow some flags to fail surface creation in test_rt_caps.
by Marvin 25 Oct '13

25 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3031 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:3915: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw2.c:3915: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000. === w864 (32 bit ddraw1) === ddraw1.c:3289: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw1.c:3289: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000.

2 1

Re: [3/4] kernel32/tests: WaitCommEvent may sometimes return immediately on a busy system when write operation to a COM-port
by Marvin 24 Oct '13

24 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3039 Your paranoid android. === w2008s64 (64 bit comm) === comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting === w7pro64 (64 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1552: test_AbortWaitCts timeout 500 handle 0000000000000068 comm.c:1519: Changing CommMask on the fly for handle 0000000000000068 after timeout 500

1 0

Re: [2/4] kernel32/tests: Increase the timeout for completion of write to a COM-port.
by Marvin 24 Oct '13

24 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3038 Your paranoid android. === w2008s64 (64 bit comm) === comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting === w7pro64 (64 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1552: test_AbortWaitCts timeout 500 handle 0000000000000068 comm.c:1519: Changing CommMask on the fly for handle 0000000000000068 after timeout 500

1 0

Re: [PATCH 5/5] d3d8/tests: Port z_range_test to d3d8.
by Marvin 24 Oct '13

24 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3034 Your paranoid android. === w864 (32 bit visual) === visual.c:1619: Test failed: Failed to create vertex shader, hr 0x8876086c. visual.c:1649: Test failed: Failed to delete vertex shader, hr 0x8876086c. visual.c:1657: Test failed: Z range failed: Got color 0x00ffffff, expected 0x00ff0000. visual.c:1664: Test failed: Z range failed: Got color 0x00ffffff, expected 0x000000ff. visual.c:1666: Test failed: Z range failed: Got color 0x00ffffff, expected 0x000000ff.

1 0