October 2013 - Wine-devel - list.winehq.org

Re: [5/7] oleaut32/tests: Fix typelib tests compilation with __WINESRC__ defined
by Dmitry Timoshkov 24 Oct '13

24 Oct '13

André Hentschel <nerv(a)dawncrow.de> wrote: > - ok(lstrcmp(value, buf) == 0, #expr " expected \"%s\" got \"%s\"\n", value, buf); \ > + ok(lstrcmpA(value, buf) == 0, #expr " expected \"%s\" got \"%s\"\n", value, buf); \ Using simple strcmp() should be preferrable, leaving lstr* versions only for cases when an exception handler is really needed. P.S. Fixing compilation with __WINESRC__ defined gives an opportunity for reviewing the code, this should not be a simple search and replace job. -- Dmitry.

1 0

Re: winspool.drv/tests: Fix tests compilation with __WINESRC__ defined
by Dmitry Timoshkov 24 Oct '13

24 Oct '13

André Hentschel <nerv(a)dawncrow.de> wrote: > @@ -3018,28 +3018,28 @@ START_TEST(info) > test_ConfigurePort(); > test_DeleteMonitor(); > test_DeletePort(); > - test_DeviceCapabilities(); > - test_DocumentProperties(); > + test_DeviceCapabilitiesA(); > + test_DocumentPropertiesA(); > test_EnumForms(NULL); > if (default_printer) test_EnumForms(default_printer); > test_EnumMonitors(); > - test_EnumPorts(); > + test_EnumPortsA(); > test_EnumPrinterDrivers(); > test_EnumPrinters(); > test_EnumPrintProcessors(); > test_GetDefaultPrinter(); > test_GetPrinterDriverDirectory(); > test_GetPrintProcessorDirectory(); > - test_OpenPrinter(); > - test_GetPrinter(); > + test_OpenPrinterA(); > + test_GetPrinterA(); > test_GetPrinterData(); > test_GetPrinterDataEx(); > - test_GetPrinterDriver(); > + test_GetPrinterDriverA(); > test_SetDefaultPrinter(); > test_XcvDataW_MonitorUI(); > test_XcvDataW_PortIsValid(); > test_IsValidDevmodeW(); > - test_OpenPrinter_defaults(); > + test_OpenPRINTER_DEFAULTSA(); Please leave the test names intact, that assumes that adding tests for W version of an API doesn't need a separate body. -- Dmitry.

1 0

Re: winspool.drv/tests: Fix tests compilation with __WINESRC__ defined
by Marvin 24 Oct '13

24 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2988 Your paranoid android. === w864 (32 bit info) === info.c:2925: Test failed: got 0 info.c:2931: Test failed: got 0 info: unhandled exception c0000005 at 0040B246 === w864 (64 bit info) === info.c:2934: Test failed: got NULL DEVMODEA info: unhandled exception c0000005 at 00000000004099CD

1 0

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.
by Phil Krylov 24 Oct '13

24 Oct '13

Thanks! Do you consider adding an option to stop interpreting Command as Alt? On Thu, Oct 10, 2013 at 1:30 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/cocoa_window.m | 22 ++++++++++++++++++++-- > dlls/winemac.drv/macdrv_cocoa.h | 2 ++ > dlls/winemac.drv/macdrv_main.c | 7 +++++++ > 3 files changed, 29 insertions(+), 2 deletions(-) > > > > -- С уважением, Филипп Крылов.

2 5

Re: [PATCH 2/6] user32: Implement OpenInputDesktop.
by Alexandre Julliard 23 Oct '13

23 Oct '13

Qian Hong <qhong(a)codeweavers.com> writes: > Hello, > > This patch superseded patch 99498. > Thanks Vincent Povirk for the previous comment, now I try to implement > OpenInputDesktop in user32 and server. I don't think that makes sense, under Wine every desktop is potentially an input desktop, there's no way to decide which one is the "real" one. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/2] user32: Implement OpenInputDesktop.
by Marvin 23 Oct '13

23 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2978 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ole32: Support activation context in CLSIDFromProgID()
by Alexandre Julliard 23 Oct '13

23 Oct '13

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Support activation context in CLSIDFromProgID() It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M msi.dll -p msi_test.exe.so msi.c && touch msi.ok msi.c:1974: Test failed: expected 0xdeadbeef, got 14007 msi.c:1981: Test failed: expected 0xdeadbeef, got 14007 msi.c:1988: Test failed: expected 0xdeadbeef, got 14007 msi.c:2003: Test failed: expected 0xdeadbeef, got 14007 msi.c:2506: Test failed: expected 0xdeadbeef, got 14007 msi.c:2515: Test failed: expected 0xdeadbeef, got 14007 make: *** [msi.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] ddraw/tests: Test DDSCAPS2_D3DTEXTUREMANAGE.
by Marvin 23 Oct '13

23 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2973 Your paranoid android. === w864 (32 bit ddraw7) === No test summary line found Failure running script in VM: network read timed out === w864 (64 bit ddraw7) === ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 4. ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 5. ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 6. ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 7. === w864 (32 bit ddraw4) === The test timed out

1 0

Re: [PATCH 1/3] ddraw/tests: Add surface lockability tests.
by Marvin 23 Oct '13

23 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2972 Your paranoid android. === w864 (32 bit ddraw2) === The test timed out === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 0041212F === w864 (32 bit ddraw7) === Timeout Failure running script in VM: network read timed out === w864 (64 bit ddraw7) === ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 2. ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 3. ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 4. === w864 (32 bit ddraw4) === Failure running script in VM: network read timed out

2 1

Re: [23/23] user32/tests: Enable user32 tests compilation with __WINESRC__ defined.
by Marvin 23 Oct '13

23 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2971 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0