November 2013 - Wine-devel - list.winehq.org

Re: First try to sync translations with Transifex.com
by Francois Gouget 25 Nov '13

25 Nov '13

The attachment seems to have been mangled: when I looked at it here I only got question marks in the translations. So unless the mangling only happened here, that would be one reason why the patch has not been applied. Also, although the translation comes from Transifex.com, it looks like you're the only author behind the changes in that patch, i.e. there's presumably no copyright attribution issue. That may be worth noting in the patch submission. Could you resubmit your patch? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

2 1

Re: [PATCH 3/5] wined3d: Get rid of surface_set_dirty().
by Stefan Dösinger 25 Nov '13

25 Nov '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-11-25 12:31, schrieb Henri Verbeet: > static void texture2d_sub_resource_add_dirty_region(struct > wined3d_resource *sub_resource, const struct wined3d_box > *dirty_region) { - > surface_set_dirty(surface_from_resource(sub_resource)); + struct > wined3d_surface *surface = surface_from_resource(sub_resource); + + > surface_load_location(surface, SFLAG_INSYSMEM); + > surface_invalidate_location(surface, ~SFLAG_INSYSMEM); } Why not something like if (surface->flags & SFLAG_INSYSMEM) surface_invalidate_location(surface, ~SFLAG_INSYSMEM); If the surface doesn't have SFLAG_INSYSMEM set already downloading texture / framebuffer data to sysmem and re-uploading it won't do anything. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSk0bMAAoJEN0/YqbEcdMw1rkP/R4WwqON6LvqMeZo1p37QJnA FmSC16ChtjbraQEJU9BkAbFZJCn1U8jiEybeUl3aayf3T5/OL+tk1eAbuUovuHtf LnOgCL8gHxUitao9kwPgM5gO4gwzo4IfT/kHKZ9/gu1FxqvHZGk/5khgXU67mAJ0 pp3SOhWPTbWu23k/ld6CQvp47DcFbEWoSn3n+20npv2OYGvmcUgVumW8EZIHhN8g EFou2wEKVoeEVyaPZzo85Cauv/nwyvwzJgZAgnRj5cokOu0AEpitf8jTqp2mXq6E V0ozMW5X40l6GkmrsVbHYoEhD6l+cX3Mf30b3WttHUrSd2XHDFqUHs8yONK/KxsV 7VT4zsh8vhWSqQFLp3e7ygNiryojHTBy9gC0eC5ahK9bbjkPpvHIrbj9+sHh58rP GXwAsLcxBLS0FofB2tk6zOYMILhRKWX6PhlldvsZVqvIN0mdAR/NTMoOyre7kxGf pCt/o8yXQZY/ujq3ZoKUXSjzFcV2ilhJq1EoiixCXR+X23Ge3s5WDfnPPe8QWeIZ Bl1wfVHtl9PQPL8Q5kb2g9xr572+J+HPLthT1kz73jHZ6VKSE3xN/c0vW3zzdfaJ OZRWfzmPOcAk+RqQUD3Ko2T7j/voLUH9sU3MD4FtPLfKKsOne4OMstt4VIQ/Qe5k tpOd6QkmBeS0Wq4mHywu =MNOz -----END PGP SIGNATURE-----

2 4

Re: [website] Portuguese translation for release 1.7.7
by Bruno Jesus 25 Nov '13

25 Nov '13

2013/11/25 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013112201.xml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 news/pt/2013112201.xml > > diff --git a/news/pt/2013112201.xml b/news/pt/2013112201.xml > new file mode 100644 > index 0000000..3fbff21 > --- /dev/null > +++ b/news/pt/2013112201.xml > @@ -0,0 +1,15 @@ > +<news> > +<date>22 de Novembro de 2013</date> > +<title>Wine 1.7.7 lançado</title> > +<body> > + A versão de desenvolvimento 1.7.7 já está disponível agora. > + <a href="{$root}/announce/1.7.7">Novidades</a> desta versão: > +<ul> > + <li>Suporte a configuração de comportilhamente remote usando a biblioteca NetAPI do Samba.</li> The word "remote" was not translated. > + <li>Suporte a múltiplos layouts de teclado no driver de Mac.</li> > + <li>Melhor suporte a uso embutido com XEMBED.</li> > + <li>Suporte a arrays em VBScript.</li> > + <li>Várias correções de bugs.</li> > +O código fonte está <a href="http://prdownloads.sourceforge.net/wine/wine-1.7.7.tar.bz2">disponível agora</a>. > +Pacotes binários estão em processo de construção e irão aparecer em breve em suas respectivas <a href="{$root}/download">sessões da área de downloads</a>. > +</body></news> > -- > 1.7.10.4 Best wishes, Bruno

1 0

Re: mshtml: Ignore QI(&IID_IWebBrowserPriv2IE8XP) calls.
by Marvin 25 Nov '13

25 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3537 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found === w8 (32 bit htmldoc) === htmldoc.c:2872: Test failed: unexpected command 74

1 0

Re: [PATCH 2/5] qmgr: Implement IBackgroundCopyJob::GetDescription()
by Dmitry Timoshkov 25 Nov '13

25 Nov '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT return_strval(const WCHAR *str, WCHAR **ret) > +{ > + int len; > + > + if (!ret) return E_INVALIDARG; > + > + len = strlenW(str); > + *ret = CoTaskMemAlloc((len+1)*sizeof(WCHAR)); > + if (!*ret) return E_OUTOFMEMORY; > + > + if (len) > + strcpyW(*ret, str); > + else > + **ret = 0; > + return S_OK; > +} > + > static inline BackgroundCopyJobImpl *impl_from_IBackgroundCopyJob2(IBackgroundCopyJob2 *iface) > { > return CONTAINING_RECORD(iface, BackgroundCopyJobImpl, IBackgroundCopyJob2_iface); > @@ -313,17 +330,10 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_GetDisplayName( > LPWSTR *pVal) > { > BackgroundCopyJobImpl *This = impl_from_IBackgroundCopyJob2(iface); > - int n; > > - if (!pVal) > - return E_INVALIDARG; > + TRACE("(%p)->(%p)\n", This, pVal); > > - n = (strlenW(This->displayName) + 1) * sizeof **pVal; > - *pVal = CoTaskMemAlloc(n); > - if (*pVal == NULL) > - return E_OUTOFMEMORY; > - memcpy(*pVal, This->displayName, n); > - return S_OK; > + return return_strval(This->displayName, pVal); > } What is the reason of changing pVal type from LPWSTR* to WCHAR** in the helper? Leaving would LPWSTR* make it more clear IMO what the helper is supposed to do and would simplify dereferencing logic a bit. Also moving the parameter checks from the callers to helper doesn't look justified IMO. -- Dmitry.

2 1

Re: quartz/tests: Add tests for IVMRMonitorConfig and IVMRMonitorConfig9 interface (try 2)
by Nikolay Sivov 25 Nov '13

25 Nov '13

On 11/25/2013 10:23, Sebastian Lackner wrote: > + hr = CoCreateInstance(&CLSID_VideoRenderer, NULL, CLSCTX_INPROC_SERVER, > + &IID_IUnknown, (LPVOID*)&pVideoRenderer); > + ok(hr != S_OK || pVideoRenderer != NULL, "CoCreateInstance returned S_OK, but pVideoRenderer is NULL.\n"); > + if (hr != S_OK || !pVideoRenderer) > + { > + skip("VideoRenderer is not available, skipping QI test.\n"); > + return; > + } > + > QI_SUCCEED(pVideoRenderer, IID_IBaseFilter, pBaseFilter); > RELEASE_EXPECT(pBaseFilter, 1); It's enough to test for return value, also if wine supports this class this should be win_skip(). What's a point of separate QI here? You could CoCreateInstance with IID_IBaseFilter. > + hr = IUnknown_QueryInterface(pVMR7, &IID_IVMRMonitorConfig, (LPVOID*)&pMonitorConfig); > + ok(hr == S_OK, "IUnknown_QueryInterface returned %x.\n", hr); > + ok(pMonitorConfig != NULL, "pMonitorConfig is NULL.\n"); > + if (!pMonitorConfig) goto out; Is it really possible to fail here? > + ok(info[numdev].guid.pGUID != &info[numdev].guid.GUID || memcmp(&info[numdev].guid.GUID, &max_guid, sizeof(max_guid)) != 0, > + "GetAvailableMonitors returned info[%d].GUID = {FFFFFFFF-FFFF-FFFF-FFFF-FFFFFFFFFFFF}, expected any other value.\n", numdev); It's shorter to just print resulting guid. > + /* check that result is filled out, we do not check if the values actually make any sense */ > + while (numdev--) > + { > + ok(info[numdev].uDevID != (UINT)-1, > + "GetAvailableMonitors returned info[%d].uDevID = -1, expected != -1.\n", numdev); > + ok(memcmp(&info[numdev].rcMonitor, &max_rect, sizeof(max_rect)) != 0, > + "GetAvailableMonitors returned info[%d].rcMonitor = {-1, -1, -1, -1}, expected any other value.\n", numdev); > + ok(info[numdev].hMon != (HMONITOR)0 && info[numdev].hMon != (HMONITOR)-1, > + "GetAvailableMonitors returned info[%d].hMon = %p, expected != 0 and != -1.\n", numdev, info[numdev].hMon); > + ok(info[numdev].dwFlags != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwFlags = -1, expected != -1.\n", numdev); > + ok(info[numdev].szDevice[0] != 0 && info[numdev].szDevice[0] != (WCHAR)-1, > + "GetAvailableMonitors returned info[%d].szDevice[0] = %d, expected != 0 and != -1.\n", numdev, info[numdev].szDevice[0]); > + todo_wine ok(info[numdev].szDescription[0] != 0 && info[numdev].szDescription[0] != (WCHAR)-1, > + "GetAvailableMonitors returned info[%d].szDescription[0] = %d, expected != 0 and != -1.\n", numdev, info[numdev].szDescription[0]); > + ok(info[numdev].dwVendorId != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwVendorId = -1, expected != -1.\n", numdev); > + ok(info[numdev].dwDeviceId != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwDeviceId = -1, expected != -1.\n", numdev); > + ok(info[numdev].dwSubSysId != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwSubSysId = -1, expected != -1.\n", numdev); > + ok(info[numdev].dwRevision != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwRevision = -1, expected != -1.\n", numdev); > + } Personally I don't like this, I think this should be more explicit - set fields separately to some invalid value that shouldn't happen and check it back. For example for string field it makes no sense setting it to -1 if it's always filled.

1 0

Re: vbscript: Added support for VT_BYREF|VT_VARIANT to to_int.
by Marvin 22 Nov '13

22 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3510 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [2/3] wininet: Reset data stream for existing request connections.
by Marvin 22 Nov '13

22 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3506 Your paranoid android. === w2008s64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0

1 0

Re: [1/3] wininet/tests: Test successive HttpSendRequest calls.
by Marvin 22 Nov '13

22 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3505 Your paranoid android. === w7pro64 (32 bit http) === http.c:4450: Test failed: HttpSendRequest failed: 12057 http.c:4455: Test failed: expected secure flag to be set === w2008s64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0

1 0

Re: msvcrt: return wall-clock time from clock()
by Alexandre Julliard 22 Nov '13

22 Nov '13

Daniel Lehman <dlehman(a)esri.com> writes: > @@ -709,19 +711,26 @@ int CDECL _wstrtime_s(MSVCRT_wchar_t* time, MSVCRT_size_t size) > */ > MSVCRT_clock_t CDECL MSVCRT_clock(void) > { > - FILETIME ftc, fte, ftk, ftu; > - ULONGLONG utime, ktime; > - > - MSVCRT_clock_t clock; > + static LONGLONG start_time; > + LONGLONG current_time; > + struct timeval now; > > - GetProcessTimes(GetCurrentProcess(), &ftc, &fte, &ftk, &ftu); > + if(!start_time) { > + KERNEL_USER_TIMES pti; > > - ktime = ((ULONGLONG)ftk.dwHighDateTime << 32) | ftk.dwLowDateTime; > - utime = ((ULONGLONG)ftu.dwHighDateTime << 32) | ftu.dwLowDateTime; > + /* while Linux's clock returns user time, Windows' clock > + * returns wall-clock time from process start. cache the > + * process start time since it won't change and to avoid > + * wineserver round-trip overhead */ > + if(NtQueryInformationProcess(GetCurrentProcess(), ProcessTimes, &pti, sizeof(pti), NULL)) > + return -1; > + start_time = pti.CreateTime.QuadPart; > + } > > - clock = (utime + ktime) / (TICKSPERSEC / MSVCRT_CLOCKS_PER_SEC); > + gettimeofday(&now, NULL); > + current_time = (LONGLONG)now.tv_sec * TICKSPERSEC + now.tv_usec * 10 + TICKS_1601_TO_1970; You should be using Windows APIs for this, not gettimeofday. -- Alexandre Julliard julliard(a)winehq.org

1 0