November 2013 - Wine-devel - list.winehq.org

Re: [PATCH] ddraw: add dsurface dimension tests, try 3
by Henri Verbeet 22 Nov '13

22 Nov '13

Stefan already mentioned this, although perhaps not quite as explicit, but new ddraw tests need to go to ddraw1-7.c. In this specific case, the best option is probably to first move SizeTest() over to ddraw1-7.c (and rename it to test_surface_size(), fix minor style issues etc.), and then add the new tests after that.

1 0

Re: gdiplus: Implement GdipCreateRegionRgnData. Take 2.
by Alexandre Julliard 22 Nov '13

22 Nov '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the patch follows Windows behaviour by refusing to create > an empty path in a region, and marks the test as broken when some Windows > versions fail to properly clear an aligned DWORD. > --- > dlls/gdiplus/region.c | 219 ++++++++++++++++++++++++++++++++++++++++---- > dlls/gdiplus/tests/region.c | 65 +++++++++++++ > 2 files changed, 266 insertions(+), 18 deletions(-) > > diff --git a/dlls/gdiplus/region.c b/dlls/gdiplus/region.c > index 832ce69..bc625f5 100644 > --- a/dlls/gdiplus/region.c > +++ b/dlls/gdiplus/region.c > @@ -76,6 +76,28 @@ WINE_DEFAULT_DEBUG_CHANNEL(gdiplus); > #define FLAGS_NOFLAGS 0x0 > #define FLAGS_INTPATH 0x4000 > > +struct _memory_buffer > +{ > + const BYTE *buffer; > + INT size, pos; > +}; > + > +struct _region_header > +{ > + DWORD size; > + DWORD checksum; > + DWORD magic; > + DWORD num_children; > +}; > + > +struct _path_header > +{ > + DWORD size; > + DWORD magic; > + DWORD count; > + DWORD flags; > +}; There's no need to add leading underscores, it's obvious that these are not Windows types. -- Alexandre Julliard julliard(a)winehq.org

4 10

__wine_spec_nt_header: relocation truncated to fit: R_386_PC16 against undefined symbol
by Gerald Pfeifer 22 Nov '13

22 Nov '13

My last two nightly boostraps on FreeBSD have started to fail as follows: ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./sound.drv16.spec -m16 -Wb,--main-module,winmm.dll sound.o -o sound.drv16.so -lwine ../../libs/port/libwine_port.a -L/home/gerald/10-i386/lib sound.drv16-5l5JpE.spec.o: In function `__wine_spec_nt_header': (.data+0x48c): relocation truncated to fit: R_386_PC16 against undefined symbol `.L__wine_spec_callfrom16_p_long_' collect2: error: ld returned 1 exit status winegcc: /home/gerald/gcc-ref10-i386/bin/gcc failed gmake: *** [sound.drv16.so] Error 2 Originally I thought this was the top of tree nightly GCC builds I am using, but today I also go it with GCC 4.8.3 20131121 (prerelease). Any ideas what might be going on here? Any tips how to best debug this? Gerald

1 0

Re: mscoree: Implement IMetahostPolicy GetRequestedRuntime
by Vincent Povirk 21 Nov '13

21 Nov '13

+ else if(pwzBinary && lstrlenW(pwzBinary) > 0) Did you really need the check for an empty string? This is making me wonder if my comment on bugzilla was wrong, and get_runtime_info should treat an empty string the same as NULL.

1 0

Re: wininet: Reading past end-of-file in chunked mode returns success.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3497 Your paranoid android. === w2008s64 (64 bit http) === http.c:3525: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3525: Test failed: HttpQueryInfo failed 0

1 0

Re: xcopy: Add tests to show that the /D option only accepts dates in the m-d-y format.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3495 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: [2/3] wininet: Reset data stream for existing request connections.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3494 Your paranoid android. === w2008s64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0

1 0

Re: [1/3] wininet/tests: Test successive HttpSendRequest calls. (try 2)
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3493 Your paranoid android. === w2008s64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0

1 0

Re: po: xcopy expects a date in the French locale format for the /D option.
by Francois Gouget 21 Nov '13

21 Nov '13

On Thu, 21 Nov 2013, Francois Gouget wrote: > --- > > Of course Wine does not yet implement the /D option but when it does it > will have to match the Windows implementation so the documentation > might as well be correct from the start. Please ignore this patch. On Windows XP and 7 alike Microsoft's xcopy does say: | /D:j-m-a Copie les fichiers modifiés à partir de la date spécifiée But on both systems it refuses a date of 21-11-2013 but accepts 11-21-2013. So once more the Microsoft documentation is wrong. c:\Users\win7admin\Documents> xcopy /D:21-11-2013 *.* tmp Paramètre non valide - /D:21-11-2013 c:\Users\win7admin\Documents> xcopy /D:21-11-2013 *.* tmp c:foo 1 fichier(s) copié(s) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If it stinks, it's chemistry. If it moves, it's biology. If it does not work, it's computer science.

1 0

Re: [PATCH 2/2] winemac: Add support for a DisableWindowDecorations registry setting.
by Alexandre Julliard 21 Nov '13

21 Nov '13

Ken Thomases <ken(a)codeweavers.com> writes: > @@ -166,6 +167,9 @@ static void setup_options(void) > if (!get_config_key(hkey, appkey, "AllowSoftwareRendering", buffer, sizeof(buffer))) > allow_software_rendering = IS_OPTION_TRUE(buffer[0]); > > + if (!get_config_key(hkey, appkey, "DisableWindowDecorations", buffer, sizeof(buffer))) > + disable_window_decorations = IS_OPTION_TRUE(buffer[0]); > + Disable-style options should be avoided, the double negatives are confusing for users. Also using the same option name as the X11 driver for the same feature may be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0