February 2013 - Wine-devel - list.winehq.org

Re: make_xftmpl: Explicitly use signed char when appropriate
by Alexandre Julliard 11 Feb '13

11 Feb '13

André Hentschel <nerv(a)dawncrow.de> writes: > For platforms where char is expected to be unsigned (e.g. it fixes a warning on ARM) There's no reason to make it signed. Please fix the bug correctly instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: windowscodecsext: Implement WICCreateColorTransform_Proxy and IWICColorTransform_Initialize_Proxy.
by Vincent Povirk 11 Feb '13

11 Feb '13

OK, I'm about to say something weird, and I'll understand if everyone else decides to ignore it. I don't think WICCreateColorTransform_Proxy, or any of the Proxy functions, should initialize or make use of COM. Instead, I think it should work by calling WICCreateImagingFactory_Proxy. I suspect that part of the purpose of the _Proxy functions is to make it possible to use WIC without needing COM at all, which is something we may want in the future if we want to use it from user32. (Another consequence of this is that we should be able to create instances of builtin decoders/encoders without COM, which we currently can't do. But I'd have to write a test for that, and currently there's been no demonstrated need for it.)

1 0

Re: winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().
by Johannes Kroll 11 Feb '13

11 Feb '13

On Thu, 24 Jan 2013 10:33:58 +0100 <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > Compare with wineoss which uses poll <= 0 already... > > Johannes Kroll mentioned that MIDIIn takes a long time to end. > Indeed, our testsuite ran 3 times into the "kill after 5s" timeout due to this bug. > Now the tests execute much faster. > > Regards, > Jörg höhle Did this patch get through? I don't see it on http://source.winehq.org/patches/ ...

1 0

Re: windowscodecsext: Implement WICCreateColorTransform_Proxy and IWICColorTransform_Initialize_Proxy.
by Marvin 11 Feb '13

11 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24341 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: winspool.drv: Fallback to cupsGetPPD if cupsGetPPD3 is missing or failed.
by Huw Davies 11 Feb '13

11 Feb '13

On Mon, Feb 11, 2013 at 02:03:26PM +0800, Dmitry Timoshkov wrote: > - if (pcupsGetPPD3) return pcupsGetPPD3( http, name, modtime, buffer, bufsize ); > + if (pcupsGetPPD3) > + { > + http_status_t status; > + > + TRACE( "Calling cupsGetPPD3\n" ); > + status = pcupsGetPPD3( http, name, modtime, buffer, bufsize ); > + if (status == HTTP_OK) return HTTP_OK; > + TRACE("cupsGetPPD3 failed (status %d)\n", status); > + } > Under what conditions does cupsGetPPD succeed if cupsGetPPD3 fails? Huw.

2 2

Re: [2/2] xmllite: Basic test for chunk value read vs full value read
by Marvin 11 Feb '13

11 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24335 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Debugging and steam
by Gediminas Jakutis 11 Feb '13

11 Feb '13

Good day! Does anyone has any experience on dealing with Steam when debugging a game which depends on Steam? I am trying to squash a bug which makes a game crash. I started from relay logs, but have a bit of a problem - calls from Steam itself produce a few megabytes worth of relay logs every second. Those get mixed together with calls originating from the game. Also, it appears the game takes a couple of seconds after that "bad" call before crashing. When it is mixed together with Steam's own spam, it is a nightmare finding where it went wrong. I tried every idea I could muster on how to get a "pure" log of the game. Not a single one turned out to be effective. I am all out of ideas now. So if anyone had to deal with this and found a satisfactory solution, please enlighten me. Thank You in advance! -- Gediminas Jakutis LDK Varčiai www.varciai.lt

2 1

Re: comctl32/listview: fix LVM_SETICONSPACING on 64bit machines
by Marvin 09 Feb '13

09 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24327 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: ole32/tests: Add test for IDispatch interface in IOleObject_QueryInterface.
by Alistair Leslie-Hughes 09 Feb '13

09 Feb '13

On 9/02/2013 2:08 AM, Roman Dadkov wrote: > This test is necessary to show that the function > IOleObject_QueryInterface does not have enough processing IID_IDispatch, > but it works for Windose. Therefore, the creation of some objects in a > variety of applications leads to crash. > + hr = IOleObject_QueryInterface(ole_obj, &IID_IDispatch, (void**)&dispatch); > + todo_wine > + ok(hr == S_OK, "got %08x\n", hr); > The IDispatch Interface should be released. Best Regards Alistair Leslie-Hughes

1 0

Re: ole32/tests: Add test for IDispatch interface in IOleObject_QueryInterface.
by Dmitry Timoshkov 09 Feb '13

09 Feb '13

Roman Dadkov <romand(a)etersoft.ru> wrote: > + const CLSID non_existent_class = {0xa5f1772f, 0x3772, 0x490f, {0x9e, 0xc6, 0x77, 0x13, 0xe8, 0xb3, 0x4b, 0x5d}}; Probably it would be a good idea to try make CLSID really unique and bad enough that it's unlikely that somebody uses it for real. Something like 0xdeadbeef,0xde,0xad,0xbe,0xef,... -- Dmitry.

1 0