February 2013 - Wine-devel - list.winehq.org

Re: [3/5] windowscodecs: Add initializations for tiff encoder options
by Marvin 04 Feb '13

04 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24254 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Keynote made me remember Mac Icons
by Ken Thomases 03 Feb '13

03 Feb '13

Hi, On Feb 3, 2013, at 3:56 AM, Austin English wrote: > On Sun, Feb 3, 2013 at 9:45 AM, Jeremiah Flerchinger > <jeremiah.flerchinger(a)gmail.com> wrote: >> The keynote made me realize I have some Mac icons for Wine. Would anyone be >> interested in them? It's definitely more functional than just using the >> default terminal icon. I also had a winecfg icon somewhere but I can't >> remember where that one is right now. >> >> Let me know and tell me where to send them. > > Ken Thomases (cc'ed) is the person on winemac.drv, though wine-devel > or attaching them to bugzilla would likely be best to preserve a copy > of it. I may be missing some context. What icons is this referring to? Do you mean just the various icons for Wine and its programs (e.g. Notepad) but in ICNS format? I'm not sure yet how useful that will be. Although I haven't gotten this far in my Mac driver patch submissions, the Mac driver will eventually attempt to extract the icon for the current .exe and use that for the application icon of the running process. Not all executables have an icon, though, so in some cases it will still default to the terminal-looking icon. It probably would be better to use Wine's wine-glass icon in that case. However, there's a question of how to deploy the icon. I'm not sure a .icns file is useful. I don't know where such a .icns file would be kept and how it would be located relative to the Wine installation (or build directory, if running from there). So, it may just be easiest to embed a Windows ICO resource into the Mac driver .so file and extract it at runtime just like the code will extract the icon from the .exe file. So, thanks for the offer and I'll keep it in mind, but at this point I'm not sure what I would do with Mac icons for Wine. -Ken

2 1

Support for game DRM which overwrite the GS segment selector
by Alessandro Pignotti 03 Feb '13

03 Feb '13

Hi everyone, I'm trying to get a specific game which employs a seemingly custom protection scheme to work. The DRM does various bad things as usual, but a very bad one is manipulating to GS segment selector and setting it to a NULL segment. The GS segment is used by libc though in various ways (stack protection and syscall support, and probably others). I managed to get the activation procedure to go further and further by enclosing each offending syscall using the following 2 macros. #define SAFE_GS_START \ do { \ wine_set_gs(ntdll_get_thread_data()->gs); \ do #define SAFE_GS_END \ while(0); \ } while(0) Still, this method is very cumbersome since system calls happens in many places even outside of ntdll. Fixing the GS is also needed to support sigsetjmp which is used by wine's exception handling. I'd like to ask for feedback about what would be a sane way of supporting this application. A possible solution would be to modify wine's segfault handler to check if the instruction has a GS prefix (0x65 IIRC) and try to execute the instruction again after fixing the GS. Please keep me in CC since I'm not subscribed to the ML. Regards, Alessandro Pignotti

2 3

Re: fusion: return correct error for null public token
by Nikolay Sivov 03 Feb '13

03 Feb '13

> + ok(hr == FUSION_E_PRIVATE_ASM_DISALLOWED, "Expected S_OK, got %08x\n", hr); You could just strip excepted value message part to avoid typos like that. On Fri, Feb 1, 2013 at 8:10 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > The other fusion patch is superseded by this one. > > Changelog: > fusion: return correct error for null public token > > > Best Regards > Alistair Leslie-Hughes > > > > > >

1 0

Re: [PATCH] cryptui: use add_oid_to_usage correctly (Coverity)
by Juan Lang 02 Feb '13

02 Feb '13

Hi Marcus, - add_oid_to_usage(usage, ptr); + usage = add_oid_to_usage(usage, ptr); This looks fine, but would you mind making the same change on line 337? Thanks, --Juan

2 3

Re: kernel32/tests : added tests for copyfileex try7
by Marvin 01 Feb '13

01 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24239 Your paranoid android. === WNT4WSSP6 (32 bit path) === path: unhandled exception c0000005 at 00000000

1 0