February 2013 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] winmm: MCI_BREAK_HWND handling now matches Wine's 1999 MCI_DefYieldProc.
by Alexandre Julliard 05 Mar '13

05 Mar '13

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > @@ -2063,9 +2063,10 @@ static DWORD MCI_Break(UINT wDevID, DWORD dwFlags, LPMCI_BREAK_PARMS lpParms) > switch (dwFlags & (MCI_BREAK_KEY | MCI_BREAK_OFF)) { > case MCI_BREAK_KEY: > wmd->lpfnYieldProc = MCI_DefYieldProc; > - wmd->dwYieldData = lpParms->nVirtKey; > - if (dwFlags & MCI_BREAK_HWND) > - FIXME("(%x) vkey %02X on window %p\n", dwFlags, lpParms->nVirtKey, lpParms->hwndBreak); > + /* Our MCI_DefYieldProc from 1999-04-11 expects this DWORD splitting, > + * yet tests on w2k-w7 prove wmd->dwYieldData = lpParms->nVirtKey; */ It doesn't make sense to add workarounds for Wine code, it should be fixed instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Use accented letters in their names.
by Tae Wong 04 Mar '13

04 Mar '13

You will want to use accented letters in their authors names. Caolan McNamara Ferenc Wagner Marko Nikolic Every once and a while the GNOME Live website is down with an error on Netscape called “The operation timed out when attempting to contact .” - This paragraph should have a website name. You want to be unbanned in Amaterasu Translations and the DOS ain’t dead forums.

2 2

Re: gdiplus: GdipDrawString should handle alignment in both directions same way.
by Vincent Povirk 28 Feb '13

28 Feb '13

> - if (format) halign = format->align; > - else halign = StringAlignmentNear; > - How are you handling the case where format is NULL?

1 1

GSoC 2013 guidelines.
by Tejas Nikumbh 28 Feb '13

28 Feb '13

Hi, I am Tejas Nikumbh, an undergrad at Indian Institute of Technology Bombay. I will be participating in GSoC this year. [GSoC 2013]. In order to imporve my chances for getting selected this year, I would like to start contributing early on to Open Source development via Wine. Here's a little background info : *Languages proficient in : *Java, Python, Javascript [+jQuery] , HTML[+HTML5 Canvas], CSS [+CSS3]. C++ should be on the list soon. *CS Theory :* Discrete Math, Probablity and Random Processes, Data Structures and Algorithms. *SVN : *Github, Mercurial . *Basic Machine learning [Regression algos and some classification algos]* Based on the above info, are there any projects which might suit me? Also, Picking up something reasonable quickly shouldn't be a problem. Thanks, -- Tejas Nikumbh, Third Year Undergraduate, Electrical Engineering Department, IIT Bombay.

1 0

Re: ieframe: Fixed QI tests on IE10, where IStdMarshalInfo is supported by WebBrowser object.
by Marvin 28 Feb '13

28 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24550 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === Timeout === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3041: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: msvcrt/tests: Mark win8 behaviour as broken (try 2)
by Marvin 27 Feb '13

27 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24548 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Fix name order in the authors file.
by Tae Wong 27 Feb '13

27 Feb '13

You’ve found Kazuyuki Sato in inverted name order. Apostrophes on the O-section are not ignored. O'Callahan, Robert O'Neill, Damien O'Regan, Mike Oberhumer, Stefan Oberndorfer, Peter Ogburn, Walt Ognyanoff, Damyan Olsen, Henrik Olsen, Magnus Olson, Roger Olver, Neil Ortiz, Jose Manuel Ferrer Osmundsen, Knut St. It should be ignored so the section should be sorted as: Oberhumer, Stefan Oberndorfer, Peter O'Callahan, Robert Ogburn, Walt Ognyanoff, Damyan Olsen, Henrik Olsen, Magnus Olson, Roger Olver, Neil O'Neill, Damien O'Regan, Mike Ortiz, Jose Manuel Ferrer Osmundsen, Knut St.

1 0

Re: d3dx9: Avoid expensive computations
by Rico Schüller 27 Feb '13

27 Feb '13

On 25.02.2013 06:03, Nozomi Kodama wrote: > + out.u.m[2][i] = v.z / signed_det; > + out.u.m[3][i] = v.w / signed_det; > } > > *pout = out; While you are at it, you may fix the indentation of out*, "}", "*pout = out;" and "return pout;". > signed_det = (i % 2)? -det: det; Couldn't you just use something like "det = -det;" instead of the modulo? This should be a little bit faster. I did some small tests for speed with the following results. You may also avoid such a lot of variable assignments like *pout = out and you may use 4 vecs instead. This should save ~48 assignments and it should also improve the speed a bit more (~10%). Though, native is still 40% faster than that. With the change above it should look like: int i; D3DXVECTOR4 v, vec[4]; FLOAT det; ... for (i = 0; i < 4; i++) { vec[i].x = pm->u.m[i][0]; vec[i].y = pm->u.m[i][1]; vec[i].z = pm->u.m[i][2]; vec[i].w = pm->u.m[i][3]; } for (i = 0; i < 4; i++) { switch (i) { case 0: D3DXVec4Cross(&v, &vec[1], &vec[2], &vec[3]); break; case 1: D3DXVec4Cross(&v, &vec[0], &vec[2], &vec[3]); break; case 2: D3DXVec4Cross(&v, &vec[0], &vec[1], &vec[3]); break; case 3: D3DXVec4Cross(&v, &vec[0], &vec[1], &vec[2]); break; } pout->u.m[0][i] = v.x / det; pout->u.m[1][i] = v.y / det; pout->u.m[2][i] = v.z / det; pout->u.m[3][i] = v.w / det; det = -det; } return pout; Maybe we could reuse some calculations from the D3DXVec4Cross function ... Cheers Rico

5 7

Re: secur32: Report SecPkgContext_ConnectionInfo in bits, not bytes.
by Marvin 27 Feb '13

27 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24544 Your paranoid android. === W2KPROSP4 (32 bit schannel) === schannel.c:762: Test failed: conn_info.dwHashStrength = 128 === WXPPROSP3 (32 bit schannel) === schannel.c:762: Test failed: conn_info.dwHashStrength = 128 === W2K3R2SESP2 (32 bit schannel) === schannel.c:762: Test failed: conn_info.dwHashStrength = 128

1 0

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use.
by Michael Stefaniuc 27 Feb '13

27 Feb '13

Hello Joerg, On 02/27/2013 02:46 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > The idea to replace X * numerator / denominator > by X / den * mul + remainder from euclidian division > came from can you please use an inline function for that? > http://blog.airsource.co.uk/index.php/2010/03/15/quelle-heure-est-il/ thanks bye michael

1 0