April 2013 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] winspool.drv/tests: Add DocumentProperties test with empty pDeviceName.
by Marvin 03 Apr '13

03 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24941 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.
by Marcus Meissner 03 Apr '13

03 Apr '13

Hi, I have one concern ... Licensing. GNUTLS is (L)GPLv3+ these days. Wine will now turn into a LPGLv3+ licensed binary (not the sources, just the binaries will turn into it implicitly by linking against gnutls 3). Ciao, Marcus On Wed, Apr 03, 2013 at 02:06:09PM +0200, Jacek Caban wrote: > --- > configure.ac | 13 ------------- > 1 file changed, 13 deletions(-) > > > diff --git a/configure.ac b/configure.ac > index d8f2e8d..080e961 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -66,8 +66,6 @@ AC_ARG_WITH(openal, AS_HELP_STRING([--without-openal],[do not use OpenAL]), > AC_ARG_WITH(opencl, AS_HELP_STRING([--without-opencl],[do not use OpenCL]), > [if test "x$withval" = "xno"; then ac_cv_header_CL_cl_h=no; ac_cv_header_OpenCL_opencl_h=no; fi]) > AC_ARG_WITH(opengl, AS_HELP_STRING([--without-opengl],[do not use OpenGL])) > -AC_ARG_WITH(openssl, AS_HELP_STRING([--without-openssl],[do not use OpenSSL]), > - [if test "x$withval" = "xno"; then ac_cv_header_openssl_err_h=no; ac_cv_header_openssl_ssl_h=no; fi]) > AC_ARG_WITH(osmesa, AS_HELP_STRING([--without-osmesa],[do not use the OSMesa library])) > AC_ARG_WITH(oss, AS_HELP_STRING([--without-oss],[do not use the OSS sound support])) > AC_ARG_WITH(png, AS_HELP_STRING([--without-png],[do not use PNG]), > @@ -469,8 +467,6 @@ AC_CHECK_HEADERS(\ > netinet/in_systm.h \ > netinet/tcp.h \ > netinet/tcp_fsm.h \ > - openssl/err.h \ > - openssl/ssl.h \ > png.h \ > poll.h \ > port.h \ > @@ -1604,15 +1600,6 @@ fi > WINE_NOTICE_WITH(fontconfig,[test "x$ac_cv_lib_soname_fontconfig" = "x"], > [fontconfig ${notice_platform}development files not found, fontconfig won't be supported.]) > > -dnl **** Check for SSL **** > -if test "$ac_cv_header_openssl_err_h" = "yes" -a "$ac_cv_header_openssl_ssl_h" = "yes" > -then > - WINE_CHECK_SONAME(ssl,SSL_library_init) > - WINE_CHECK_SONAME(crypto,BIO_new_socket) > -fi > -WINE_WARNING_WITH(openssl,[test "x$ac_cv_lib_soname_ssl" = "x" -o "x$ac_cv_lib_soname_crypto" = "x"], > - [OpenSSL ${notice_platform}development files not found, SSL won't be supported.]) > - > dnl **** Check for gsm codec **** > if test "$ac_cv_header_gsm_h" = "yes" -o "$ac_cv_header_gsm_gsm_h" = "yes" > then > >

1 1

Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)
by Nikolay Sivov 03 Apr '13

03 Apr '13

On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina <tatyana(a)etersoft.ru> wrote: > Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value > pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that?

2 1

Re: ieframe: Added GoForward tests.
by Marvin 03 Apr '13

03 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24939 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3065: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Hi Res Icons
by Joel Holdsworth 03 Apr '13

03 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Alexandre (+ Others), I notice you've been working on hi-res icons. I just have a couple of comments to chip in. So 2 years ago when I was doing the wine icon refresh, I decided not to try and tackle the problem of hi-res icons. Just getting the normal sized icons merged had proved to be a gargantuan task that took me over a year to complete - I didn't have the stomach to embark on another round of artwork. We also didn't support PNG icons in those days. As you can see in these hi-res icon patches, scaling icons is never as simple as people think. http://source.winehq.org/git/wine.git/blob/HEAD:/programs/iexplore/iexplore… As you can see here, scaling the iexplore icons really shows the limits of this artwork. The line caps are wrong in several places. The worst being in the highlight of the yellow swoosh at the bottom - you see the highlight doesn't line up with the border. A lot of things don't quite line up correctly. Moreover what were sharp single pixel lines in the 48x48 image have become fat strokes, which look rather play-schoolish to my eye. The solution is to have dedicated artwork specifically for these large sizes. This has been done in the Mango icon project: http://jimmac.musichall.cz/i.php?i=MIME2 http://jimmac.musichall.cz/i.php?i=git3 http://jimmac.musichall.cz/i.php?i=Tango-NG This is the work of Jakub Steiner and Lapo Calamandrei. They did a workshop on how to do this artwork here: https://www.youtube.com/watch?v=2T7833s2MJI Notice the fine detailing and beautiful shading. In the network filter they even used a paper texture for the card of the folder! These guys have done a fantastic job. So I wanted to sound out how much desire there is for this for Wine. I'm probably not going to be able to contribute this myself, due to time constraints. I wondered if there were any other developers cum artists interested in having a go. 2 years ago I asked Jakub if he would be interested in doing this, but he said he was quite busy. It might be worth reaching out to him or Lapo again, to see if they'd like to contribute. Also, I don't know how much this work is being driven by CodeWeavers Mac product, but another approach would be to for CodeWeavers to solicit contract work or a bounty for this. Jakub or Lapo might be more able to make time on those terms - but of course I don't know if that's a deal they or CodeWeavers would be interested in making. Another source of volunteers might be the tango-artists ML, but I don't know how many there are there. Finally, I've rebased my patch for the joy.cpl icon. It doesn't have a 256px icon though. Is this wanted? Best Regards Joel Holdsworth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRW/TtAAoJEIsWlGmq62IgaEcIAJYY9q/B3fA2AZQnR5M41qWn Q84e/5jrc1u2w1skmWAkCNdHNHu/R6AURklQ0Hysbnzxp+5GfftPHTKkRzA59cgs jVmkTSiqdVGGeGDRW2YWAcaFiH25xEOqSb9APzMLT4IRVypLbTwWYWhAsaZCa6+0 1USLRakqs5SF7+lCt5VcSHqiko/HPZZsTtNZYDy7cE4DPoNGbajPR9/0fEUfOEj+ b6xyu62tzPHfUcH4hj7YLa7ukJhq2Hh2ELA6gXnjr6yk+pZfx2uMTtfPZ4joWZzw 1DVcyoTkmeCOnasKJU2Obj7vdWgZxWG+WG4KTneH9a+rkSLo6T6Jojae+BXU4O8= =tNa1 -----END PGP SIGNATURE-----

2 1

Re: [PATCH 1/5] wined3d: Make fullscreen windows use HWND_TOPMOST instead of HWND_TOP. (try 3)
by Henri Verbeet 03 Apr '13

03 Apr '13

I think this series looks good.

1 0

Fwd: GSoC 2013 Ideas Page
by Austin English 02 Apr '13

02 Apr '13

I cleaned this up a couple months ago and removed completed/obsolete projects, but it needs further improvements (mostly new ideas). Please contribute any ideas that you have. Thanks! -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Tue, Apr 2, 2013 at 1:41 PM Subject: GSoC 2013 Ideas Page To: Carol Smith <carols(a)google.com> Hi there, You're receiving this email because we've reviewed your application for GSoC 2013. We're currently disappointed with the quality of your Ideas Page and would like to give you an opportunity to improve it and your chances of getting into GSoC this year. Please review the FAQs on Ideas Pages<http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20…> as well as the Mentor Manual section about creating an ideaspage<http://en.flossmanuals.net/GSoCMentoring/making-your-ideas-page/> . You have 24 hours from now to improve your ideas page.We will review it again tomorrow. Please let me know if you have any questions. Cheers, Carol -- -Austin

1 1

Re: d3dx9 [patch1/3, try 2]: Do not use relative error for small numbers
by Matteo Bruni 02 Apr '13

02 Apr '13

2013/4/1 Nozomi Kodama <nozomi.kodama(a)yahoo.com> > > Since there are only at most 7 significant digits for a float, we must not be too picky about the expected difference for small numbers > > -#define relative_error(exp, out) ((exp == 0.0f) ? fabs(exp - out) : (fabs(1.0f - (out) / (exp)))) > +#define relative_error(exp, out) (fabs(exp) < 0.01f ? fabs(exp - out) : fabs(1.0f - (out) / (exp))) This doesn't make much sense. Being floating point numbers, they have the same relative precision regardless of the magnitude of the value (as long as you are inside the range of representable values and excluding special values and denormals, but that should be irrelevant to our case here). If using a larger tolerance for the test in patch 2 makes it pass, then I think that's all you have to change. Otherwise you need to figure out why the test result differs so much from the expected value. Slightly unrelated, I think we should use fabsf() instead of fabs() there. We are already using fabsf() in a bunch of places, including d3dx9 tests, so there shouldn't be problems with that.

1 0

Re: uxtheme/tests: Don't test for themed app
by Alexandre Julliard 02 Apr '13

02 Apr '13

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -84,18 +84,14 @@ static void test_IsThemed(void) > SetLastError(0xdeadbeef); > bThemeActive = pIsThemeActive(); > trace("Theming is %s\n", (bThemeActive) ? "active" : "inactive"); > + ok( GetLastError() == ERROR_SUCCESS || > + broken(GetLastError() == ERROR_FILE_NOT_FOUND /* Win2k8 */), > + "Expected ERROR_SUCCESS, got 0x%08x\n", > + GetLastError()); Testing last error when there's no failure is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

exploring/possibly porting winelib app to support 64bit.
by jordan 01 Apr '13

01 Apr '13

Hi list. A friend of mine and myself, have been exploring expanding a (currently, 32bit only) winelib app to support 64bit plugins in wine (64). The app is called FSThost, which is used to host win32 VST instruments and effects (.dll) as a standalone app in Gnu/linux. Webpage: http://sourceforge.net/projects/fsthost/ We currently have a example/test app in the source code, which compile as test64.exe / test.exe.so ... you then use the exeutable 'foo'. ~ in this case 'foo' could be /path/to/your/64bitVSTplugin. Currently, the code fails to load the 64bit dll. We are not sure exactly why it is failing, but suspect a couple of reasons. this is where we at at; 1) LoadLibrary - OK 2) GetProcAddress (get address of VSTPluginMain function from DLL library) - OK 3) Initialize plugin - i.e. call VSTPluginMain function from library - FAIL. Potential reasons: - Vestige mismatch - Wine GetProcAddress on 64 bit platform My friend thought someone more familiar with Wine / WinAPI could take a look on this 64bit DLL and at least confirm that address returned by GetProcAddress is correct. (or give us good tips and/or adive). Since, i am already subbed (to wine-devel), i thought i would see if any one was interested in having a look and/or giving us some pointers, tips, etc. Here's an example (with WINEDEBUG="+relay'), full ouput: http://pastebin.com/5b5srr2a A little snippet: 0042:Call ntdll.RtlEncodePointer(002c4620) ret=18002d9aa 0042:Ret ntdll.RtlEncodePointer() retval=c90b263e5a54eb02 ret=18002d9aa 0042:Ret PE DLL (proc=0x18002f27c,module=0x180000000 L"Automaton.dll",reason=PROCESS_ATTACH,res=(nil)) retval=1 0042:Ret KERNEL32.LoadLibraryA() retval=180000000 ret=7f77bb394167 0042:Call KERNEL32.GetProcAddress(180000000,7f77bb3950b0 "VSTPluginMain") ret=7f77bb394182 0042:Ret KERNEL32.GetProcAddress() retval=180012900 ret=7f77bb394182 Revive plugin: Automaton 0042:Call KERNEL32.UnhandledExceptionFilter(0023e7f0) ret=7f77bbf1fc1a wine: Unhandled page fault on read access to 0x0000022f at address 0x22f (thread 0042), starting debugger... fixme:dbghelp:elf_search_auxv can't find symbol in module fixme:dbghelp:elf_search_auxv can't find symbol in module fixme:dbghelp:elf_search_auxv can't find symbol in module (goto pastebin for the rest / just scroll to bottom of page) If you want to take a look and/or test the code yourself (you need latest code): svn checkout svn://svn.code.sf.net/p/fsthost/code/trunk fsthost-code the source tree is small (like 2 seconds to download). Makefile64 is used to compile the test app (test.c). (just use 'make -f makefile64' from /src dir). alternatively, on sourceforge you can view the test64 app / source code online / here; http://sourceforge.net/p/fsthost/code/154/ (there are several commits following this one, but i believe this one is the most relevant. then to run it (from source dircetory); './test64.exe /path/to/64bitVSTplugin You can get a 'tester' 64bit VST (.dll) to load into test64.exe from here: http://kunz.corrupt.ch/products/tal-elek7ro anyway, any of your insights, help, tips, comments, etc would be both appreciated and helpful. thanks. Jordan

4 8