April 2013 - Wine-devel - list.winehq.org

Re: [1/3] include: Add COM interface definitions needed for PrintDlgEx implementation.
by Nikolay Sivov 09 Apr '13

09 Apr '13

Why not use DECLARE_INTERFACE_ here? And why bother checking UNICODE? On Mon, Apr 8, 2013 at 12:10 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/uuid/uuid.c | 1 + > include/commdlg.h | 80 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 81 insertions(+) > > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index fd96fe3..fb06f2d 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -83,6 +83,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > #include "sensevts.h" > #include "ocmm.h" > #include "commoncontrols.h" > +#include "commdlg.h" > #include "tlogstg.h" > #include "msdasc.h" > > diff --git a/include/commdlg.h b/include/commdlg.h > index 1a6e1d9..6eeb615 100644 > --- a/include/commdlg.h > +++ b/include/commdlg.h > @@ -762,6 +762,86 @@ typedef struct tagPDEXW > DECL_WINELIB_TYPE_AW(PRINTDLGEX) > DECL_WINELIB_TYPE_AW(LPPRINTDLGEX) > > +#ifdef STDMETHOD > +DEFINE_GUID(IID_IPrintDialogCallback, > 0x5852a2c3,0x6530,0x11d1,0xb6,0xa3,0x00,0x00,0xf8,0x75,0x7b,0xf9); > +typedef interface IPrintDialogCallback IPrintDialogCallback; > + > +#if defined(__cplusplus) && !defined(CINTERFACE) > +MIDL_INTERFACE("5852a2c3-6530-11d1-b6a3-0000f8757bf9") > +IPrintDialogCallback : public IUnknown > +{ > + virtual HRESULT STDMETHODCALLTYPE InitDone() = 0; > + virtual HRESULT STDMETHODCALLTYPE SelectionChange() = 0; > + virtual HRESULT STDMETHODCALLTYPE > HandleMessage(HWND,UINT,WPARAM,LPARAM,LRESULT *) = 0; > +}; > +#else > +typedef struct IPrintDialogCallbackVtbl > +{ > + BEGIN_INTERFACE > + > + /*** IUnknown methods ***/ > + HRESULT (STDMETHODCALLTYPE *QueryInterface)(IPrintDialogCallback > *This,REFIID riid,void **ppvObject); > + ULONG (STDMETHODCALLTYPE *AddRef)(IPrintDialogCallback *This); > + ULONG (STDMETHODCALLTYPE *Release)(IPrintDialogCallback *This); > + /*** IPrintDialogCallback methods ***/ > + HRESULT (STDMETHODCALLTYPE *InitDone)(IPrintDialogCallback *This); > + HRESULT (STDMETHODCALLTYPE *SelectionChange)(IPrintDialogCallback > *This); > + HRESULT (STDMETHODCALLTYPE *HandleMessage)(IPrintDialogCallback > *,HWND,UINT,WPARAM,LPARAM,LRESULT *); > + > + END_INTERFACE > +} IPrintDialogCallbackVtbl; > +interface IPrintDialogCallback > +{ > + CONST_VTBL IPrintDialogCallbackVtbl *lpVtbl; > +}; > +#endif /* CINTERFACE */ > + > +DEFINE_GUID(IID_IPrintDialogServices, > 0x509aaeda,0x5639,0x11d1,0xb6,0xa1,0x00,0x00,0xf8,0x75,0x7b,0xf9); > +typedef interface IPrintDialogServices IPrintDialogServices; > + > +#if defined(__cplusplus) && !defined(CINTERFACE) > +MIDL_INTERFACE("509aaeda-5639-11d1-b6a1-0000f8757bf9") > +IPrintDialogServices : public IUnknown > +{ > +#ifdef UNICODE > + virtual HRESULT STDMETHODCALLTYPE GetCurrentDevMode(LPDEVMODEW,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPrinterName(LPWSTR,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPortName(LPWSTR,UINT *) = > 0; > +#else > + virtual HRESULT STDMETHODCALLTYPE GetCurrentDevMode(LPDEVMODEA,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPrinterName(LPSTR,UINT *) > = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPortName(LPSTR,UINT *) = > 0; > +#endif > +}; > +#else > +typedef struct IPrintDialogServicesVtbl > +{ > + BEGIN_INTERFACE > + > + /*** IUnknown methods ***/ > + HRESULT (STDMETHODCALLTYPE *QueryInterface)(IPrintDialogServices > *This,REFIID riid,void **ppvObject); > + ULONG (STDMETHODCALLTYPE *AddRef)(IPrintDialogServices *This); > + ULONG (STDMETHODCALLTYPE *Release)(IPrintDialogServices *This); > + /*** IPrintDialogServices methods ***/ > +#ifdef UNICODE > + HRESULT (STDMETHODCALLTYPE *GetCurrentDevMode)(IPrintDialogServices > *,LPDEVMODEW *,UINT *); > + HRESULT (STDMETHODCALLTYPE > *GetCurrentPrinterName)(IPrintDialogServices *,LPWSTR,UINT *); > + HRESULT (STDMETHODCALLTYPE *GetCurrentPortName)(IPrintDialogServices > *,LPWSTR,UINT *); > +#else > + HRESULT (STDMETHODCALLTYPE *GetCurrentDevMode)(IPrintDialogServices > *,LPDEVMODEA *,UINT *); > + HRESULT (STDMETHODCALLTYPE > *GetCurrentPrinterName)(IPrintDialogServices *,LPSTR,UINT *); > + HRESULT (STDMETHODCALLTYPE *GetCurrentPortName)(IPrintDialogServices > *,LPSTR,UINT *); > +#endif > + > + END_INTERFACE > +} IPrintDialogServicesVtbl; > +interface IPrintDialogServices > +{ > + CONST_VTBL IPrintDialogServicesVtbl *lpVtbl; > +}; > +#endif /* CINTERFACE */ > +#endif /* STDMETHOD */ > + > BOOL WINAPI ChooseColorA(LPCHOOSECOLORA lpChCol); > BOOL WINAPI ChooseColorW(LPCHOOSECOLORW lpChCol); > #define ChooseColor WINELIB_NAME_AW(ChooseColor) > -- > 1.8.2 > > > >

3 3

[AppDB] -more spam-
by Joerg Schiermeier 09 Apr '13

09 Apr '13

Hi list, again a spammer used the AppDB for his nasty activities: 1.) > Comment for 'Adobe Photoshop CS3 (10.0)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=6584#Comment-8… 2.) > Comment for 'ElsterFormular 12.0 (2010 + 2011)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=22570#Comment-… No. #2 is maintained by me, so I deleted the comment just some minutes ago. Is it possible, to mail to all maintainers to inform them about the actual mail food and to have an eye on their applications? If so please do it. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

[GSoC] My (new) proposal for GSoC 2013
by Gediminas Jakutis 09 Apr '13

09 Apr '13

Hello! My previous application[1] turned out to be a total failure, hence making a completely different one. My proposal this time goes as follows: Write various D3D tests, mostly focusing on ones that can be later re-used for dxdiag in one way or another. Along with writing a tool that would allow users to easily test if d3d and wgl / opengl work & are set up properly. Info about me (copied over from [1]): >My name is Gediminas Jakutis. I study Informatics Engineering >[bachelor / undergraduate] at Kaunas University of Technology, second >year. >I wish to try out GSoC for the first time by helping to improve Wine. >My primary programming language is C. I am self-taught in C, but I >believe my knowledge is good enough. >I am quite familiar with Wine - I use it and experiment with it for >many years now. I am subscribed to and read wine-devel for more than a >year. >I browse through Wine's source code once in a while out of curiosity. >Thus, I have some knowledge of its structure. >Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. [1] http://www.winehq.org/pipermail/wine-devel/2013-March/099213.html Thank You for Your time Gediminas Jakutis -- LDK Varčiai www.varciai.lt

2 4

Re: kernel32: Add a test for threads state when a process is being terminated.
by Marvin 09 Apr '13

09 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24997 Your paranoid android. === W2KPROSP4 (32 bit loader) === No test summary line found === W2K3R2SESP2 (32 bit loader) === No test summary line found === W2K8SE (32 bit loader) === No test summary line found === W7PROX64 (32 bit loader) === No test summary line found === TEST64_W7SP1 (32 bit loader) === No test summary line found

1 0

[AppDB] Comment for 'Microsoft Outlook 2007' added by bayu
by Joerg Schiermeier 09 Apr '13

09 Apr '13

On Monday, April 8, 2013 at 07:49:47 an anonymous spammer wrote into the AppDB: > Comment for 'Microsoft Outlook 2007' added by bayu > http://appdb.winehq.org/objectManager.php?sClass=version&iId=7533#Comment-8… (...garbage killed...) Could someone of AppDBs admin please kill this comment and the user 'bayu'. Thanks lot! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

4 3

Re: [1/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
by Frédéric Delanoy 09 Apr '13

09 Apr '13

On Mon, Apr 8, 2013 at 2:53 PM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This patch creates winecon_private.h in 'include/wineconsole'. The header > is now a shared header. Note that the source code is the same as that in > programs/wineconsole/winecon_private.h. (This latter file will be removed > later.) > > Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). > > --- > include/wineconsole/winecon_private.h | 103 > +++++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 include/wineconsole/winecon_private.h > Please don't send 13 patches with the same name. Also, for long patch series, you should describe the whole purpose of the series in the first patch [1/N] (or even better in a [0/N] patch) Finally,even if "one change per patch" is the rule, don't overdo it... Frédéric

2 1

Dosbox integration
by Fabian Ebner 09 Apr '13

09 Apr '13

Hello, I'm Fabian Ebner and work with wine as a hobby. I found that GetShortNameA converts the example path C:\123456789\dn\DN.COM to C:\1234~Q4C\dn\DN.COM which causes problems with dosbox integration. Dosbox would need the path as C:\123456~1\dn\DN.COM Is there another function that converts the path in the way, dosbox needs it, should it be implemented or should dosbox be able to handle the first form of the path too? Also wine often tries to mount his z: drive, which isn't possible, because dosbox already mounts an own Z: drive http://www.dosbox.com/wiki/ZDrive Maybe wine should mount his Z: as Y:? Thanks in advance ~Fabian

2 1

Re: [3/3] comdlg32: Add an interactive PrintDlgEx test. Resend.
by Marvin 09 Apr '13

09 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24996 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Alexandre Julliard 08 Apr '13

08 Apr '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > There are two ways to solve this promlem: > - write own parser for extrac32, > - perform some translation for command line before > passing to CommandLineToArgvW(). > > I think that second variant is more appropriate. The first one would be cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Properly handle backbuffer_width/_height=0 in wined3d_device_reset. (try 3)
by Alexandre Julliard 08 Apr '13

08 Apr '13

Sam Edwards <cfsworks(a)gmail.com> writes: > This patch differs from try 2 in formatting alone. > > From ac2134cfce1139cb35c4ea5c3943a870183fc2f4 Mon Sep 17 00:00:00 2001 > From: Sam Edwards <CFSworks(a)gmail.com> > Date: Sat, 6 Apr 2013 18:03:34 -0600 > Subject: wined3d: Properly handle backbuffer_width/_height=0 in > wined3d_device_reset. It fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so d3d9ex.c && touch d3d9ex.ok d3d9ex.c:693: Test succeeded inside todo block: Got unexpected scissor rect {0, 0, 200, 150}. d3d9ex.c:701: Test succeeded inside todo block: Got unexpected vp.Width 200. d3d9ex.c:702: Test succeeded inside todo block: Got unexpected vp.Height 150. d3d9ex.c:710: Test succeeded inside todo block: Got unexpected backbuffer width 200. d3d9ex.c:711: Test succeeded inside todo block: Got unexpected backbuffer height 150. make[1]: *** [d3d9ex.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0