May 2013 - Wine-devel - list.winehq.org

Re: ieframe: Added more InternetExplorer object tests.
by Marvin 10 May '13

10 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25508 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: [PATCH] mscms: Use lcms2, when available
by wine.dev＠web.de 10 May '13

10 May '13

Hi Hans. >> lcms2 was released on 8. May 2010 >> lcms v1 is on the way to be phased out in the newest >> distribution versions. >Are there any distributions that have released without v1? I don't know, but Ubuntu has a bug for replacing lcms v1. There is no reason, that Wine is the last app, which depends on lcms v1. -- By by ... Detlef

4 4

Re: Re: Ask for mentor - Improve Bcrypt
by Marek Chmiel 10 May '13

10 May '13

Hey Kaiyi Zhang, Welcome to wine dev! If you decide to move forward with this(DH and DSS), I wish to share with you all that I have finished up to now. Using a few things from RSAENH I have all the related algorithms functioning. Also using LibTomCrypt I have partially implemented DSA but you would have to choose on the PRNG that DSA will use. My plan was to use RC4 but have not gotten to test that. I have yet to touch anything with DH_EPHEM (Ephemeral) or DH_SF (Store and Forward). If you have any questions shoot them to Juan or me (Juan is the better choice). Best of luck! -- Marek >Hi Kaiyi Zhang, > >(or is Zhang Kaiyi?) > >I think there's a little misconception in your proposal. Bcrypt the >algorithm is not the same as the BCrypt functions in crypt32. I believe >that Microsoft redesigned their CryptoAPI and more or less renamed their >functions BCrypt*. I don't believe they have any relationship to the Bcrypt >algorithm by Niels Provos and David Mazieres. I don't know how many >applications depend on the Bcrypt* functions in newer crypt32 >implementations, vs. the the Crypt* functions that are present in all >versions of crypt32. > >If you want feedback on Wine crypto stuff, I'm probably the best to help >you with that. Sorry if I've been a little absent, I'm pretty busy between >my family and my day job of late. > >I have another idea for you that I think is tractable, and perhaps up your >alley. The DH and DSS algorithms are still unimplemented in Wine. We >already have tests for them, so I think it should be possible to contribute >implementations. See the tests in dlls/dssenh/tests. > >I hope that helps. >--Juan

2 1

Ask for mentor - Improve Bcrypt
by Kaiyi Zhang 10 May '13

10 May '13

Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of GSOC. However, There are some exams which takes a lot of time, So lack of communication with the wine developers. I know it is late to apply for GSoC, however, I'm still interesting to the cryptography work in Wine even if I'm not accept as an official GSoC2013 student. Cryptography work is difficult, and Wine is difficult, so cryptography in Wine is double difficult for a beginner like me, could I ask for a mentor for the cryptography work even if my proposal is not accepted? To my dear kindly future mentor: I don't know how to thank you, but I'll work hard on contributing to the Wine project as more as I can. Sincerely appreciate. My idea is bcrypt improvement, I think it's very suitable for me, I learned the information security. Cryptography is one of my courses. I once development a Elliptic curve cryptography Demonstration system which makes the ECC Graphical. And i found there is blank in bcrypt, I want to do some improvement in this. I know there it's difficult for me to develop. but i can code some test code firstly. I read the dlls/rsaendh/tests/rsaenh.c: test_hashes(),test_des(),test_rsa() etc. and test the code on ubuntu successfully. Here is my plan: Week 1 - Week 2 - Get the Winedebug and document more adept - Get more information about bcrypt - Bcrypt Wiki: http://en.wikipedia.org/wiki/Bcrypt - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - File of Bcrypt: http://bcrypt.sourceforge.net/ - Read the Document of MSDN about Bcrypt and code some examples - MSDN about Bcrypt: http://msdn.microsoft.com/en-us/library/windows/desktop/aa833130(v=vs.85).a… Week 3 - Week 5 -Read some wine tests code and run some tests like: - the basic encryption dll/crypt32/ - Understand the bcrypt algorithm, there is a lot of code for learning like: - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - https://github.com/rg3/bcrypt - https://code.google.com/p/py-bcrypt/source/browse/bcrypt/bcrypt.c Week 6 - Week 11 - Code the BCrypt. According to the MSDN The Steps of Bcrypt - Open the Algorithm Provider - Get or Set Algorithm Properties - Create or Import a key - Perform Cryptiographic Operations - Close the Algorithm Provider There is a cross platform Bcrypt at http://bcrypt.sourceforge.net. if it is possible we can use it and its license compatible with the wine lgpl license. - add stub functions for Tests functions() and code the Tests functions(). The dlls/rsaenh/tests/rsaenh.c is a good reference. encrypt the pdData and compare with the right value. stub BCryptCreateHash() BCryptHashData() BCryptDuplicateHash() BCryptDuplicateHash BCryptDestroyHash() for test_hashes(). stub BCryptGenerateSymmetricKey() BCryptKeyDerivation() BCryptDestroyKey() for test_key_derivation(). stub BCryptGenRandom() for test_gen_random(). Week 12 - End - There are also some more cryptions need to tests, I can do more improvement these Thank you.

2 2

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.
by Alexandre Julliard 09 May '13

09 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) > { > ID3DXFileImpl *object; > HRESULT ret; > + const char expand_string[] = "expand_string"; > > TRACE("(%p)\n", d3dxfile); > > @@ -701,6 +702,11 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) > object->ID3DXFile_iface.lpVtbl = &ID3DXFile_Vtbl; > object->ref = 1; > > + /* Enable string expansion extension in d3dxof */ > + ret = IDirectXFile_RegisterTemplates(object->dxfile, (void*)expand_string, sizeof(expand_string)); > + if (ret != DXFILE_OK) > + ERR("Native d3dxof.dll used. Use builtin one to avoid problem.\n"); That's really ugly. You have to find a better way. -- Alexandre Julliard julliard(a)winehq.org

2 4

Patches 96113 & 96114
by Christian Costa 09 May '13

09 May '13

Hi, Is there anything wrong with these patches? http://source.winehq.org/patches/data/96113 http://source.winehq.org/patches/data/96114 Christian

1 0

Re: [PATCH 2/3] oleaut32: COM cleanup for ITypeInfo object
by Andrew Eikum 09 May '13

09 May '13

Looks like I missed replacing the ITypeInfo casts with impl_from calls, e.g.: static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, ITypeComp * *ppTComp) { ITypeInfoImpl *This = (ITypeInfoImpl *)iface; You can apply these, or wait until I amend them to fix that, too. Whichever. Andrew On Wed, May 08, 2013 at 03:12:45PM -0500, Andrew Eikum wrote: > --- > dlls/oleaut32/typelib.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index e62fa84..c6d2189 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -1094,8 +1094,8 @@ typedef struct tagTLBImplType > /* internal TypeInfo data */ > typedef struct tagITypeInfoImpl > { > - const ITypeInfo2Vtbl *lpVtbl; > - const ITypeCompVtbl *lpVtblTypeComp; > + ITypeInfo2 ITypeInfo2_iface; > + ITypeComp ITypeComp_iface; > LONG ref; > BOOL not_attached_to_typelib; > TYPEATTR TypeAttr ; /* _lots_ of type information. */ > @@ -1125,7 +1125,7 @@ typedef struct tagITypeInfoImpl > > static inline ITypeInfoImpl *info_impl_from_ITypeComp( ITypeComp *iface ) > { > - return (ITypeInfoImpl *)((char*)iface - FIELD_OFFSET(ITypeInfoImpl, lpVtblTypeComp)); > + return CONTAINING_RECORD(iface, ITypeInfoImpl, ITypeComp_iface); > } > > static const ITypeInfo2Vtbl tinfvt; > @@ -4884,7 +4884,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if (pTypeInfo->Name && !strcmpW(pTypeInfo->Name, szName)) > { > *pDescKind = DESCKIND_TYPECOMP; > - pBindPtr->lptcomp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + pBindPtr->lptcomp = &pTypeInfo->ITypeComp_iface; > ITypeComp_AddRef(pBindPtr->lptcomp); > TRACE("module or enum: %s\n", debugstr_w(szName)); > return S_OK; > @@ -4894,7 +4894,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if ((pTypeInfo->TypeAttr.typekind == TKIND_MODULE) || > (pTypeInfo->TypeAttr.typekind == TKIND_ENUM)) > { > - ITypeComp *pSubTypeComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + ITypeComp *pSubTypeComp = &pTypeInfo->ITypeComp_iface; > HRESULT hr; > > hr = ITypeComp_Bind(pSubTypeComp, szName, lHash, wFlags, ppTInfo, pDescKind, pBindPtr); > @@ -4910,7 +4910,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if ((pTypeInfo->TypeAttr.typekind == TKIND_COCLASS) && > (pTypeInfo->TypeAttr.wTypeFlags & TYPEFLAG_FAPPOBJECT)) > { > - ITypeComp *pSubTypeComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + ITypeComp *pSubTypeComp = &pTypeInfo->ITypeComp_iface; > HRESULT hr; > ITypeInfo *subtypeinfo; > BINDPTR subbindptr; > @@ -5013,9 +5013,9 @@ static HRESULT WINAPI ITypeLibComp_fnBindType( > if (pTypeInfo->Name && !strcmpiW(pTypeInfo->Name, szName)) > { > TRACE("returning %p\n", pTypeInfo); > - *ppTInfo = (ITypeInfo *)&pTypeInfo->lpVtbl; > + *ppTInfo = (ITypeInfo *)&pTypeInfo->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > - *ppTComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + *ppTComp = &pTypeInfo->ITypeComp_iface; > ITypeComp_AddRef(*ppTComp); > return S_OK; > } > @@ -5046,8 +5046,8 @@ static ITypeInfoImpl* ITypeInfoImpl_Constructor(void) > pTypeInfoImpl = heap_alloc_zero(sizeof(ITypeInfoImpl)); > if (pTypeInfoImpl) > { > - pTypeInfoImpl->lpVtbl = &tinfvt; > - pTypeInfoImpl->lpVtblTypeComp = &tcompvt; > + pTypeInfoImpl->ITypeInfo2_iface.lpVtbl = &tinfvt; > + pTypeInfoImpl->ITypeComp_iface.lpVtbl = &tcompvt; > pTypeInfoImpl->ref = 0; > pTypeInfoImpl->hreftype = -1; > pTypeInfoImpl->TypeAttr.memidConstructor = MEMBERID_NIL; > @@ -5238,7 +5238,7 @@ static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, > > TRACE("(%p)->(%p)\n", This, ppTComp); > > - *ppTComp = (ITypeComp *)&This->lpVtblTypeComp; > + *ppTComp = &This->ITypeComp_iface; > ITypeComp_AddRef(*ppTComp); > return S_OK; > } > @@ -6999,7 +6999,7 @@ static HRESULT WINAPI ITypeInfo_fnGetRefTypeInfo( > > if ((This->hreftype != -1) && (This->hreftype == hRefType)) > { > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > result = S_OK; > } > @@ -7913,7 +7913,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > if (FAILED(hr)) > return hr; > *pDescKind = DESCKIND_FUNCDESC; > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } else { > @@ -7923,7 +7923,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > if (FAILED(hr)) > return hr; > *pDescKind = DESCKIND_VARDESC; > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } > @@ -7934,7 +7934,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > ITypeInfo *pTInfo; > ITypeComp *pTComp; > HRESULT hr; > - hr=ITypeInfo_GetRefTypeInfo((ITypeInfo *)&This->lpVtbl, This->impltypes[0].hRef, &pTInfo); > + hr=ITypeInfo2_GetRefTypeInfo(&This->ITypeInfo2_iface, This->impltypes[0].hRef, &pTInfo); > if (SUCCEEDED(hr)) > { > hr = ITypeInfo_GetTypeComp(pTInfo,&pTComp); > -- > 1.8.2.2 > > > >

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow
by Qian Hong 09 May '13

09 May '13

Hello Guo Jian, On Fri, May 10, 2013 at 1:36 AM, Guo Jian <orzhvs(a)gmail.com> wrote: > A window should not lose mouse capture even when it's parent window is > disabled. Did you forget to remove the todo_wine introduced in [patch 1/2]? Thanks for your work on it. -- Regards, Qian Hong

2 1

Re: [PATCH] user32: initialize just the members we need (Coverity)
by Marvin 09 May '13

09 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25499 Your paranoid android. === W2KPROSP4 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WXPPROSP2 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=4154256 max=0 scroll.c:446: Test failed: unexpected initialization === WXPX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=32203072 max=0 scroll.c:446: Test failed: unexpected initialization === W2K3R2SESP2 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WVISTAX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=16706472 scroll.c:446: Test failed: unexpected initialization === W2K8SE (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === W7PROX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2684764 max=1965166079 scroll.c:446: Test failed: unexpected initialization === TEST64_W7SP1 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2684764 max=1952452095 scroll.c:446: Test failed: unexpected initialization === WXPX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WVISTAX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization === W7PROX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization === TEST64_W7SP1 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization

1 0

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture
by Qian Hong 08 May '13

08 May '13

Hi orzhvs, Thanks for your work on it, however, it seems gmail's line wrap 'feature' (hmm, isn't that a bug...) breaks your patch, you could try fight with that feature or send your patch as attachment instead.

1 0