May 2013 - Wine-devel - list.winehq.org

Re: [4/4] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 3)
by Marvin 30 May '13

30 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25774 Your paranoid android. === WVISTAX64 (64 bit heap) === No test summary line found === W7PROX64 (64 bit heap) === No test summary line found === TEST64_W7SP1 (64 bit heap) === No test summary line found

1 0

Re: [1/4] kernel32: Add more GlobalReAlloc/LocalReAlloc tests.
by Marvin 30 May '13

30 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25773 Your paranoid android. === WVISTAX64 (64 bit heap) === No test summary line found === W7PROX64 (64 bit heap) === No test summary line found === TEST64_W7SP1 (64 bit heap) === No test summary line found

1 0

Re: msvcrt: remove hack
by Henri Verbeet 30 May '13

30 May '13

On 30 May 2013 07:23, Austin English <austinenglish(a)gmail.com> wrote: > and no modern gcc/other compiler that I can find cares. > It does if you add -Wunused-parameter, but then you'll get a lot of other warnings as well. IMO the "action = action;" line is pretty pointless and best just removed, though if people are just looking for a different workaround, "(void)action;" is more or less the standard way to do it.

1 0

Re: msvcrt: remove hack
by Marcus Meissner 30 May '13

30 May '13

On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: > This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b > > but clang doesn't like it: > clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers > -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith > -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -o process.o > process.c > process.c:363:10: warning: explicitly assigning a variable of type > 'int' to itself [-Wself-assign] > action = action; /* Remove warning */ > ~~~~~~ ^ ~~~~~~ > 1 warning generated. > > and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus

4 6

Re: dinput: Update existing joystick values after setting the range property
by Austin English 29 May '13

29 May '13

On Sun, Apr 14, 2013 at 2:25 PM, Bassi, Gurmail <Gurmail.Bassi(a)mottmac.com> wrote: > ePSXe polls the joystick immediately after setting the axis range property, and uses the returned values as its 'centered' calibrated values - therefore the existing joystick state values must be remapped to the new range (or else the joystick may not have the full range of motion) > > > This patch has been tested on Ubuntu 12.04.1 LTS x86-64, and the behaviour confirmed to match Microsoft's DirectInput implementation on Windows XP 32-bit (Microsoft's DirectInput seems to update the existing joystick values to the new range prior to polling even if the joystick hasn't been moved) > > > --- > dlls/dinput/joystick.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) Hi Gurmail, This appears to have caused a regression, see http://bugs.winehq.org/show_bug.cgi?id=33496 (normally I'd cc you on the bug, but you don't seem to have a bugzilla account). -- -Austin

1 0

Re: (try 2)macdrv: rework the way we handle cursor position and composition text
by Ken Thomases 29 May '13

29 May '13

On May 29, 2013, at 1:11 PM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 5 --- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 6 +-- > 5 files changed, 29 insertions(+), 77 deletions(-) > > > <0014-macdrv-rework-the-way-we-handle-cursor-position-and-co.txt> Looks good to me. -Ken

1 0

Re: macdrv: rework the way we handle cursor position and composition text
by Ken Thomases 29 May '13

29 May '13

On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 3 -- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 5 +-- > 5 files changed, 29 insertions(+), 74 deletions(-) I know I reviewed this several times, but I failed to notice until now: you didn't remove the definition of IM_SET_CURSOR_POS in the enum and the entry in the table in dbgstr_event(). -Ken

2 1

GSoC 2013 has begun!
by Austin English 29 May '13

29 May '13

Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by Nikolay Sivov Zhan Jianyu, "Improve and add missing feature of vbscript component" mentored by Jacek Caban Welcome to Wine and good luck on your projects! As a reminder, here are the next few big dates: May 27th - June 17: community bonding period. Students/mentors should use this time to iron out details of the project, learn the code base and get to know others on the project. June 17: coding officially begins July 29th - Aug 2nd: mid-term reviews are submitted. Mentors/students, please feel free to contact me or André Hentschel if you have any GSoC administrative/procedural questions. Otherwise use wine-devel or ask your mentor for help with learning the Wine development process/codebase/etc. -- -Austin

1 1

Re: [1/3] DWrite: Added missing JUSTIFIED text alignment mode.
by Nikolay Sivov 29 May '13

29 May '13

Hi, Fabian. You forgot to attach patches 2 and 3.

1 0

re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Maarten Lankhorst 29 May '13

29 May '13

NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

2 1