June 2013 - Wine-devel - list.winehq.org

Re: oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types
by Nikolay Sivov 06 Jun '13

06 Jun '13

On Thu, Jun 6, 2013 at 9:55 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > Corrects a spelling mistake too and > > Changelog: > oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types > > > Best Regards > Alistair Leslie-Hughes > > > > - { extemdedW, DBPROP_INIT_PROVIDERSTRING, DBPROPOPTIONS_REQUIRED, VT_BSTR }, + { extemdedW, DBPROP_INIT_PROVIDERSTRING, DBPROPOPTIONS_OPTIONAL, VT_BSTR }, { gen_timeout, DBPROP_INIT_GENERALTIMEOUT, DBPROPOPTIONS_OPTIONAL, VT_I4 }, - { initcatW, DBPROP_CATALOGLOCATION, DBPROPOPTIONS_OPTIONAL, VT_BSTR }, + { initcatW, DBPROP_CATALOGLOCATION, DBPROPOPTIONS_OPTIONAL, VT_I4 }, How it's an integer? Catalog location is a path basically. Regarding provider string, could you please add a test for this flag?

1 0

Re: [PATCH 2/3] oleaut32/tests: Add save/load tests for created typelibs
by Marvin 05 Jun '13

05 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25849 Your paranoid android. === WXPX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === WVISTAX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === W7PROX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === TEST64_W7SP1 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8

1 0

Re: ole32: Add a basic OLE client/server test suite. Take 2.
by Dmitry Timoshkov 05 Jun '13

05 Jun '13

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

2 7

Re: [PATCH 3/5] wined3d: Pass a wined3d_resource_desc structure to wined3d_texture_create_cube().
by Stefan Dösinger 05 Jun '13

05 Jun '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-06-05 11:06, schrieb Henri Verbeet: > + desc.width = edge_length; + desc.height = edge_length; + > desc.depth = 1; Wouldn't it make sense to either set desc.height = 1 or desc.depth = edge_length? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRrwNtAAoJEN0/YqbEcdMwLkoP/jN3ooH3ur4ZLMgSc96VT+WR b+EcwCmK1yigPrY04UPiHmSVSS/g9bgR/BsVoQB9d6Fa2UfFeDEGGgOYdVOE6/9P guRWs6RAMTv4AfuDCjmRC3h2fO0nigg3sLkmvqG5qZF8hmGbItijB5zREWHys3Bk kedPMQaWXWuq9wwHa7ZM1B3wcMiZsxqfcyitFa1FsB7LvbLHIYuMzNQrViObGvT5 75J1Ux/WmFu9ZKTvWjIyFzhWg9oqeHPpB1lXgj4w3ONkOa0Rw27EUsxHRTlGiYm+ 4qGyvclsE1Ep2A2NK/kCUU1SuxeSP/bW38P9Lc8J/xNb8Si8zNu2VApTYjOIOk9q 3wHKgU0MuRRnw5ophMM9xNhIT/lt+0FilNZYosvEul+A0tAhncthCege0ZBRIeSf ZKlRGrInBMSy59BJwxVvPxaF702M0xHdkpKEMnML1NYCRg9+gbm862y/KRczvBxL kRWs6AIBr0247voTHvhRBJTtEanCeKP+qGLoatNVimPFaEDnSj9xxHIA+4XaThPW 2A+WjSPc7ni0Z8IKGQB9hOku0ZKvX2BJIAXiFm1KQW23psqUHF5CTR3w48yG7Dmh pm8SETIud6SwakKTW5ikp5ObjLYdM1Z8M8hNIkU64O8k7+aSX3hAqKW2shC6d/xm REcwzCU6NhmbDWgC5epH =tH28 -----END PGP SIGNATURE-----

2 1

Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.
by Rico Schüller 05 Jun '13

05 Jun '13

On 05.06.2013 08:48, Christian Costa wrote: > bone = &This->bones[bone_num]; > + /* Decrement refcounts of vertices previously influenced */ > + for (i = 0; i < bone->num_influences; i++) > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > bone->num_influences = num_influences; > HeapFree(GetProcessHeap(), 0, bone->vertices); > HeapFree(GetProcessHeap(), 0, bone->weights); > bone->vertices = new_vertices; > bone->weights = new_weights; > + /* Increment refcounts of vertices newly influenced */ > + for (i = 0; i < bone->num_influences; i++) > + { > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > + } Please have a look at the code style (brackets {} at the for loops?). It should be a bit more consistent. Also I think an increment (as said in the comment) is something like "This->vertices_refcounts[bone->vertices[i]]++;". Maybe you could add a test to verify if the comment or the code is correct? Cheers Rico

2 1

Re: [PATCH 1/2] server: Don't create new handle when DUP_HANDLE_CLOSE_SOURCE is used if possible (try2)
by Alexandre Julliard 05 Jun '13

05 Jun '13

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -890,6 +890,7 @@ struct rawinput_device > obj_handle_t handle; /* duplicated handle in dst process */ > int self; /* is the source the current process? */ > int closed; /* whether the source handle has been closed */ > + int reused; /* whether the source handle has been reused */ I don't think you need an extra flag, there's nothing the client has to do differently in that case (the warning is mostly cosmetic anyway). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: api-ms-win-core-localregistry-l1-1-0: add stub dll
by Charles Davis 04 Jun '13

04 Jun '13

On Jun 4, 2013, at 12:15 PM, Austin English wrote: > diff --git a/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > new file mode 100644 > index 0000000..cc15d4e > --- /dev/null > +++ b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > @@ -0,0 +1,40 @@ > +@ stub RegCloseKey Why don't you just forward them to their implementations in advapi32? Is there something oddly different about these functions that I don't know about? Chip

2 1

Re: bugzilla: Change no bugs found message
by Christian Costa 04 Jun '13

04 Jun '13

Hi, Minor but shouldn't it be "bug" instead "bugs"? Christian

2 2

Re: [PATCH 1/8] winemac: Don't unminimize a window on first activation during start-up.
by Dmitry Timoshkov 04 Jun '13

04 Jun '13

Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/cocoa_app.h | 2 ++ > dlls/winemac.drv/cocoa_app.m | 3 ++- > 2 files changed, 4 insertions(+), 1 deletions(-) I wonder, do you actually run 'make test' in dlls/user32/tests with your changes? My guess is that you don't. -- Dmitry.

2 1

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker 04 Jun '13

04 Jun '13

On Tue, 2013-06-04 at 10:16 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > After suggestion by Hans, do it in the helper ... especially > as the other external callers do not initialize schemes either. I also said that you shouldn't touch the parameter on error :) The other callers pass a pointer to a user variable and the attached test confirms that native doesn't touch it.

1 0