June 2013 - Wine-devel - list.winehq.org

testbot and NT4
by Ann and Jason Edmeades 04 Jun '13

04 Jun '13

Hiya, Its been a while since I did some cmd work and noticed there were some new bugs so am doing some fiddling. The real pain for me was always keeping the tests passing on nt4, so I noted with relief/surprise that the testbot doesnt have an NT4 VM anymore. Is it correct that there is no longer a requirement for tests to pass on NT4 for submission (if it's required, I really need a nt4 testbot!) If not, is there any objection to removing the numerous hacks in the test suite so they run on NT4? Thanks, Jason

6 6

Re: [PATCH] mscms: Use lcms2, when available [try 2]
by Hans Leidekker 04 Jun '13

04 Jun '13

On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote: > try2: > import the unchanged icc34.h from the lcms (v1) dev. package. > (Do we need to add a Wine LGPL licence header for icc34.h?) > > The plan is to remove this include, when changing Wine > to use the new getter/setter functions of lcms2 > (After the release of Wine-1.6) My plan was to switch to lcms2 soon *after* the release of Wine 1.6. I studied the API some more and my conclusion is that while it doesn't have all we need (specifically cmsReadRawTag and cmsWriteRawTag don't do what we want), we can avoid importing the icc34.h header. I'm not in favor of adding temporary workarounds. If distributions want to drop support for lcms1 in 1.6 I'd suggest that they backport the patches.

3 4

Re: Add tests for ntdll event functions
by Marvin 03 Jun '13

03 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25813 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Add tests for ntdll event functions
by Andrew Cook 03 Jun '13

03 Jun '13

While implemeting NtQueryEvent i stumbled across an odd permissions issue, which is really what this patch tests if ((event = create_event( root, &name, req->attributes, req->manual_reset, req->initial_state, sd ))) { if (get_error() == STATUS_OBJECT_NAME_EXISTS) reply->handle = alloc_handle( current->process, event, req->access, req->attributes ); else reply->handle = alloc_handle_no_access_check( current->process, event, req->access, req->attributes ); release_object( event ); } when creating an event, the handle is allocated with alloc_handle_no_access_check, which does not call event_map_access this causes event_op and event_query to fail, as the handle only has GENERIC_ALL, not the actual event permissions, which does not match windows behaviour (or at least windows 7 anyway), On 04/06/13 11:13, Andrew Cook wrote: > --- > dlls/ntdll/tests/Makefile.in | 1 + > dlls/ntdll/tests/event.c | 69 > ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 70 insertions(+) > create mode 100644 dlls/ntdll/tests/event.c > > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index 10d6674..a44b880 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -7,6 +7,7 @@ C_SRCS = \ > directory.c \ > env.c \ > error.c \ > + event.c \ > exception.c \ > file.c \ > generated.c \ > diff --git a/dlls/ntdll/tests/event.c b/dlls/ntdll/tests/event.c > new file mode 100644 > index 0000000..f29abc3 > --- /dev/null > +++ b/dlls/ntdll/tests/event.c > @@ -0,0 +1,69 @@ > +/* > + * Unit test suite for event functions > + * > + * Copyright 2005 Robert Shearman > + * Copyright 2005 Vitaliy Margolen > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > 02110-1301, USA > + */ > + > +#include "ntdll_test.h" > +#include "winternl.h" > +#include "winnt.h" > + > +static NTSTATUS (WINAPI *pNtCreateEvent) ( PHANDLE, ACCESS_MASK, const > POBJECT_ATTRIBUTES, BOOLEAN, BOOLEAN); > +static NTSTATUS (WINAPI *pNtPulseEvent) ( HANDLE, PULONG ); > +static NTSTATUS (WINAPI *pNtQueryEvent) ( HANDLE, > EVENT_INFORMATION_CLASS, PVOID, ULONG, PULONG ); > +static NTSTATUS (WINAPI *pNtClose) ( HANDLE ); > +static VOID (WINAPI *pRtlInitUnicodeString)( PUNICODE_STRING, > LPCWSTR ); > + > +START_TEST(event) > +{ > + HANDLE Event; > + NTSTATUS status; > + UNICODE_STRING str; > + OBJECT_ATTRIBUTES attr; > + EVENT_BASIC_INFORMATION info; > + HMODULE hntdll = GetModuleHandleA("ntdll.dll"); > + HMODULE hkernel32 = GetModuleHandleA("kernel32.dll"); > + static const WCHAR eventName[] = > {'\\','B','a','s','e','N','a','m','e','d','O','b','j','e','c','t','s','\\','t','e','s','t','E','v','e','n','t',0}; > + > + if (!hntdll) > + { > + skip("not running on NT, skipping test\n"); > + return; > + } > + > + pNtCreateEvent = (void *)GetProcAddress(hntdll, "NtCreateEvent"); > + pNtQueryEvent = (void *)GetProcAddress(hntdll, "NtQueryEvent"); > + pNtPulseEvent = (void *)GetProcAddress(hntdll, "NtPulseEvent"); > + pNtClose = (void *)GetProcAddress(hntdll, "NtClose"); > + pRtlInitUnicodeString = (void *)GetProcAddress(hntdll, > "RtlInitUnicodeString"); > + > + pRtlInitUnicodeString(&str, eventName); > + InitializeObjectAttributes(&attr, &str, 0, 0, NULL); > + > + status = pNtCreateEvent(&Event, GENERIC_ALL, &attr, 0, 0); > + ok( status == STATUS_SUCCESS, "NtCreateEvent failed %08x\n", status ); > + > + status = pNtPulseEvent(Event, 0); > + todo_wine ok( status == STATUS_SUCCESS, "NtPulseEvent failed > %08x\n", status ); > + > + status = pNtQueryEvent(Event, EventBasicInformation, &info, > sizeof(info), NULL); > + todo_wine ok( status == STATUS_SUCCESS, "NtQueryEvent failed > %08x\n", status ); > + > + status = pNtClose(Event); > + ok( status == STATUS_SUCCESS, "NtClose failed %08x\n", status ); > +}

1 0

Re: How to stop gecko and mono popups while git bisecting?
by Dan Kegel 03 Jun '13

03 Jun '13

Or run https://winezeug.googlecode.com/svn/trunk/install-addons.sh

1 0

How to stop gecko and mono popups while git bisecting?
by Alan W. Irwin 03 Jun '13

03 Jun '13

I just finished a git bisect to establish the cause of the git regression given by http://bugs.winehq.org/show_bug.cgi?id=33715. My detailed report concerning the result of the bisect appears there, but I have an additional question concerning the git bisect process itself. I pretty much follow the recommendations in http://wiki.winehq.org/RegressionTesting, but I like to completely remove my WINEPREFIX directory as the first step in my bisect test script to eliminate the possibility that some unclean cached result there is causing issues. But after a particular version of wine is built, that test script goes on to test it using wineconsole which has to populate WINEPREFIX itself (which is fine) since I removed it for a reason, but that step is accompanied by some popups concerning what I want to do about downloading mono (not available on Debian testing) and gecko (available on Debian testing, but I haven't figured out how to make the ./configure step of the wine build recognize that). I don't mind the popups, but I do mind having to answer the questions posed by them (say through the night) as the automated git bisect proceeds. For the case where wineconsole populates the WINEPREFIX directory for the first time, is there a way to configure wine or run wineconsole so those popups that require me answering a question can be eliminated? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

2 2

Re: dinput: Remove error-prone new joystick code
by Alexandre Julliard 03 Jun '13

03 Jun '13

"Bassi, Gurmail" <Gurmail.Bassi(a)mottmac.com> writes: > The joystick code I submitted in Wine patch 95617 seems to be causing problems to some users with both hardware (Wacom Cintiq) and software (Lord of the Rings Online) - see Wine bugs 33496 & 33593 > > This patch removes the offending code, until the cause can be fully investigated and a new patch issued if necessary Please fix the code instead of removing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] kernet32: Add DuplicateHandle tests with DUPLICATE_CLOSE_SOURCE flag
by Alexandre Julliard 03 Jun '13

03 Jun '13

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/kernel32/tests/process.c | 83 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) You should probably add some tests that first close lower-numbered handles, to see if it may not be simply allocating the first free one instead. -- Alexandre Julliard julliard(a)winehq.org

1 0