July 2013 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] include/ddk: add usbioctl.h
by Nikolay Sivov 22 Jul '13

22 Jul '13

On 7/22/2013 22:38, Damjan Jovanovic wrote: > Changelog: > * add usbioctl.h > > Damjan Jovanovic Hi, Damjan. You forgot patches.

3 2

Re: appwiz: Correct Wine Mono installer messages
by Alexandre Julliard 22 Jul '13

22 Jul '13

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Where the correction is obvious I have done so, but where a full > translation is needed I have simply removed the incorrect one. This > will mark that line as untranslated and hopefully someone will see > that. It will also default to English with the correct message until > translated. That's what fuzzy is for, there's no reason to remove them. -- Alexandre Julliard julliard(a)winehq.org

3 3

Wine 1.6 list of deferred patches
by Bruno Jesus 22 Jul '13

22 Jul '13

This is the list of (hopefully) all deferred patches for wine 1.6, all authors are in bcc. I hope it's useful for developers. 97187 Deferred Dmitry Timoshkov [3/3] kernel32: GetShortPathName for a non-existent short file name should fail. 97131 Deferred Rosen Diankov [ole32] Bugfix for implicit MTA apartment initialization 97130 Deferred Rosen Diankov [oleaut32] Bugfix patches for marshaling VT_UNKNOWN in SAFEARRAYS 97124 Deferred Maarten Lankhorst [RFC PATCH] loader: allow overriding pthread_create correctly on linux 97119 Deferred Fabian Ebner [PATCH] dinput: Check the message queue in GetDeviceState * 97085 Deferred Dmitry Timoshkov ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file. 96974 Deferred Stefan Dösinger [PATCH 2/2] wined3d: Avoid calculating 1 / (fog_end - fog_start) in the shader 96961 Deferred Mathis Beer ntdll: make msync() call asynchronous in NtFlushVirtualMemory (try 3.5, alternate version) 96925 Deferred Hans Leidekker server: The token user SID must be present in the default DACL. 96899 Deferred Stefan Dösinger [PATCH 1/5] wined3d: Consolidate d3d_info BOOLs into a flags field 96855 Deferred Alistair Leslie-Hughes oledb32: Add IErrorInfo Support OK 96854 Deferred Alistair Leslie-Hughes msdaps: Add support for ISourcesRowset (try 2) 96831 Deferred Christian Costa [PATCH] d3dxof: Remove LP stuff and rename variables for IDirectXFile methods. 96819 Deferred Nikolay Sivov comctl32: Properly handle repainting for HDF_OWNERDRAW items 96797 Deferred André Hentschel ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32 (try 2) 96793 Deferred Christian Costa [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests. 96791 Deferred morphiend msvcrt: add support for _chsize_s 96765 Deferred Christian Costa [PATCH 2/4] d3dxof: Handle float in binary mode and remove code that becomes useless. * this patch was already commited.

1 0

Re: [PATCH 3/4] d3dx9: Improve ID3DXConstantTable::Set*().
by Alexandre Julliard 22 Jul '13

22 Jul '13

Rico Schüller <kgbricola(a)web.de> writes: > +static UINT set(struct ID3DXConstantTableImpl *table, IDirect3DDevice9 *device, struct ctab_constant *constant, > + const void **indata, D3DXPARAMETER_TYPE intype, UINT *size, UINT incol, D3DXPARAMETER_CLASS inclass, UINT index, > + BOOL is_pointer) > +{ > + DWORD (*get_index)(const void **indata, UINT index) = NULL; > + D3DXCONSTANT_DESC *desc = &constant->desc; > + UINT l, i, regcount = 1, regsize = 1, cin = 1, rin = 1, ret, last = 0; > + DWORD tmp; > + > + if (is_pointer) get_index = &get_index_pointer; > + else get_index = &get_index_array; It would be cleaner and easier to follow to have a simple helper with a is_pointer flag, rather than using function pointers with such trivial functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 2)
by Nikolay Sivov 21 Jul '13

21 Jul '13

On 7/20/2013 23:37, John Chadwick wrote: > This patch changes the create_selection interface to accept a wide string > instead of an xmlChar string. This is a transitional change, which will be > needed as libxml2's XPath parser is phased out. > > The last submission had a memory leak (sorry, I isolated this change > from some other changes and accidentally axed a heap_free in the > process.) Looks ok, I didn't try tests, but I hope you did.. One thing though: > +static inline WCHAR *heap_strcatW(WCHAR *a, const WCHAR *b) > +{ > + int len = strlenW(a) + strlenW(b); > + WCHAR *c = heap_realloc(a, (len + 1) * sizeof(WCHAR)); > + WCHAR *ptr = c; > + > + while(*ptr) > + ptr++; > + while(*b) > + *(ptr++) = *(b++); > + c[len] = 0; > + > + return c; > +} > + I'm assuming you didn't use strcatW() to avoid one more strlenW()? Even if you don't want to use it for some reason, you don't need first loop cause you already know 'a' length, and second loop is just strcpyW(). Also I suggest to use 'dst', 'src' names for parameters.

1 0

Coverity Status
by Marcus Meissner 20 Jul '13

20 Jul '13

Hi, For Wine 1.6 we have the following Coverity stats: - 3,648,322 Lines of Code scanned - Defect Density 0.51 - 8321 total defects - 1852 outstanding (unresolved) defects - 1964 dismissed defects - 4505 fixed defects git shortlog wine-1.4..wine-1.6|grep -i Coverity|wc -l 225 Thanks to AmineKhaldi uploading the builds and everyone reviewing and fixing coverity issues :) Ciao, Marcus

1 0

Another major milestone
by Jeremy White 19 Jul '13

19 Jul '13

Alright folks, I have to confess that the 1.6 release came and I didn't immediately get up and dance. In fact, a new Wine release was almost...boring. I think we have to consider that a major milestone in of itself. New, useful releases are just a matter of course for us now. Woohoo! Now I'm dancing <grin>. Cheers, Jeremy

8 9

Re: [docs] winelib: Use proper entity escaping for '&','<' and '>'
by Julian Rüger 19 Jul '13

19 Jul '13

Hi Frédéric, > - $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $< | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ > + $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $lt; | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ looks like you forgot the "&". Best, Julian

2 1

Re: [2/2] gdiplus: Store graphics clipping region in device coordinates.
by Vincent Povirk 19 Jul '13

19 Jul '13

I'm curious what happens if the world transform has some rotation. It seems like transform_rectf would break in that case.

2 2

Re: [1/2] windowscodecs: Add a test for global GIF palette exposed by recent Windows versions.
by Vincent Povirk 19 Jul '13

19 Jul '13

The series looks good to me.

1 0