July 2013 - Wine-devel - list.winehq.org

Re: [1/4] wincodecs: Added IWICBitmapClipper stub
by Vincent Povirk 19 Jul '13

19 Jul '13

This series looks good to me.

1 0

Re: riched20: Add tests for ITextRange interface.
by Nikolay Sivov 19 Jul '13

19 Jul '13

On 7/18/2013 20:28, Caibin Chen wrote: > Add tests for start and end point, setting and getting text. > --- > dlls/riched20/tests/Makefile.in | 3 +- > dlls/riched20/tests/txtrng.c | 343 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 345 insertions(+), 1 deletion(-) > create mode 100644 dlls/riched20/tests/txtrng.c You could just use existing file, richole.c fits I think.

2 7

Re: Patches I maintain
by Rico Schüller 18 Jul '13

18 Jul '13

Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You may have a look here: http://wiki.winehq.org/SubmittingPatches On 18.07.2013 01:23, Roland Haeder wrote: > +HRESULT D3DXCreatePolygon(LPDIRECT3DDEVICE9 device, float length, UINT sides, LPD3DXMESH *mesh, LPD3DXBUFFER adjacency) Well this looks a little bit wrong. You may have a look here http://msdn.microsoft.com/en-us/library/windows/desktop/bb172785%28v=vs.85%… . Don't copy and paste it. A patch which by accident works, is not something which should be applied at all. There are several issues alone in that line. Cheers Rico

2 1

Re: winedev: Add doc for winedbg symbol_picker option
by Frédéric Delanoy 18 Jul '13

18 Jul '13

On Thu, Jul 18, 2013 at 12:48 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > en/winedev-debugger.sgml | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > Please discard this. It has been committed a long time ago. Sorry (again) for the noise. Frédéric

1 0

Manpage patch, please review
by Julian Rüger 17 Jul '13

17 Jul '13

Hi all! While working on the translation of the (main) manpage, I noticed a few issues in the English version and started working on a patch. That was quite some time ago, I had little spare time lately and didn't get around to finish and send it in. So I figured I just take what I have now and ask you guys for comments. I appreciate any remarks or suggestions. Thanks, Julian Notes: I had a change similar to Frédéric's, mentioning wine can run 64-bit programs now. He was quicker and I like his wording better. I had something like "[...]or Win64 executable (if your version of wine was compiled with 64-bit support)." I guess that would be more confusing to people using their distro's wine packages and people compiling their own wine know that anyway. Do you agree or do you think it's better to be more specific? CUI -> CLI: According to Google and Wikipedia, CLI is more common. -.BR @bindir@/wineserver , +.IR @bindir@/wineserver , and following, similar changes: This is the way it is formatted in the wineserver manpage. I noticed there is no uniform style across our manpages, so we should have a guideline. Should paths be bold or italic/underlined?

2 4

Re: ieframe: Use SHANDLE_PTR in IWebBrowserApp::get_HWND.
by Marvin 16 Jul '13

16 Jul '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26282 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 004033D1

2 1

Re: loader: Indicate wine can run 64-bit apps in manpage
by Frédéric Delanoy 16 Jul '13

16 Jul '13

On Tue, Jul 16, 2013 at 4:57 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- > loader/wine.man.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Please ignore this patch: I accidentally resent it. Sorry about the noise. Frédéric

1 0

Re: po: Update Turkish translation (second try)
by Francois Gouget 16 Jul '13

16 Jul '13

-<<<<<<< HEAD -"PO-Revision-Date: 2013-07-13 04:49+0200\n" -======= -"PO-Revision-Date: 2013-07-04 00:10+0200\n" ->>>>>>> 598685e6c5992355de35b4345e91eb4e50b9f07e +"PO-Revision-Date: 2013-07-13 05:00+0200\n" [...] -#: attrib.rc:27 cmd.rc:322 +#: attrib.rc:27 cmd.rc:325 These look wrong: there is currently no conflict in the checked-in PO file and there should not be any line-number changes in the patch. So it won't apply to the current Git repository. Something must have happened when you rebased or generated the diff. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

1 0

Re: [PATCH 1/3] user32/tests: Sleep enough time to make sure all input message have been processed.
by Qian Hong 16 Jul '13

16 Jul '13

Hello, This patch is marked as pending, is there anything I can improve? Did the test results in [1] and [2] help? Thanks for any feedback! [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 On Wed, Jul 3, 2013 at 2:45 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hello, > > Current menu test code may hide some failure tests [1], with the attached > patch, all failure tests could be detected [2]. > > > [1] https://testbot.winehq.org/JobDetails.pl?Key=26191 > [2] https://testbot.winehq.org/JobDetails.pl?Key=26190 > > > --- > dlls/user32/tests/menu.c | 1 + > 1 file changed, 1 insertion(+) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

2 6

Re: ntdll: Tests for RtlHashUnicodeString()
by Dmitry Timoshkov 16 Jul '13

16 Jul '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +#include "ddk/wdm.h" Please don't do that, this breaks compilation with PSDK headers. If you need some specific definitions, types or API prototypes - replicate them in the test itself. -- Dmitry.

2 2