August 2013 - Wine-devel - list.winehq.org

Re: [4/6] kernel32: Make serial tests self-contained.
by Saulius Krasuckas 21 Aug '13

21 Aug '13

* On Thu, 15 Aug 2013, Dmitry Timoshkov wrote: > dlls/kernel32/tests/comm.c | 284 ++++++++++++++++++++++++++------------------- > 1 file changed, 167 insertions(+), 117 deletions(-) ... > --- a/dlls/kernel32/tests/comm.c > +++ b/dlls/kernel32/tests/comm.c > @@ -1486,7 +1588,7 @@ static void test_WaitRing(HANDLE hcom) > success, err, evtmask, after-before, after1-before); > > ok(evtmask & EV_RING, "Failed to detect EV_RING: 0x%08x, expected 0x%08x\n", > - evtmask, EV_RING); > + evtmask, EV_CTS); Is everything OK with the constants here? S.

1 0

Re: oledb32: Add IDataSourceLocator support (try 5)
by Nikolay Sivov 21 Aug '13

21 Aug '13

On 8/21/2013 10:16, Alistair Leslie-Hughes wrote: > Hi, > Updated naming. You updated method names only, what's left : > +typedef struct DataSourceImpl > +HRESULT create_data_source(IUnknown *outer, void **obj) > +static const IDataSourceLocatorVtbl DataSourceVtbl = Also you most likely don't need these: > +#include "wine/unicode.h" > +#include "wine/list.h" > > > Changelog: > oledb32: Add IDataSourceLocator support > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

Re: oledb32: Add IDataSourceLocator support (try 4)
by Nikolay Sivov 21 Aug '13

21 Aug '13

On 8/21/2013 09:15, Alistair Leslie-Hughes wrote: > Hi, > Use helper functions for memory > > > Changelog: > oledb32: Add IDataSourceLocator support > > > Best Regards > Alistair Leslie-Hughes It looks okay, but I suggest to fix a naming: > +typedef struct DataSourceImpl > +{ > + IDataSourceLocator IDataSourceLocator_iface; > + LONG ref; > + > +} DataSourceImpl; > +static HRESULT WINAPI datasource_QueryInterface(IDataSourceLocator *iface, REFIID riid, void **ppvoid) etc. IDataSource is another interface, and it's confusing to name locator after it - dslocator_* naming used in CF is short enough and descriptive to use it everywhere.

1 0

Willing to join Wine
by Priyank Bhatt 20 Aug '13

20 Aug '13

I want to work for Wine . I'm a third year undergraduate Student , I have done my elimentary course on machine learning algorithm . I am also familiar with C/C++ and some what of Python . Please suggest what all do I need to learn or read so as to start contributing to the open source community of mlpack. As an amateur and as per your free slots what project form the idea's page should I work on ?

2 1

Re: winmm: fix WOD_Open() WAVE_MAPPER no-device case.
by Andrew Eikum 20 Aug '13

20 Aug '13

On Tue, Aug 20, 2013 at 05:57:34AM +0200, Fabrice Bauzac wrote: > Hello, > > This patch intends to fix the bug: > http://bugs.winehq.org/show_bug.cgi?id=34305 > > The bug: basically, when there is no sound device and the user tries > to WOD_Open() the WAVE_MAPPER pseudodevice, the code calls read_map() > with device index 0 without first checking whether the number of > devices is greater than 0. > Looks good to me, thanks. I tested on Windows 7, and the error code is correct. By the way, the waveIn path (WID_Open) has the same bug. Feel free to fix that, too, if you want. Or I'll submit a patch myself later. Andrew

2 2

Re: [PATCH 2/4] oleaut32: Implement ICreateTypeInfo::SetTypeDescAlias
by Piotr Caban 20 Aug '13

20 Aug '13

On 08/20/13 16:57, Andrew Eikum wrote: > @@ -10530,8 +10541,28 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeDescAlias(ICreateTypeInfo2 *ifac > + This->cbSizeInstance = VARIANT_DataSize(This->tdescAlias->vt, This->pTypeLib->ptr_size); > + if(!This->cbSizeInstance){ > + FIXME("Wrong size for variant type! 0x%x\n", This->tdescAlias->vt); > + This->cbSizeInstance = 4; > + } > + > + This->cbAlignment = 4; The This->cbAlignment should be also depending on alias type (e.g. it's 1 for VT_I1).

1 0

Re: Sort the AUTHORS file by their last names.
by Ken Sharp 20 Aug '13

20 Aug '13

On 16/08/13 14:46, Tae Wong wrote:> The AUTHORS file have all developers from the GIT log which were > sorted on their first names. > > This patch will switch the sort order from first to last names. This isn't how the AUTHORS file is generated. http://source.winehq.org/git/wine.git/commit/5da31c8817293ff98b4defceb962f7…

5 14

Re: [PATCH 1/5] wined3d: Add a function for allocating aligned resource memory (try 2)
by Henri Verbeet 20 Aug '13

20 Aug '13

On 20 August 2013 12:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void *wined3d_alloc_resource_mem(SIZE_T size) > +{ > + void **p; > + SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); > + void *mem; > + > + if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align))) > + return NULL; > + > + p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1; > + *p = mem; > + > + return ++p; > +} I think this should either be called wined3d_resource_allocate_sysmem() and live in resource.c, or accept any np2 alignment and be called something along the lines of wined3d_memalign(). The former probably makes the most sense at this point. Somewhat related, I don't think there's really a reason to have both "allocatedMemory" and "heap_memory" anymore. It should probably just be called "sysmem". That's a cleanup that doesn't necessarily belong in this patch though.

2 2

Re: kernel32: Fix required buffer length for locale values from registry
by Alexandre Julliard 20 Aug '13

20 Aug '13

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > http://bugs.winehq.org/show_bug.cgi?id=32169 > > Locale info to override is stored as REG_SZ and supposed to be > null-terminated, They are supposed to, but it's not guaranteed. The code should be able to cope with non-terminated strings. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oledb32: Implement IErrorRecord AddErrorRecord
by Nikolay Sivov 20 Aug '13

20 Aug '13

On 8/20/2013 13:21, Alistair Leslie-Hughes wrote: > Hi, > Yes we do just take the pointer (pErrorInfo) passed in. MSDN states > that the caller responsible for this memory. It means caller could free it at any time (or it could be a stack variable), so you have to make a deep copy. > > > Changelog: > oledb32: Implement IErrorRecord AddErrorRecord > > > Best Regards > Alistair Leslie-Hughes > >

2 1