August 2013 - Wine-devel - list.winehq.org

Re: riched20: Use \ulnone instead of \ul0 for no underline.
by Huw Davies 20 Aug '13

20 Aug '13

On Mon, Aug 19, 2013 at 05:38:13PM -0500, Vincent Povirk wrote: > Testing on Windows (by saving rtf documents with wordpad and viewing > them with notepad) shows that it uses \ulnone instead of \ul0 to end > underline. Wine and Windows are both able to read either one. I think these are symonyms and indeed Windows seems to use \ulnone, so this looks good to me. Huw.

1 0

Re: Could you update/rerun that report on bugs without AppDB links?
by Dan Kegel 19 Aug '13

19 Aug '13

I don't seem to have saved the (crappy) script. There is something similar at https://code.google.com/p/winezeug/source/browse/#svn%2Ftrunk%2Fappdb-mashup and it wouldn't be too hard to whip something up again for somebody who is motivated. Please do throttle the scraping script to avoid overloading the databases if you try. On Sun, Aug 18, 2013 at 12:11 PM, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: > Dan, > > I don't know if you've been following the "PLEASE add bug links!" thread on wine-devel, so I figured I'd just contact you directly. Do you remember that report on unlinked bugs you ran about 5 years ago? http://kegel.com/wine/unlinked.html > > Could you update/run it again against current bugzilla? If we post a link to the results on the forum, we could ask users to help clear the backlog. > > -- > Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: [website] Added templates/zh-cn/cvs.template translation
by Hin-Tak Leung 19 Aug '13

19 Aug '13

------------------------------ On Sat, Aug 17, 2013 09:02 BST Frédéric Delanoy wrote: >On Sat, Aug 17, 2013 at 5:57 AM, xulixin <xulixin1990(a)gmail.com> wrote: >> Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other >> format? > >Not sure, most people (at least non-Chinese) use firstname lastname >convention, but I guess you should use the same convention as other >Chinese-speaking committers. > >Here's a list I extracted from AUTHORS file that *look* Chinese to me >(don't know if they're really Chinese, or Korean, or from another >Asian country): >Chae Jong Bin >Cheer Xiao >Chia-I Wu >Hwang YunSong (황윤성) >Jau-Horng Chen >Jay Yang >Qian Hong >Qingchuan Wang >Qingdoa Daoo >Shi Quan He >Wei-Lun Chao >Weisheng Li >Xiang Li >XueFeng Chang >Yong Chi >Yuxi Zhang >Zhangrong Huang >Zhan Jianyu > >Hope this helps, > >Frédéric Delanoy Many had replied but few had touched the _main_ issue: it is a matter of policy that patches of an anonymous origin to Wine are categorically rejected. The Linux kernel also has a similar policy. This policy is due to past threats of copyright/intellectual-property infringements and possible cause of contamination from people who may have privileged access to proprietary technology. So a "real name" is needed for any patches. As already discussed, "xulixin" is a real name - as it appears on official documents, passports, etc. Although for the benefit of Western custom, "Xu Li-Xin", or "Xu Lixin", or "Lixin Xu" or "Li-Xin Xu" might make it more obvious, and make some people happier. Ultimately it is Alexandre's call, what is considered a real name. Anyway, the git command to set a default user name for generating patches is, e.g. for mine: git config --global user.name "Hin-Tak Leung" (this writes to ~/.gitconfig, which is a text files that one can edit by hand as well). See "man git-config" for details. Without --global, these config's are set per repository. e.g. you may use different names and e-mail addresses for internal (job-wise) work and external (open) work. I also have a few other global configs of my own; the equivalent of these two are probably useful to most people: git config --global ui.color true and git config --global core.editor emacs (the former sets colorization on for "git log", "git diff", etc; I find it useful of having diff's colorized - that assumes that you do all your development work on a terminal that's color-capable (most recent linux consoles/terminals are); the latter sets the default editor to emacs, when composing commit messages. You may want to set it to your favorite editor, whichever that is.).

1 0

Re: [PATCH 2/5] wined3d: Wrap resource->heapMemory into a structure
by Henri Verbeet 19 Aug '13

19 Aug '13

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +struct wined3d_heap_memory *wined3d_alloc_resource_mem(UINT size) > +{ > + struct wined3d_heap_memory *ret; > + > + ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ret)); > + if (!ret) > + return NULL; > + > + ret->alloc_ptr = HeapAlloc(GetProcessHeap(), 0, size + RESOURCE_ALIGNMENT); > + if (!ret->alloc_ptr) > + { > + HeapFree(GetProcessHeap(), 0, ret); > + return NULL; > + } > + ret->ptr = (BYTE *)(((ULONG_PTR)ret->alloc_ptr > + + (RESOURCE_ALIGNMENT - 1)) & ~(RESOURCE_ALIGNMENT - 1)); > + return ret; > +} > + I don't think this is a good idea. How about something like the following? The corresponding free function would be trivial. void *wined3d_memalign(SIZE_T alignment, SIZE_T size) { SIZE_T align; void *mem; void **p; align = max(sizeof(*p), alignment - 1); if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + align))) return NULL; p = (void **)(((ULONG_PTR)mem + align) & ~(alignment - 1)) - 1; *p = mem; return ++p; } (Untested, there's probably some room for improvement.)

3 6

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.
by Alexandre Julliard 19 Aug '13

19 Aug '13

Kai Tietz <ktietz70(a)googlemail.com> writes: > diff --git a/tools/widl/widl.c b/tools/widl/widl.c > index 5df99fc..6d8ec87 100644 > --- a/tools/widl/widl.c > +++ b/tools/widl/widl.c > @@ -139,7 +139,7 @@ int line_number = 1; > > static FILE *idfile; > > -unsigned int pointer_size = 0; > +unsigned int pointer_size = sizeof(void*); > syskind_t typelib_kind = sizeof(void*) == 8 ? SYS_WIN64 : SYS_WIN32; This is wrong, the host pointer size shouldn't have any influence on the generated code. -- Alexandre Julliard julliard(a)winehq.org

2 3

re: open bugs / multi thread / recommendation on new system
by Dan Kegel 19 Aug '13

19 Aug '13

Damian wrote: > 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? Don't know. I just use nvidia cards I find in the trash :-) But then I don't actually play games, so I don't care about 3d performance. > 2) FX 8320 or intel same price class CPU? As the AMD has far inferior > single thread performance but far superior multi thread performance - > does wine run a win32 single thread app as multi thread? does wine > make use of multithread in general? For what it's worth, when I was paying attention to such things, the command for cpu in `seq 0 3` do; sudo cpufreq-set -g performance -c $cpu; done is needed to get reasonable performance on my A8, see http://comments.gmane.org/gmane.comp.emulators.wine.devel/86659 Perhaps this also applies to more capable amd chips and current linux. wine just maps threads one to one, there is no magic. If the game uses multiple threads, then wine uses multiple threads. Rather than ask abstract questions here, you should probably go ask for framerates on specific games on the wine forum.

1 0

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)
by Alexandre Julliard 19 Aug '13

19 Aug '13

John Chadwick <johnwchadwick(a)gmail.com> writes: > This patch was posted a bit ago without any objections, but seemingly > slipped through the cracks. Very slight revisions were made since try > 3 to improve the conciseness of code. > > From 8157b8a3d347c47f7f21e74d621632b4a9f50fd6 Mon Sep 17 00:00:00 2001 > From: John Chadwick <johnwchadwick(a)gmail.com> > Date: Sun, 21 Jul 2013 14:41:37 -0400 > Subject: msxml3: Defer the conversion of XPath expressions to UTF-8. > > This patch changes the create_selection interface to accept a wide string > instead of an xmlChar string. This is a transitional change, which will be > needed as libxml2's XPath parser is phased out. > > The implementation of tagName_to_XPath also had to be changed as it was using > libxml2's UTF-8 string API. libxml2 contained a strcat that performed > reallocation, so it was replaced with a new function that does the same with > heap_realloc and wide strings (heap_strcatW in msxml_private.h.) That's a very inefficient way to build a string. Adding this as a helper is even worse since it will encourage other places to use it too. Please try to allocate a large enough buffer from the start, or if not possible grow it quadratically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume
by Henri Verbeet 19 Aug '13

19 Aug '13

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) > +{ > + volume->texture_level = level; > +} > I think that's a step in the wrong direction. I think this should be set on volume creation. We do have a construction like this for surfaces, but the reasons for that don't apply to volumes, and I'd like to get rid of it for surfaces as well if at all possible.

2 2

Re: [PATCH 3/5] wined3d: Properly allocate heap memory for volumes
by Henri Verbeet 19 Aug '13

19 Aug '13

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -184,7 +184,16 @@ HRESULT CDECL wined3d_volume_map(struct wined3d_volume *volume, > volume, map_desc, box, flags); > > if (!volume->resource.allocatedMemory) > - volume->resource.allocatedMemory = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, volume->resource.size); Can this ever happen?

2 1

Re: [PATCH 4/5] wined3d: Move volume booleans into a flags field
by Henri Verbeet 19 Aug '13

19 Aug '13

On 19 August 2013 10:52, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + volume->flags |= WINED3D_VFLAG_LOCKABLE; /* FIXME */ You'll probably want to fix that :-) I think you can just leave the flag out until you rename it to WINED3D_VFLAG_MAPPABLE in one of the later patches.

1 0