August 2013 - Wine-devel - list.winehq.org

Process for reporting security bugs?
by achurch+wine-devel＠achurch.org 13 Aug '13

13 Aug '13

[Please cc: me on any replies since I'm not subscribed to the list.] Hi, Is there a specific process for reporting security-related bugs in Wine? I've looked through winehq.org but haven't found any mention of such; I just wanted to make sure I haven't overlooked anything before posting the bug in a publicly visible manner. Thanks, --Andrew Church achurch+wine-devel(a)achurch.org http://achurch.org/

3 5

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events
by Hugh McMaster 13 Aug '13

13 Aug '13

On Monday, 12 August 2013, Ruslan Kabatsayev wrote: >I've tried applying your both patches, and it appears that Ctrl+C at >cmd prompt still closes cmd, although pressing it while "dir /s /w" is running works as expected. Hi Ruslan, I've just tested the Ctrl-C patches on the most recent version of Wine available from the Git repository. After patching, compiling and installing, I found no problems with either of the patches as you described. Ctrl-C did nothing when cmd.exe was open and no command was running. To be clear, I was running cmd.exe via wineconsole in Linux Mint 14: 1. wineconsole cmd.exe 2. Press Ctrl-C --> cmd.exe remains open. But if you run cmd.exe via wine itself, the terminal will terminate cmd.exe when Ctrl-C is pressed. 1. wine cmd.exe 2. Press Ctrl-C --> returned to terminal prompt. I hope this helps. If the patch still doesn't seem to work correctly, please let me know what operating system you use, and I'll run further tests. Hugh

2 2

Re: Compiler warnings on Debian Sid kfreebsd-i386
by Ken Sharp 12 Aug '13

12 Aug '13

On 12/08/13 20:15, Mislav Blazevic wrote: > It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. It does seem that way. :-) Or maybe :-(

1 0

Re: Compiler warnings on Debian Sid kfreebsd-i386
by Mislav Blazevic 12 Aug '13

12 Aug '13

It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. On Mon, Aug 12, 2013 at 9:15 PM, Mislav Blazevic <krofnica996(a)gmail.com>wrote: > It seems that xmlBufPtr was renamed to xmlBufferPtr in new libxml. > > > > On Mon, Aug 12, 2013 at 9:11 PM, Ken Sharp <kennybobs(a)o2.co.uk> wrote: > >> Following my previous e-mail (http://www.winehq.org/** >> pipermail/wine-devel/2013-**August/100754.html<http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html>) >> I have since moved from Wheezy to Sid to work around a Debian bug. >> >> libxml2 has been updated (2.8.0+dfsg1-7+nmu1 --> 2.9.1+dfsg1-3) as a >> result and introduced some new compiler warnings: >> >> /home/ken/wine-git/dlls/**msxml3/node.c: In function >> ‘htmldtd_dumpcontent’: >> /home/ken/wine-git/dlls/**msxml3/node.c:908:9: warning: passing argument >> 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled >> by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->ExternalID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c:912:13: warning: passing >> argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type >> [enabled by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->SystemID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c:918:9: warning: passing argument >> 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled >> by default] >> xmlBufferWriteQuotedString(**buf->buffer, cur->SystemID); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:1123:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferWriteQuotedString(**xmlBufferPtr buf, >> ^ >> /home/ken/wine-git/dlls/**msxml3/node.c: In function >> ‘node_transform_node’: >> /home/ken/wine-git/dlls/**msxml3/node.c:974:21: warning: passing >> argument 1 of ‘xmlBufferContent’ from incompatible pointer type [enabled by >> default] >> content = xmlBufferContent(output->**buffer); >> ^ >> In file included from /usr/include/libxml2/libxml/**parser.h:16:0, >> from /home/ken/wine-git/dlls/**msxml3/node.c:28: >> /usr/include/libxml2/libxml/**tree.h:734:3: note: expected >> ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ >> xmlBufferContent (const xmlBufferPtr buf); >> ^ >> >> Hopefully these mean something to someone. >> >> >> >

1 0

Compiler warnings on Debian Sid kfreebsd-i386
by Ken Sharp 12 Aug '13

12 Aug '13

Following my previous e-mail (http://www.winehq.org/pipermail/wine-devel/2013-August/100754.html) I have since moved from Wheezy to Sid to work around a Debian bug. libxml2 has been updated (2.8.0+dfsg1-7+nmu1 --> 2.9.1+dfsg1-3) as a result and introduced some new compiler warnings: /home/ken/wine-git/dlls/msxml3/node.c: In function ‘htmldtd_dumpcontent’: /home/ken/wine-git/dlls/msxml3/node.c:908:9: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->ExternalID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c:912:13: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->SystemID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c:918:9: warning: passing argument 1 of ‘xmlBufferWriteQuotedString’ from incompatible pointer type [enabled by default] xmlBufferWriteQuotedString(buf->buffer, cur->SystemID); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:1123:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferWriteQuotedString(xmlBufferPtr buf, ^ /home/ken/wine-git/dlls/msxml3/node.c: In function ‘node_transform_node’: /home/ken/wine-git/dlls/msxml3/node.c:974:21: warning: passing argument 1 of ‘xmlBufferContent’ from incompatible pointer type [enabled by default] content = xmlBufferContent(output->buffer); ^ In file included from /usr/include/libxml2/libxml/parser.h:16:0, from /home/ken/wine-git/dlls/msxml3/node.c:28: /usr/include/libxml2/libxml/tree.h:734:3: note: expected ‘xmlBufferPtr’ but argument is of type ‘xmlBufPtr’ xmlBufferContent (const xmlBufferPtr buf); ^ Hopefully these mean something to someone.

1 0

Question about implementing application compatibility
by Mislav Blazevic 12 Aug '13

12 Aug '13

For past two weeks I've been implementing apphelp.dll. I got that one working and moved onto kernel32 part of magic. According to various papers and blogs it seems that windows logs all exes and dlls ever executed in registry[1] and uses it as cache to lookup if binary needs to be shimmed or patched (if file isn't found, hard lookup of shim database is done) It is loaded on boot and saved back to registry on shutdown. This is awfully overcomplicated (plus I do not know how to make such a "global" variable in wine) so I was wondering is it OK to implement this differently than windows does it. It would be simpler to control app compat with environmental variable. It would mean that Base*Appcompat* kernel32 APIs would remain unimplemented but as far as I know, no application uses them anyway, other than windows internally. What do you think? [1] https://github.com/mandiant/ShimCacheParser

2 1

Re: ntdll/tests: test FileDispositionInformation file class
by Marvin 12 Aug '13

12 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26661 Your paranoid android. === WXPX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === WVISTAX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === W7PROX64 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002) === TEST64_W7SP1 (32 bit file) === file.c:1318: Test failed: Unexpected NtQueryInformationFile result (expected STATUS_INVALID_INFO_CLASS, got c0000002)

1 0

Re: [1/2] cmd: Add handler support for Ctrl-C and Ctrl-Break events
by Ruslan Kabatsayev 11 Aug '13

11 Aug '13

Hi, On Sun, Aug 11, 2013 at 12:33 PM, Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > Jason Edmeades and I have developed a patch that handles Ctrl-C and Ctrl-Break events in wineconsole's cmd.exe. > > The patch supports interactive mode, batch contexts and both the cmd /c and cmd /k modes, meaning that pressing Ctrl-C no longer closes cmd.exe. I've tried applying your both patches, and it appears that Ctrl+C at cmd prompt still closes cmd, although pressing it while "dir /s /w" is running works as expected. > > For loops, commands such as 'dir /s /w' and other such commands can be stopped. Batch scripts prompt the user whether the current batch execution should end. > > --- > programs/cmd/builtins.c | 95 ++++++++++++++++++++++++++++++++++++++++++----- > programs/cmd/cmd.rc | 2 + > programs/cmd/wcmd.h | 7 ++++ > programs/cmd/wcmdmain.c | 65 +++++++++++++++++++++++++++++++- > 4 files changed, 158 insertions(+), 11 deletions(-) > > > Regards, Ruslan

1 0

Compiler warnings on Debian kfreebsd-i386
by Ken Sharp 11 Aug '13

11 Aug '13

Some interesting, some not: /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not used [-Wunused-function] /home/ken/wine-git/dlls/jscript/parser.y: conflicts: 1 shift/reduce, 18 reduce/reduce /home/ken/wine-git/dlls/msi/sql.y: conflicts: 1 reduce/reduce /home/ken/wine-git/dlls/ntdll/directory.c: In function ‘wine_getdirentries’: /home/ken/wine-git/dlls/ntdll/directory.c:1710:5: warning: passing argument 4 of ‘getdirentries’ from incompatible pointer type [enabled by default] In file included from /home/ken/wine-git/dlls/ntdll/directory.c:29:0: /usr/include/dirent.h:313:18: note: expected ‘__off_t * __restrict__’ but argument is of type ‘long int *’ /home/ken/wine-git/dlls/vbscript/parser.y: conflicts: 6 shift/reduce /home/ken/wine-git/programs/winedbg/dbg.y: conflicts: 1 shift/reduce, 1 reduce/reduce /home/ken/wine-git/programs/winedbg/dbg.y: conflicts: 1 shift/reduce, 1 reduce/reduce

2 5

Is it a little bug in wbemprox?
by Jing Li 10 Aug '13

10 Aug '13

Hi, When I ran a simple win32 program just via WMI with query of "SELECT * from Win32_Directory", wine1.6 crashed. And when I checked the related code I found that the function of "static UINT seed_dirs( struct dirstack *dirstack, const struct expr *cond, WCHAR root, UINT *count )", in dlls/wbemprox/builtin.c:1086, accessing cond's member without checking if it's NULL! Unfortunately a NULL is passed to it. That's why my program crashed. It's a bug, right?

2 1