August 2013 - Wine-devel - list.winehq.org

Re: msvcp90/tests: Add dynamically loaded functions for ARM
by Marvin 07 Aug '13

07 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26637 Your paranoid android. === WXPX64 (32 bit misc) === No test summary line found === WXPX64 (32 bit ios) === No test summary line found

1 0

Re: Request to add wow64 keyword to bugzilla
by Ken Sharp 07 Aug '13

07 Aug '13

+1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: > On Wed, 07 Aug 2013 14:23:53 +0100 > Ken Sharp <kennybobs(a)o2.co.uk> wrote: > > >> Would I be right in assuming you would like to see bugs in 32-bit >> applications that are only present in a wow64 WINEPREFIX? Are there many? > > Yes. As to how many there are, I've been able to find 7 by doing searches of summaries/comments for things like "wow64" and "64" and then reading the bugs to see if they fit, but since people have such wildly varying ways of phrasing things, I don't know if that's all of them. I have seen it often enough on the forum that I now routinely tell 64 bit users to try a 32 bit wineprefix and have added instructions on how to create one to the FAQ. That's why I'd like an easier way to track these bugs. I see. A lot of people say this over and over again. +1 from me for a wow64 keyword. They may even be fairly easy to solve (picking the right paths / registry entries). > > As to keyword usage, some of those bugs were tagged with the win64 keyword, some weren't. I know there is also a win32 keyword, and perhaps that is meant to be used for the kinds of bugs I am looking for, but if so, that is not at all clear from the keyword definition, and it is not how people are using the keywords. > There's no win32 keyword?

3 2

Re: msvcp90/tests: Skip tests on missing functions
by Piotr Caban 07 Aug '13

07 Aug '13

On 08/06/13 23:00, André Hentschel wrote: > @@ -749,6 +749,13 @@ static BOOL init(void) > > SET(p_basic_istream_char_read_uint64, > "??5?$basic_istream(a)DU?$char_traits(a)D@std@@@std@@QAEAAV01(a)AA_K@Z"); > + > + if (!p_basic_istream_char_read_uint64) > + { > + skip("_basic_istream_char_read_uint64 not found, skipping tests\n"); > + return FALSE; > + } Why are you skipping the tests instead of properly initializing functions pointers on ARM?

2 1

Request to add wow64 keyword to bugzilla
by Rosanne DiMesio 07 Aug '13

07 Aug '13

Can wow64 be added as a keyword to bugzilla? I know we already have win64 as a keyword, but that's being used for both 64 bit apps and 32 bit apps in a 64 bit wineprefix. I'm interested in being able to track the latter, as it's hitting increasing numbers of users. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: [PATCH] typo fixes (https://github.com/vlajos/misspell_fixer)
by Frédéric Delanoy 07 Aug '13

07 Aug '13

On Mon, Aug 5, 2013 at 9:41 PM, Veres Lajos <vlajos(a)gmail.com> wrote: > > Signed-off-by: Veres Lajos <vlajos(a)gmail.com> > --- > dlls/comctl32/tests/trackbar.c | 2 +- > documentation/ChangeLog.ALPHA | 80 ++++++++++++++++++++-------------------- > documentation/ChangeLog.BETA | 44 +++++++++++----------- > documentation/ChangeLog.OLD | 24 ++++++------ > tools/winebuild/utils.c | 2 +- > 5 files changed, 76 insertions(+), 76 deletions(-) The "documentation/ChangeLog.*" files have been removed so the patch won't apply. Frédéric Delanoy

1 0

Re: msvcrt: strncpy doesn't compliant C standard (try 2)
by Frédéric Delanoy 07 Aug '13

07 Aug '13

On Tue, Aug 6, 2013 at 10:44 PM, Álvaro Nieto <alvaro.nieto(a)gmail.com> wrote: > Remove strlen and implement some tests You should probably add tests for when the source string is not null-terminated. Frédéric Delanoy

1 0

Re: msvcp90/tests: Skip tests on missing functions
by Marvin 06 Aug '13

06 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26628 Your paranoid android. === WXPX64 (32 bit misc) === No test summary line found === WXPX64 (32 bit ios) === No test summary line found

1 0

Re: msvcr90/tests: Skip when _type_info_name_internal_method is not found
by Marvin 06 Aug '13

06 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26627 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: ws2_32/tests: Fix a comment
by Juan Lang 06 Aug '13

06 Aug '13

Hi Andre, - /* this is a io heavy test, do it at the end so the kernel doesn't start dropping packets */ + /* this is a heavy io test, do it at the end so the kernel doesn't start dropping packets */ To my eyes, this isn't an improvement. A slight improvement might be "this is a io-heavy test", or "this is an io-heavy test", but I'm not sure it's enough of an improvement to bother. --Juan

1 0

Re: msvcrt: strncpy doesn't compliant C standard
by Nikolay Sivov 06 Aug '13

06 Aug '13

On 8/6/2013 11:09, Álvaro Nieto wrote: > This patch solves [Bug 34211]. The implementation of strncpy function > doesn't compliant with C standard [1]. Also Microsoft Visual Studio > C/C++ compiler is ok with the standard [2]. > > Extract from msdn; > > "The strncpy function copies the initial count characters of strSource > to strDest and returns strDest. If count is less than or equal to the > length of strSource, a null character is not appended automatically to > the copied string. If count is greater than the length of strSource, > the destination string is padded with null characters up to length > count. The behavior of strncpy is undefined if the source and > destination strings overlap." > > [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/strncpy.html > [2] http://msdn.microsoft.com/en-us/library/vstudio/xdsywd25.aspx This needs tests.

1 0