September 2013 - Wine-devel

Re: [PATCH 2/2] d3dx9/tests: Add matrix column register count clamp test.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2259 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] imm32: Prevent assocating cross thread default contexts
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2257 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/4] imm32: use thread data from target HWND
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2256 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2255 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Test invalid volume lock boxes.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2254 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Add tests for block-based volume formats (try 2).
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2253 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2252 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2251 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().
by Roderick Colenbrander 20 Sep '13

20 Sep '13

That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and nMaxFormats), is probably wrong then. I had issues with this part in the past, so there maybe a small typo (it may just be off by 1). Roderick On Thu, Sep 19, 2013 at 6:37 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winex11.drv/opengl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > >

2 1

Re: D3D command stream patches for testing
by Forest 20 Sep '13

20 Sep '13

>In the past months I have been working on a command stream / worker >thread for wined3d. It moves most OpenGL calls into a separate thread >to improve performance (bug 11674) and fix some bugs that are >otherwise hard to fix (24684). Thank you, Stefan! I applied your patches to the Ubuntu PPA that I maintain for Guild Wars 2 players: https://launchpad.net/~foresto/+archive/winepatched/ I'm not seeing a spectacular difference with the CSMT patches, but I am seeing a difference. I ran some quick tests in Guild Wars 2 while standing still outside the Lion's Arch bank, looking down at the forge with a moderate number of players milling about and fireworks being launched. Pierre Franco said (earlier in this discussion) that he gets better results when running with the -dx9single command line switch, so I tested with and without it. Note that I play with the WINEDEBUG=-all environment variable. Here are my results: CSMT="disabled", running with -dx9single: 15-16 fps CSMT="enabled" running without -dx9single: 19-21 fps CSMT="enabled", running with -dx9single: 22-23 fps So, almost 50% improvement for me, which is not what I remember when running natively under Windows, but is still a very welcome improvement. I wonder if the 80%+ gains reported in other games are not to be seen in Guild Wars 2, or if they're heavily dependent on CPU, GPU, graphics driver, and screen resolution. For the record, I'm using an Intel i5-3570K (stock speeds), GeForce GTX 660Ti (factory overclocked), nVidia driver 313.30, and a 1920x1200 display. I'm running Xubuntu 64-bit. My in-game options are: Resolution: Full Screen - 1920x1200 Refresh Rate: Default Frame Limiter: Unlimited Interface Size: Normal Animation: High Anti-Aliasing: FXAA Environment: High LOD Distance: High Reflections: Terrain & Sky Textures: Medium Render Sampling: Native Shadows: Medium Shaders: Medium Post-Processing: High Character Model Limit: High Character Model Quality: High + Best Texture Filtering + Depth Blur + Effect LOD + High-Res Character Textures - Vertical Sync

3 4