September 2013 - Wine-devel

Re: [PATCH 2/6] wined3d: Add support for converted volumes.
by Henri Verbeet 20 Sep '13

20 Sep '13

On 20 September 2013 13:04, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static BOOL wined3d_volume_can_evict(const struct wined3d_volume *volume) > +{ > + if (volume->resource.pool != WINED3D_POOL_MANAGED) > + return FALSE; > + if (volume->download_count < 10) > + return FALSE; That doesn't look quite right.

1 0

Re: [PATCH 6/6] wined3d: Use GL_APPLE_client_storage for volumes if available.
by Henri Verbeet 20 Sep '13

20 Sep '13

On 20 September 2013 13:04, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED); > + volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED > + | WINED3D_VFLAG_CLIENT_STORAGE); > Indentation looks a bit off here.

1 0

Re: (resend)[3/4] imm32: use thread data from target HWND
by Alexandre Julliard 20 Sep '13

20 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -507,7 +524,7 @@ HIMC WINAPI ImmAssociateContext(HWND hWnd, HIMC hIMC) > LeaveCriticalSection(&threaddata_cs); > defaultContext = ImmCreateContext(); > ((InputContextData*)defaultContext)->threadDefault = TRUE; > - thread_data = IMM_GetThreadData(0); > + thread_data = IMM_GetThreadDataForWindow(hWnd); > thread_data->defaultContext = defaultContext; > } You have multiple race conditions here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] oledb32: Correct DataLinks interface for win64
by Alexandre Julliard 20 Sep '13

20 Sep '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -26,6 +26,20 @@ import "oledb.idl"; > #define vi_progid(str) > #endif > > +#ifdef _WIN64 > +cpp_quote("#ifdef _WIN64") > + typedef LONGLONG COMPATIBLE_LONG; > +cpp_quote("#else") > +cpp_quote(" typedef LONG COMPATIBLE_LONG;") > +cpp_quote("#endif") > +#else > +cpp_quote("#ifdef _WIN64") > +cpp_quote(" typedef LONGLONG COMPATIBLE_LONG;") > +cpp_quote("#else") > + typedef LONG COMPATIBLE_LONG; > +cpp_quote("#endif") > +#endif You can't do that, _WIN64 is not meaningful in idl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] winemac: Implement support for global hot keys.
by Vincent Povirk 20 Sep '13

20 Sep '13

I don't think this is going to work correctly when replacing hotkeys (by passing an already-registered hwnd and id to RegisterHotKey with a different key combination). Since the user driver's RegisterHotKey function will be called with the new id/vkey/flags before UnregisterHotKey is called for the existing hotkey's id/vkey/flags, the user driver has to distinguish them based on vkey/flags. I think you can still get away with a mapping with hwnd/id as keys, as long as you check for matching vkey/flags when you unregister a hotkey. (Of course, I'm not convinced the user driver should ever post WM_HOTKEY, since the input should go through low-level keyboard hooks first, which is why I did not include the id as an argument to these entry points. If we decided to pass the id through, there would technically be no need for RegisterHotKey to call the user driver's UnregisterHotKey in this case.)

1 0

Re: [PATCH 2/3] iphlpapi: Add interface enumeration for Android.
by Bruno Jesus 19 Sep '13

19 Sep '13

On Thu, Sep 19, 2013 at 10:06 AM, Huw Davies <huw(a)codeweavers.com> wrote: > --- > configure.ac | 3 +- > dlls/iphlpapi/ifenum.c | 199 ++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 200 insertions(+), 2 deletions(-) Hi, Huw. I'm not sure this is an issue but in the android implementation of get_interface_indexes you are not setting + if (table) *table = NULL; in the begining like in the other 2 implementations. Or I didn't understand the code correctly. Best wishes, Bruno

2 1

Re: [PATCH 3/5] mshtml: Keep moniker reference after start_binding call.
by Alexandre Julliard 18 Sep '13

18 Sep '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/navigate.c | 3 --- > 1 file changed, 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here make: *** [url.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] user32: Add a SetMinMaxInfo driver entry point.
by Alexandre Julliard 18 Sep '13

18 Sep '13

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/user32/driver.c | 12 ++++++++++++ > dlls/user32/user_private.h | 1 + > dlls/user32/winpos.c | 2 ++ > 3 files changed, 15 insertions(+), 0 deletions(-) It's better to avoid adding entry points that don't correspond to Windows APIs. Instead you should request the info when you need it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [4/4] ws2_32: Do not allow socket creation if WSAStartup was not called
by Marvin 18 Sep '13

18 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2238 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error
by Marvin 18 Sep '13

18 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2237 Your paranoid android. === build (build) === Patch failed to apply

1 0