January 2014 - Wine-devel - list.winehq.org

Re: ws2_32: Fix FreeBSD compiling issue on ipx address structure
by Francois Gouget 06 Jan '14

06 Jan '14

On Sun, 5 Jan 2014, Bruno Jesus wrote: > Manually tested on PC-BSD which also shows the issue. I think it would even work to compare sipx_network and sipx_node in one go. There is already code that copies them that way in ws_sockaddr_ws2u(): memcpy(&uipx->sipx_network,wsipx->sa_netnum,sizeof(uipx->sipx_network)+sizeof(uipx->sipx_node)); So we could do (compiles but not tested): diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 0391554..a92c5c3 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1473,7 +1473,10 @@ static BOOL is_sockaddr_bound(const struct sockaddr *uaddr, int uaddrlen) { static const struct sockaddr_ipx emptyAddr; struct sockaddr_ipx *ipx = (struct sockaddr_ipx*) uaddr; - return ipx->sipx_port || ipx->sipx_network || memcmp(&ipx->sipx_node, &emptyAddr.sipx_node, sizeof(emptyAddr.sipx_node)); + + /* compare sipx_network and sipx_node in one go to ease portability */ + return ipx->sipx_port || + memcmp(&ipx->sipx_network, &emptyAddr.sipx_network, sizeof(emptyAddr.sipx_network) + sizeof(emptyAddr.sipx_node)); } #endif case AF_INET6: But your patch works too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

1 0

Re: [PATCH] msvcp90: mark _invalid_parameter as noreturn (Coverity)
by Piotr Caban 06 Jan '14

06 Jan '14

On 01/04/14 18:25, Marcus Meissner wrote: > 1147947 Dereference after null check > > after not seeing that _invalid_parameter will not return, > so just mark the function as such, perhaps coverity then notices it. The function may return if application sets custom invalid parameter handler. I guess it shouldn't be marked as DECLSPEC_NORETURN. Probably all the places where it's used should be changed to return an error after calling _invalid_parameter.

1 0

Re: Assorted spelling fixes
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4014 Your paranoid android. === wvista (32 bit render) === render.c:1276: Test failed: GetPosition failed: 00000001 === w7pro64 (64 bit render) === render.c:664: Test failed: Wait(event) after Stop gave 102

1 0

Re: DxDiag Demo Patch
by khuaja_lucky＠yahoo.com 05 Jan '14

05 Jan '14

Sent from my iPhone

1 0

Re: bcrypt: Added BCryptGenRandom stub
by Dmitry Timoshkov 05 Jan '14

05 Jan '14

Jascha Knack <jascha.knack(a)smail.inf.h-brs.de> wrote: > +NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE hAlgorithm, PUCHAR > pbBuffer, > + ULONG cbBuffer, ULONG dwFlags) > +{ > + FIXME("%08x, %08x, %08x, %08x - stub\n", hAlgorithm, pbBuffer, > cbBuffer, dwFlags); > + > + return ERROR_CALL_NOT_IMPLEMENTED; > +} If the API is supposed to return NTSTATUS it can't return a win32 error code. Also some of the printf format specifiers should be %p. P.S. Your mailer has mangled the patch. -- Dmitry.

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy 04 Jan '14

04 Jan '14

On Sat, Jan 4, 2014 at 4:33 PM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > What do you mean saying 'to group together' ? I mean typo fixes in dll_A and dll_B should be in the same patch. -- Frédéric Delanoy

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Bruno Jesus 04 Jan '14

04 Jan '14

On Sat, Jan 4, 2014 at 3:25 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Please ignore this patch, I didn't see Erich was trying to get in his interface change notifications patches. They are specially useful for a complete implementation of WSASLookupService*, when they get commited I'll be able to create a more complete test. Best wishes, Bruno

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy 04 Jan '14

04 Jan '14

You'd probably want to group together all those typo/spelling patches. They aren't generally susceptible to breaking things. -- Frédéric Delanoy

1 0

Re: comctl32: Add opening and closing brackets and remove spaces
by Dmitry Timoshkov 04 Jan '14

04 Jan '14

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > --- a/dlls/comctl32/animate.c > +++ b/dlls/comctl32/animate.c > @@ -499,7 +499,7 @@ static BOOL ANIMATE_GetAviInfo(ANIMATE_INFO *infoPtr) > > if ((ckMainRIFF.ckid != FOURCC_RIFF) || > (ckMainRIFF.fccType != mmioFOURCC('A', 'V', 'I', ' '))) { > - WARN("Can't find 'AVI ' chunk\n"); > + WARN("Can't find 'AVI' chunk\n"); This change is wrong. -- Dmitry.

1 0

Re: [7/7] gdi32: Improve vertical writing metrics.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3982 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0