January 2014 - Wine-devel - list.winehq.org

Re: [6/7] gdi32/tests: Add tests for vertical writing metrics.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3981 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [5/7] gdi32: Fix ABC metrics for rotated font.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3980 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [4/7] gdi32/tests: Add more GetCharABCWidths tests for rotated font.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3979 Your paranoid android. === wxppro (32 bit font) === font.c:1330: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0

1 0

Re: [4/4] ws2_32/tests: Add some FIONREAD tests
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3976 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3975 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)
by Dmitry Timoshkov 04 Jan '14

04 Jan '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > + > + err = GetLastError(); > + ok ( handle != INVALID_HANDLE_VALUE, "FindFirstFile on %s failed\n", buffer2 ); > + ok ( !err , "FindFirstFile failed, Error number %d\n", err ); > + This block looks like an orphaned part of some removed test. -- Dmitry.

2 2

Question about test_RemoveDirectory()
by Zhenbo Li 04 Jan '14

04 Jan '14

Hello, I found that test_RemoveDirectory() is in dlls/kernel32/tests/file.c, while RemoveDirectoryA() and RemoveDirectoryW() are in dlls/kernel32/path.c I checked git log, and found that they came from commit ad9b79932410f7c, Reimplemented CreateDirectoryW and RemoveDirectoryW using ntdll functions. Should I move test_RemoveDirectory() to dlls/kernel32/tests/path.c? Thanks. -- Have a nice day! Zhenbo Li

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 2)
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3973 Your paranoid android. === wxppro (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === wvista (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0

1 0

Re: ntdll/tests: Add test for deleting via NtOpenFile
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3962 Your paranoid android. === w7pro64 (32 bit file) === file.c:331: Test failed: open L"system32" failed c000003b file.c:338: Test failed: open L"SYSTEM32" failed c000003b file.c:346: Test failed: open L"\\SYSTEM32" failed c0000034 file.c:356: Test failed: open L"\\SYSTEM32" failed c000003b

2 1

Re: [PATCH 5/5] d3dx9_36/tests: Use NAN.
by Francois Gouget 03 Jan '14

03 Jan '14

On Thu, 2 Jan 2014, Stefan Dösinger wrote: [...] > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -4800,7 +4800,7 @@ static void test_create_skin_info(void) [...] > - exp_weights[1] = 0.0f / 0.0f; /* NAN */ > + exp_weights[1] = NAN; This patch breaks the compilation on Solaris because it does not define NAN (except in math_c99.h but we cannot use that, see below). But independently from that I think it's wrong because one should be able to compile the conformance tests on Windows. This means we cannot use things like config.h or port.h and should only use stuff that's defined in Windows headers. But as far as I can tell the Windows SDK does not define NAN. There is a definition of NAN in the CRT xmath.h header but Wine does not have that header and we're obviously not including it here. So one solution would be to revert the patch. Another would be to copy wine/port.h's __port_nan() definition. Yet another might be to add xmath.h and a dependency on msvcrt.dll. But maybe there's a better way still? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

2 2