December 2014 - Wine-devel - list.winehq.org

Re: user32/tests: Remove unused variables (Clang)
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10592 Your paranoid android. === w7u (32 bit msg) === msg.c:12105: Test failed: unexpected hwnd 0012013C msg.c:12127: Test failed: bad time 310a2/310b2

1 0

Re: user32/tests: Remove unused variables (Clang)
by André Hentschel 03 Dec '14

03 Dec '14

Am 03.12.2014 um 23:53 schrieb André Hentschel: > --- > dlls/user32/tests/msg.c | 112 ------------------------------------------------ > 1 file changed, 112 deletions(-) Just want to note, that this code was added in 2003 and most likely has never been used, just in case someone wonders why i dare to remove so much code ;)

1 0

Re: [PATCH 08/15] msvcr120: Remove stray parameter specs for stub functions.
by Alexandre Julliard 03 Dec '14

03 Dec '14

Martin Storsjo <martin(a)martin.st> writes: > This avoids adding stray functions when using make_specfiles. There shouldn't be any reason to do that. The parameters are here on purpose. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.
by Qian Hong 03 Dec '14

03 Dec '14

Hi Indrek, On Mon, Dec 1, 2014 at 3:46 PM, Indrek Altpere <efbiaiinzinz(a)hotmail.com> wrote: > Hello > > I even saw your patch in my inbox but it does not appear at > https://source.winehq.org/patches/data/107949 for some reason, so I don't > remember what lines you changed exactly so apologies if I seem to be > re-stating things tou fixed already. > > > When checking > http://source.winehq.org/git/wine.git/blob_plain/HEAD:/loader/wine.inf.in > there is also tons of other discrepancies (if you didn't already). > > > Parameters are escaped with ""%1"" but not command: > HKCR,Msi.Package\shell\Open\command,,2,"%11%\msiexec.exe /i ""%1""" > HKCR,Msi.Package\shell\Repair\command,,2,"%11%\msiexec.exe /f ""%1""" > HKCR,Msi.Package\shell\Uninstall\command,,2,"%11%\msiexec.exe /x ""%1""" > > > Command itself is escaped: > HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" > > > Neither command nor parameter is escaped: > HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe > setupapi,InstallHinfSection DefaultInstall 132 %1" > > HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" > > > If winebrowser needs escaping because %11 contains a space then all other > places also use %11 need that escaping. And if msiexec need to escape %1 > then all other places need it too don't they? > Thanks a lot for your comment, I'm investigating a bit more... Will update later :) -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 01/15] msvcr120: Implement the _vacopy function.
by Martin Storsjö 03 Dec '14

03 Dec '14

Hi, On Mon, 1 Dec 2014, Martin Storsjo wrote: > --- > dlls/msvcr120/msvcr120.spec | 2 +- > dlls/msvcrt/misc.c | 8 ++++++++ > include/msvcrt/crtdefs.h | 2 ++ > 3 files changed, 11 insertions(+), 1 deletion(-) I saw on http://source.winehq.org/patches/ that this one was rejected - any comment on why and what needs to be fixed? // Martin

2 1

Re: [PATCH 02/15] msvcr120: Implement more C99 math functions.
by Alexandre Julliard 03 Dec '14

03 Dec '14

Martin Storsjo <martin(a)martin.st> writes: > Implement the *rint, trunc, *round, log2, exp2 and cbrt > function families. > > These are directly passed on to the corresponding host > libc functions. You can't do that, there's no guarantee that the host has these functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ole32: fixed CoWaitForMultipleHandles cause app hang
by Sebastian Lackner 03 Dec '14

03 Dec '14

On 03.12.2014 08:15, Changhui Liu wrote: > > > Do I understand you correctly that this is caused by my recent fix of CoWaitForMultipleHandles? Which app is it? Your change might be correct, but to ensure that this is the case please add a test for it: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ole32/tests/compobj.c… Moreover you should completely remove old code then, not just comment it out. Regards, Sebastian

1 0

Re: msi: Properly handle service control events in Start/StopService.
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10574 Your paranoid android. === wxppro (32 bit action) === The test timed out === w7u (32 bit action) === The test timed out === w8 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

1 0

Re: ole32/tests: Remove unused variable (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10569 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000421BDA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000421BDA

1 0

Re: msi/tests: Remove unused variables (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10567 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out === w8 (32 bit install) === The test timed out

1 0