December 2014 - Wine-devel - list.winehq.org

Re: mshtml/tests: Remove unused variable (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10565 Your paranoid android. === w2000pro (32 bit events) === The test timed out

1 0

Re: kernel32/tests: Remove unused strings (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10564 Your paranoid android. === wvistau64 (32 bit file) === file.c:365: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:365: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [PATCH 2/3] d3d8: Refuse to reset a lost device (v2).
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10563 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 1/5] d3d9: Refuse to reset a lost device.
by Henri Verbeet 01 Dec '14

01 Dec '14

On 28 November 2014 at 11:16, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!device->d3d_parent->extended && InterlockedCompareExchange(&device->device_state, > + D3D9_DEVICE_STATE_LOST, D3D9_DEVICE_STATE_LOST) == D3D9_DEVICE_STATE_LOST) Do you need the InterlockedCompareExchange()?

2 3

Re: mshtml: Added support for flag 2 in getAttribute.
by Marvin 01 Dec '14

01 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10556 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.
by Qian Hong 01 Dec '14

01 Dec '14

Hi, `git grep command | grep HKCR | grep -v '"""'` exposed more places which seems missing quotes in command key, anyone know if we should update every place? Any advice is great appreciated! loader/wine.inf.in:HKCR,chm.file\shell\open\command,,2,"%10%\hh.exe %1" loader/wine.inf.in:HKCR,cplfile\shell\cplopen\command,,2,"rundll32.exe shell32.dll,Control_RunDLL ""%1"",%*" loader/wine.inf.in:HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" loader/wine.inf.in:HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe setupapi,InstallHinfSection DefaultInstall 132 %1" loader/wine.inf.in:HKCR,inifile\shell\open\command,,2,"%11%\notepad.exe %1" loader/wine.inf.in:HKCR,inifile\shell\print\command,,2,"%11%\notepad.exe /p %1" loader/wine.inf.in:HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" loader/wine.inf.in:HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" loader/wine.inf.in:HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" loader/wine.inf.in:HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" loader/wine.inf.in:HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" loader/wine.inf.in:HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" On Mon, Dec 1, 2014 at 1:38 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hi Piotr, > > This is a follow up of the below commit: > > commit 54833c9b7cf5f8f5e37b43038e1fa4c1c369deb0 > Author: Piotr Caban <piotr(a)codeweavers.com> > Date: Wed May 4 13:20:41 2011 +0200 > > wine.inf: Add quotes to webbrowser command keys. > > To make sure i'm not breaking anything which is intended, would you mind > have a look? > > Thanks! > > --- > loader/wine.inf.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0